mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577677934
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577660497
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -52,8 +51,8 @@ object ZooKeeperClient {
* @param sessionTimeoutMs session timeout in
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577656938
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577653920
##
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class
showuon merged PR #15787:
URL: https://github.com/apache/kafka/pull/15787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kamalcph commented on PR #15141:
URL: https://github.com/apache/kafka/pull/15141#issuecomment-2074558819
The patch is landed to trunk, 3.7 and 3.6 branches so closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kamalcph closed pull request #15141: KAFKA-16073: [Tiered] Update
localLogStartOffset before deleting segments in memory t…
URL: https://github.com/apache/kafka/pull/15141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16424.
---
Fix Version/s: 3.8.0
Resolution: Fixed
> truncated logs will be left undeleted after alter
showuon merged PR #15616:
URL: https://github.com/apache/kafka/pull/15616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2074547860
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kamalcph commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1577552070
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2074499876
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
>
>
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074488094
@chia7712 & @mimaison can you please have a look into this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lucasbru closed pull request #15789: Current working branch for KIP-848 kip
URL: https://github.com/apache/kafka/pull/15789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577504946
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Fiore Vitale reassigned KAFKA-15838:
--
Assignee: Mario Fiore Vitale
> [Connect] ExtractField and InsertField NULL
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577503137
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577499800
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577491649
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -107,16 +107,16 @@ class SharedServer(
@volatile var brokerMetrics: BrokerServerMetrics = _
dajac commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1577450806
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
dajac commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1577450172
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
dajac commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2074307269
@jolshan Thanks for the PR. Is there a reason why you removed
[216cc9d](https://github.com/apache/kafka/pull/15755/commits/216cc9dce46b7837282bd67bfab06ec045c9902c)?
It does not apply 1:1
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1577437212
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation
brandboat commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074282565
Failed tests seems related to this pr, I'll check them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1577407602
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##
@@ -198,6 +207,43 @@ private static void assertApiMessageAndVersionEquals(
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1577406177
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
showuon commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1577340553
##
core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala:
##
@@ -194,6 +199,8 @@ class AdminZkClientTest extends QuorumTestHarness with
Logging with RackAwareTes
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2074186450
Thanks for the patch @jeqo!
I was able to reproduce the exception mentioned in the ticket by calling
close in-middle of collecting the aborted transactions. The fix doesn't
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577316104
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
101 - 129 of 129 matches
Mail list logo
