[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-28 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1245629399 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -240,17 +240,18 @@ object RequestChannel extends Logging { val responseSendTimeMs =

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-28 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1245628587 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -240,17 +240,18 @@ object RequestChannel extends Logging { val responseSendTimeMs =

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244331034 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -17,25 +17,37 @@ package kafka.server +import

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244044199 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -17,25 +17,37 @@ package kafka.server +import

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244035570 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244034254 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242874939 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242731206 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242867082 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242731206 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242724200 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242721231 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242719150 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -2158,6 +2158,12 @@ object TestUtils extends Logging {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-23 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1240394281 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -240,16 +240,17 @@ object RequestChannel extends Logging { val responseSendTimeMs =

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-20 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1235928525 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -42,13 +50,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-13 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1228732870 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -240,16 +240,17 @@ object RequestChannel extends Logging { val responseSendTimeMs =

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-13 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1228731391 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -85,12 +93,14 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-09 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1224762118 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -240,16 +240,22 @@ object RequestChannel extends Logging { val responseSendTimeMs =

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-01 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1213757295 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -33,7 +35,8 @@ object AddPartitionsToTxnManager { class TransactionDataAndCallbacks(val

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

2023-06-01 Thread via GitHub
jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1213756543 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -85,12 +93,14 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client: