[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248282166 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248148380 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248102033 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248100591 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248094484 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248092632 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248092025 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086692 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248071005 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248060783 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248058020 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247163837 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -172,19 +186,21 @@ public List build(TopicsImage

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247156849 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -728,6 +794,81 @@ public void replay( }

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247155039 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247154202 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1246997020 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -537,8 +538,35 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244508147 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244508147 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244507539 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244506236 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -119,6 +131,18 @@ public String toString() { */

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244500812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244496874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244495117 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244495117 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244492766 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244485648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -727,6 +800,80 @@ public void replay( + "

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244485648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -727,6 +800,80 @@ public void replay( + "

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244482511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -709,14 +780,16 @@ public void replay( String groupId =

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244477507 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -88,10 +93,12 @@ public class GroupMetadataManager { public

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244475836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -506,32 +555,54 @@ private CoordinatorResult consumerGr

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244469064 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -179,26 +209,45 @@ GroupMetadataManager build() { private