showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1598169071
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1593390067
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1592297330
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590762158
##
storage/src/test/java/org/apache/kafka/tiered/storage/integration/AlterLogDirTest.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590749298
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590570923
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,19 +90,176 @@ public interface TierStateMachine {
*/
PartitionFetchState
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590570923
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,19 +90,176 @@ public interface TierStateMachine {
*/
PartitionFetchState
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590567527
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1858,16 +1858,6 @@ class KafkaConfigTest {
}
}
- @Test
- def
soarez commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2092980307
Thanks for fixing the import. There are some failing tests, please have a
look.
I think we need to delete
kamalcph commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2092058377
The latest changes lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587465657
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -17,15 +17,66 @@
package kafka.server;
+import java.io.BufferedReader;
+import java.io.File;
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587440706
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -17,15 +17,69 @@
package kafka.server;
+import java.io.BufferedReader;
+import java.io.File;
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587367900
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -17,15 +17,69 @@
package kafka.server;
+import java.io.BufferedReader;
+import java.io.File;
showuon commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2090048261
@soarez @kamalcph , thanks for the comments. I've updated the PR in this
commit:
https://github.com/apache/kafka/pull/15690/commits/97e2b47c68254928c0baf065eee14a7aeb6e12b2
.
--
This
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587357829
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587356992
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587346384
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java:
##
@@ -154,7 +154,7 @@ public static List
remoteStorageManagers(Seq br
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587318846
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3287,11 +3287,9 @@ class ReplicaManagerTest {
val path1 =
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587154091
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582791175
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582059485
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582055490
##
storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsWithTieredStoreTest.java:
##
@@ -74,7 +74,7 @@ public Properties topicConfig() {
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1580567800
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new
showuon commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2076987711
@mimaison @soarez , PR updated. Please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328510
##
storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328199
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,7 +92,72 @@ public interface TierStateMachine {
*/
PartitionFetchState
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579325677
##
core/src/test/scala/unit/kafka/server/TierStateMachineTest.scala:
##
@@ -153,12 +157,13 @@ class ReplicaFetcherTierStateMachineTest {
assertEquals(11L,
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579212500
##
storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1565635052
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,7 +92,72 @@ public interface TierStateMachine {
*/
PartitionFetchState
mimaison commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1560966402
##
storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1560139446
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,7 +92,72 @@ public interface TierStateMachine {
*/
PartitionFetchState
showuon opened a new pull request, #15690:
URL: https://github.com/apache/kafka/pull/15690
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
37 matches
Mail list logo