chia7712 merged PR #15772:
URL: https://github.com/apache/kafka/pull/15772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2071861237
Those failed tests pass on my local. will merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2071831061
> controller.listener.names
oh, it will be moved to `KRaftConfigs`. please ignore my previous comments.
--
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2070748890
Should we move following configs to `SocketServerConfigs`?
1. `controller.listener.names`
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574953974
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574952989
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574671001
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573897839
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573880096
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2068139760
```
Code Warning
FS Format string should use %n rather than \n in
org.apache.kafka.network.SocketServerConfigs.()
[Bug type VA_FORMAT_STRING_USES_NEWLINE
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573850333
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573853257
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2068132025
@OmniaGM I merge #15770 first since it is a smaller PR. Please fix
conflicts. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573850333
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573848774
##
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##
@@ -46,6 +42,10 @@ public class Defaults {
public static final int
OmniaGM opened a new pull request, #15772:
URL: https://github.com/apache/kafka/pull/15772
- Move socket configs and docs out of core and into
`org.apache.kafka.network.SocketServerConfigs`
- Move default values for socket configs into same class
### Committer Checklist (excluded
19 matches
Mail list logo
