Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

gharris1727 merged PR #15305: URL: https://github.com/apache/kafka/pull/15305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

gharris1727 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2121455690 Test failures appear unrelated, and the tests pass for me locally. LGTM, and thanks @vamossagar12 for the fix! -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2117312634 Thanks @gharris1727 for another round of review. I have made the changes. Please review when you have some time. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1604768491 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +268,20 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1604767686 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -850,6 +855,46 @@ public void testRequestTimeouts()

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1604759527 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerRebalanceListener.java: ## @@ -36,4 +37,15 @@ public interface

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1604757990 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -2704,6 +2704,11 @@ public void onRevoked(String

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596969230 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1205,7 +1215,7 @@ public void handle(LeaveGroupResponse

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

gharris1727 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596961414 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -850,6 +855,46 @@ public void testRequestTimeouts()

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

gharris1727 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596952044 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596621705 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/ConnectAssertions.java: ## @@ -76,7 +76,7 @@ public void assertAtLeastNumWorkersAreUp(int

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2104218899 Thanks @gharris1727 , I have made the changes as you suggested. I also modified the warning line that is printed based on the tick thread stage that is presented to the coordinator

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596476664 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

gharris1727 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1591278453 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1588778443 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1579057875 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1577316104 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1577225484 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1577223693 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1577220797 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1577219150 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2070326565 @showuon , I made some changes to the test so that we just heartbeat and not have to rely upon FindCoordinator requests. Let me know what yo think. Thanks! -- This is an automated

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1571150850 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1571147929 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1571150850 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1571147929 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1571146638 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1570226078 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1570217037 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1570111991 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1570217037 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2062936947 @showuon , just checking did you get a chance to look at the updated test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1559256180 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1559253060 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

showuon commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2042586830 Will check it this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2036805236 @showuon would you have time to review this? It's a smallish change. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474605205 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() {

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474598172 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474595936 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -93,9 +96,9 @@ public class WorkerCoordinatorTest

[PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

vamossagar12 opened a new pull request, #15305: URL: https://github.com/apache/kafka/pull/15305 Please refer to the description in [KAFKA-16197](https://issues.apache.org/jira/browse/KAFKA-16197). -- This is an automated message from the Apache Git Service. To respond to the message,