Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-24 Thread via GitHub
showuon merged PR #15616: URL: https://github.com/apache/kafka/pull/15616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-24 Thread via GitHub
showuon commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2074547860 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-23 Thread via GitHub
showuon commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2073911312 Retriggering CI build : https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15616/11/ -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-23 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575754146 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-23 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575753935 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575591635 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575558298 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1574551794 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -37,6 +40,10 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-21 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1574049613 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +123,57 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-21 Thread via GitHub
chia7712 commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2067966296 > thanks for the great suggestion. I took a look LogSegment#deleteIfExists and LogSegment#deleteTypeIfExists. If we want to handle fallback deletion in LocalLog, we may need to return

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-21 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1573652117 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-21 Thread via GitHub
FrankYang0529 commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2067936507 > This PR is good but it seems to me `LogSegment` should NOT guess the directory structure managed by upper class (i.e `LogManager`). > > It seems the root cause is caused by

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-20 Thread via GitHub
chia7712 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1573271296 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-19 Thread via GitHub
chia7712 commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2066277923 This PR is good but it seems to me `LogSegment` should NOT guess the directory structure managed by upper class (i.e `LogManager`). It seems the root cause is caused by following

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-19 Thread via GitHub
showuon commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2066130114 @johnnychhsu , do you have any other comments? I'll merge this at the weekend if no other comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-18 Thread via GitHub
FrankYang0529 commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2063996320 > @FrankYang0529 , there is checkstyle error: `[2024-04-17T14:04:27.072Z] [ant:checkstyle] [ERROR]

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
showuon commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2062889530 @FrankYang0529 , there is checkstyle error: `[2024-04-17T14:04:27.072Z] [ant:checkstyle] [ERROR]

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1569846240 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1569024432 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1568897953 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1568266346 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1568241856 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1567555940 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1567544147 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1567531204 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1567414173 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1567406313 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-15 Thread via GitHub
johnnychhsu commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1565898495 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-12 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1562184559 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

[PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-03-28 Thread via GitHub
FrankYang0529 opened a new pull request, #15616: URL: https://github.com/apache/kafka/pull/15616 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of