chia7712 merged PR #15652:
URL: https://github.com/apache/kafka/pull/15652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2094019717
> Those two classes are meant to be used with the console consumer. This is
why they are not referenced anywhere.
thanks for the reminder !
> I wonder if we should provide
dajac commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2094014351
@chia7712 Those two classes are meant to be used with the console consumer.
This is why they are not referenced anywhere. I wonder if we should provide an
equivalent one in java.
--
chia7712 commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-209382
> Yeah, I noticed those classes too. I am actually not sure what we kept
them. It may be for backward compatibility. I need to dig a little more on it.
It is anyway not related to this
chia7712 commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2093999641
There is a build having weird output, so I re-trigger QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1589206306
##
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##
@@ -399,6 +404,191 @@ class DumpLogSegmentsTest {
assertEquals(partialBatches,
chia7712 commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1589164350
##
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##
@@ -399,6 +404,191 @@ class DumpLogSegmentsTest {
assertEquals(partialBatches,
dajac commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2090789895
@chia7712 I updated the PR with a different approach. I now print the
records using the json converters. This allow me to post process the group
metadata record to deserialize the
dajac commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2037428994
> Also, it seems the following classes are useless.
Yeah, I noticed those classes too. I am actually not sure what we kept them.
It may be for backward compatibility. I need to dig a
dajac commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1551827679
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -398,9 +399,34 @@ object DumpLogSegments {
}
}
- private class OffsetsMessageParser extends
chia7712 commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1551795883
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -398,9 +399,34 @@ object DumpLogSegments {
}
}
- private class OffsetsMessageParser extends
11 matches
Mail list logo
