OmniaGM commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066275194
Thanks for getting the KIP out there for discussion and for fixing the
tests. Should this PR be a draft until we have the KIP voted in by the
community?
--
This is an automated
aaron-ai commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066276867
> Thanks for getting the KIP out there for discussion and for fixing the
tests. Should this PR be a draft until we have the KIP voted in by the
community?
OK
--
This is an
OmniaGM commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1572155918
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##
@@ -169,6 +170,7 @@ static Map sourceConsumerConfig(Map props) {
aaron-ai commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066221145
KIP has been created here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1039%3A+Disable+automatic+topic+creation+for+MirrorMaker2+consumers
--
This is an automated message
aaron-ai commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1569813058
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##
@@ -169,6 +170,7 @@ static Map sourceConsumerConfig(Map props) {
C0urante commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1569197938
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##
@@ -169,6 +170,7 @@ static Map sourceConsumerConfig(Map props) {
OmniaGM commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2061493764
Hi @aaron-ai thanks for the PR. Can you please have a look into the failing
tests
herehttps://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15728/1/#showFailuresLink
I believe they
aaron-ai opened a new pull request, #15728:
URL: https://github.com/apache/kafka/pull/15728
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
