lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2066577956
Hey @lucasbru , answering your questions : the new behaviour of the static
membership regarding a member that joins with dup group instance Id is
documented in
lucasbru commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2066195894
LGTM, thanks!
Merging this, however:
* Have we discussed the behavioral difference with broker team / David?
* Have we documented the behavioral difference anywhere?
--
lucasbru merged PR #15738:
URL: https://github.com/apache/kafka/pull/15738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r1570773742
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,26 +348,45 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2063881962
Hey @lucasbru, yes, I had closed it just to investigate a bit more about
some failures that I noticed, but ended up getting only to flaky behaviour not
related to the changes in this PR,
lucasbru commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2060943337
@lianetm did you mean to closet the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lianetm closed pull request #15738: KAFKA-16566: Fix consumer static membership
system test with new protocol
URL: https://github.com/apache/kafka/pull/15738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2060248860
FYI, I've been getting successful runs with this change:
running:
`TC_PATHS="tests/kafkatest/tests/client/consumer_test.py::OffsetValidationTest.test_fencing_static_consumer"
bash
lianetm commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r1568061403
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,13 +348,32 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
kirktrue commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r156796
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,13 +348,32 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2059888686
Hey @lucasbru, could you take a look at this test fix? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lianetm opened a new pull request, #15738:
URL: https://github.com/apache/kafka/pull/15738
Updating consumer system test that was failing with the new protocol,
related to static membership behaviour. The behaviour regarding static
consumers that join with conflicting group instance id is
12 matches
Mail list logo
