Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-19 Thread via GitHub
lianetm commented on code in PR #15753: URL: https://github.com/apache/kafka/pull/15753#discussion_r1572569170 ## tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py: ## @@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):

Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-19 Thread via GitHub
lianetm commented on code in PR #15753: URL: https://github.com/apache/kafka/pull/15753#discussion_r1572569170 ## tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py: ## @@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):

Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-19 Thread via GitHub
lucasbru commented on code in PR #15753: URL: https://github.com/apache/kafka/pull/15753#discussion_r1572534438 ## tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py: ## @@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):

Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-19 Thread via GitHub
lianetm commented on code in PR #15753: URL: https://github.com/apache/kafka/pull/15753#discussion_r1572508072 ## tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py: ## @@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):

Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-19 Thread via GitHub
lucasbru merged PR #15753: URL: https://github.com/apache/kafka/pull/15753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-18 Thread via GitHub
philipnee commented on PR #15753: URL: https://github.com/apache/kafka/pull/15753#issuecomment-2064308513 @lucasbru - This is just to remove the consumer protocol from testing as it is not suited for this test. Much appreciated if you get a chance to look at this. -- This is an

[PR] KAFKA-16579: Revert Consumer Rolling Upgrade [kafka]

2024-04-18 Thread via GitHub
philipnee opened a new pull request, #15753: URL: https://github.com/apache/kafka/pull/15753 Consumer Rolling Upgrade is meant to test the protocol upgrade for the old protocol. Therefore, I am removing old changes. ```