Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac merged PR #15785: URL: https://github.com/apache/kafka/pull/15785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1589199642 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,17 +1305,25 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1589109858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,17 +1305,25 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587922375 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587912985 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587912168 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587889094 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dongnuo123 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587655470 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dongnuo123 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587657454 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dongnuo123 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587655470 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587228256 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587225960 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1350,6 +1351,7 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587222161 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1587219947 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dongnuo123 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1586420616 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,53 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585160959 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585158392 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585155736 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,55 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583450532 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +982,61 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r158025 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1350,6 +1351,11 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583332135 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1350,6 +1351,11 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583314465 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583305142 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1350,6 +1351,11 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583305142 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1350,6 +1351,11 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1582678791 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581140616 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +987,23 @@ private static void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581134610 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -620,9 +637,10 @@ public Map computeSubscriptionMetadata(

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581132398 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java: ## @@ -204,7 +198,7 @@ private void createAssignmentSpec() {

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1580133686 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -687,7 +688,7 @@ public void

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1580115582 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -90,17 +91,29 @@ private Map> membersPerTopic(final

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1579102085 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ConsumerGroupSubscriptionModel.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1576317772 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -918,40 +935,53 @@ private void

[PR] KAFKA-16587: Add subscription model information to group state [kafka]

rreddy-22 opened a new pull request, #15785: URL: https://github.com/apache/kafka/pull/15785 When all the subscriptions are equal, we iterate through every member and check equality for the topic lists - very expensive when there’s more members -- This is an automated message from