chia7712 merged PR #15800:
URL: https://github.com/apache/kafka/pull/15800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586484285
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586043209
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586042610
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -118,16 +118,15 @@ public Stream
provideTestTemplateInvocationContex
return
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586041747
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585492894
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585486875
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585486875
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1582294569
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1581882839
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1581877562
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -118,16 +115,15 @@ public Stream
provideTestTemplateInvocationContex
return
TaiJuWu commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2081119063
> @TaiJuWu please fix the conflicts
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2081116576
@TaiJuWu please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1581842957
##
core/src/test/java/kafka/test/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
chia7712 commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2078284518
@TaiJuWu Could you add a new test file (`ClusterTestExtensionsUnitTest`) to
verify the function `processClusterTemplate`?
--
This is an automated message from the Apache Git Service.
TaiJuWu commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2076019523
> @TaiJuWu thanks for this contribution. btw, is this check (
>
>
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1578597252
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -123,8 +123,7 @@ private void processClusterTemplate(ExtensionContext
context,
TaiJuWu opened a new pull request, #15800:
URL: https://github.com/apache/kafka/pull/15800
As title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
18 matches
Mail list logo
