Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614174475 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614169536 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614159525 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614158684 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResource

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614157582 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -443,9 +525,33 @@ Map getConfigs(ConfigResource configResource) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614156696 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResource

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583446833 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583424779 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583423622 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583422586 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579894472 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -66,6 +69,7 @@ public class ConfigurationControlManager { private

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579888146 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579886194 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579880592 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579872828 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569269269 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569214320 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569210550 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568084297 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566471100 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566455070 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1564110479 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563199330 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563195256 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563193794 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on PR #15702: URL: https://github.com/apache/kafka/pull/15702#issuecomment-2052041676 @mumrah Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent opened a new pull request, #15702: URL: https://github.com/apache/kafka/pull/15702 https://issues.apache.org/jira/browse/KAFKA-16540 If the min isr config is changed, we need to update the partitions with ELR if possible. -- This is an automated message from the Apache