chia7712 commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518695740
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
ijuma commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518681734
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
chia7712 commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518649558
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
ijuma commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518648733
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
chia7712 merged PR #15488:
URL: https://github.com/apache/kafka/pull/15488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15488:
URL: https://github.com/apache/kafka/pull/15488#issuecomment-1986950699
the failed tests pass on my local.
```sh
./gradlew cleanTest core:test --tests QuorumControllerTest --tests
ReplicaManagerTest
```
--
This is an automated message from the
johnnychhsu commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1517940750
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,7 +353,10 @@ class LogLoaderTest {
// Intercept all segment read calls
val
johnnychhsu commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1517906750
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,7 +353,10 @@ class LogLoaderTest {
// Intercept all segment read calls
val
chia7712 commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1516370592
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,7 +353,10 @@ class LogLoaderTest {
// Intercept all segment read calls
val
johnnychhsu opened a new pull request, #15488:
URL: https://github.com/apache/kafka/pull/15488
## Context
In the `LogSegmnet`, the copy constructor is only used in LogLoaderTest
## Solution
Remove the copy constructor and build the logic in test
## Test
Run `./gradlew
10 matches
Mail list logo
