Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-05-24 Thread via GitHub
mimaison merged PR #15377: URL: https://github.com/apache/kafka/pull/15377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-05-23 Thread via GitHub
tinaselenge commented on PR #15377: URL: https://github.com/apache/kafka/pull/15377#issuecomment-2127382470 @mimaison thank you so much for reviewing the PR again. I think I have addressed the comments now. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-05-15 Thread via GitHub
mimaison commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1601900093 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -1776,6 +1776,33 @@ object TestUtils extends Logging { 45000) } + + def

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-26 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-26 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-11 Thread via GitHub
mimaison commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1560828250 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -258,4 +275,21 @@ class SslAdminIntegrationTest extends SaslSslAdminIntegrationTest

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-11 Thread via GitHub
mimaison commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1560822590 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends SaslSslAdminIntegrationTest

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-03 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1549736126 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-03-21 Thread via GitHub
mimaison commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1534098042 ## core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala: ## @@ -13,66 +13,94 @@ package kafka.api import java.util -import

[PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-02-15 Thread via GitHub
tinaselenge opened a new pull request, #15377: URL: https://github.com/apache/kafka/pull/15377 This makes the test simpler to enable KRaft later. It's unclear why a custom authoriser had to be used in the first place based on the commit made this change and tests seem to work