mimaison merged PR #15377:
URL: https://github.com/apache/kafka/pull/15377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tinaselenge commented on PR #15377:
URL: https://github.com/apache/kafka/pull/15377#issuecomment-2127382470
@mimaison thank you so much for reviewing the PR again. I think I have
addressed the comments now.
--
This is an automated message from the Apache Git Service.
To respond to the
mimaison commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1601900093
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1776,6 +1776,33 @@ object TestUtils extends Logging {
45000)
}
+
+ def
tinaselenge commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends
tinaselenge commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends
mimaison commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1560828250
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -258,4 +275,21 @@ class SslAdminIntegrationTest extends
SaslSslAdminIntegrationTest
mimaison commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1560822590
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends
SaslSslAdminIntegrationTest
tinaselenge commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1549736126
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends
mimaison commented on code in PR #15377:
URL: https://github.com/apache/kafka/pull/15377#discussion_r1534098042
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -13,66 +13,94 @@
package kafka.api
import java.util
-import
tinaselenge opened a new pull request, #15377:
URL: https://github.com/apache/kafka/pull/15377
This makes the test simpler to enable KRaft later.
It's unclear why a custom authoriser had to be used in the first place based
on the commit made this change and tests seem to work
10 matches
Mail list logo