[jira] [Commented] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831182#comment-17831182 ] Chia-Ping Tsai commented on KAFKA-16429: [~brandboat] Please feel free to un-assign this jira :)

[jira] [Updated] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16429: --- Parent: KAFKA-16385 Issue Type: Sub-task (was: Improvement) > Enhance all configs

[jira] [Assigned] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16429: -- Assignee: Kuan Po Tseng > Enhance all configs which can trigger rolling of new

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831186#comment-17831186 ] Chia-Ping Tsai commented on KAFKA-16414: [~ckamal] Thanks for nice sharing. As you have digged

[jira] [Updated] (KAFKA-16428) Fix bug where config change notification znode may not get created during migration

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16428: -- Fix Version/s: 3.6.2 3.8.0 3.7.1 > Fix bug where config change

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022073236 @nizhikov Could you please rebase it again? Sorry for late review :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16429: -- Summary: Enhance all configs which can trigger rolling of new segment Key: KAFKA-16429 URL: https://issues.apache.org/jira/browse/KAFKA-16429 Project: Kafka

[jira] [Assigned] (KAFKA-15715) KRaft support in UpdateFeaturesTest

2024-03-27 Thread johndoe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johndoe reassigned KAFKA-15715: --- Assignee: (was: johndoe) > KRaft support in UpdateFeaturesTest >

[jira] [Created] (KAFKA-16430) The group-metadata-manager thread is always in a loading state and occupies one CPU, unable to end.

2024-03-27 Thread Gao Fei (Jira)
Gao Fei created KAFKA-16430: --- Summary: The group-metadata-manager thread is always in a loading state and occupies one CPU, unable to end. Key: KAFKA-16430 URL: https://issues.apache.org/jira/browse/KAFKA-16430

[jira] [Updated] (KAFKA-16411) Correctly migrate default client quota entities in KRaft migration

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16411: -- Fix Version/s: 3.8.0 3.7.1 > Correctly migrate default client quota entities in

Re: [PR] KAFKA-16346: Fix flaky MetricsTest.testMetrics [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15502: URL: https://github.com/apache/kafka/pull/15502#issuecomment-2024338012 @FrankYang0529 , do we have any update for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-16161) Avoid creating remote log metadata snapshot file in partition data directory.

2024-03-27 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831619#comment-17831619 ] Kamal Chandraprakash commented on KAFKA-16161: -- Not yet started. Will work on this task by

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831631#comment-17831631 ] Manikumar commented on KAFKA-16310: --- Thanks, I have reverted  KAFKA-16341 and KAFKA-16342. commits

Re: [PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia commented on PR #15609: URL: https://github.com/apache/kafka/pull/15609#issuecomment-2024377686 Thank you @chia7712 @jolshan @soarez for the review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (KAFKA-16341) Fix un-compressed records

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16341: -- Fix Version/s: (was: 3.6.2) > Fix un-compressed records > - > >

[jira] [Updated] (KAFKA-16342) Fix compressed records

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16342: -- Fix Version/s: (was: 3.6.2) > Fix compressed records > -- > >

[jira] [Assigned] (KAFKA-16211) Inconsistent config values in CreateTopicsResult and DescribeConfigsResult

2024-03-27 Thread Dung Ha (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dung Ha reassigned KAFKA-16211: --- Assignee: Dung Ha > Inconsistent config values in CreateTopicsResult and DescribeConfigsResult >

[jira] [Reopened] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar reopened KAFKA-16310: --- > ListOffsets doesn't report the offset with maxTimestamp anymore >

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16310: -- Fix Version/s: (was: 3.6.2) > ListOffsets doesn't report the offset with maxTimestamp anymore >

Re: [PR] [MINOR] fix: Align LogContext setup for core components [kafka]

2024-03-27 Thread via GitHub
github-actions[bot] commented on PR #14348: URL: https://github.com/apache/kafka/pull/14348#issuecomment-2024335297 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Commented] (KAFKA-16435) Add test for KAFKA-16428

2024-03-27 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831609#comment-17831609 ] Luke Chen commented on KAFKA-16435: --- Thanks [~brandboat] ! > Add test for KAFKA-16428 >

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-27 Thread via GitHub
kamalcph commented on PR #15463: URL: https://github.com/apache/kafka/pull/15463#issuecomment-2024392191 @johnnychhsu Can you update the PR summary if it is ready for review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831629#comment-17831629 ] Chia-Ping Tsai commented on KAFKA-16310: {quote} Can we revert the relavent changes from 3.6

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022645115 @chia7712 CI are ready and seems OK for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] refactor: improve the output information during partition directory m… [kafka]

2024-03-27 Thread via GitHub
KevinZTW opened a new pull request, #15610: URL: https://github.com/apache/kafka/pull/15610 Currently, when we using `kafka-reassign-partitions` to move the log directory, the output only indicates which replica's movement has successfully started. This PR propose to show more

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541117312 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2022115723 Will check it this week or next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16365: AssignmentsManager callback handling issues [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15521: URL: https://github.com/apache/kafka/pull/15521#issuecomment-2022115867 Will try to review it this week or next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831208#comment-17831208 ] Matthias J. Sax commented on KAFKA-16382: - An application reset, does not touch the output

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022177651 @chia7712 Conflicts resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-16353) Offline protocol migration integration tests

2024-03-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16353. - Resolution: Fixed > Offline protocol migration integration tests >

Re: [PR] MINOR: Preventing running the :core tests twice when testing with coverage [kafka]

2024-03-27 Thread via GitHub
viktorsomogyi merged PR #15580: URL: https://github.com/apache/kafka/pull/15580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540885105 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-27 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831324#comment-17831324 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16414: -- As well, I'm +1 on

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
brandboat commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022630053 Thank you @showuon , @jeqo . I will address the comments in the new JIRA https://issues.apache.org/jira/browse/KAFKA-16429 -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541032203 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15575: URL: https://github.com/apache/kafka/pull/15575#issuecomment-2022624611 @OmniaGM Can you, please, merge with latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-27 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831327#comment-17831327 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16414: -- Just got the new messages

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540992038 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
jeqo commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022623732 Sorry for also being later with the review. Changes look good to me overall, though I'd also add a mention on these configs that: `log.roll` configs are ignored (as well as the mentioned

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022675724 @jeqo I should merge code after getting your reviews :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-03-27 Thread Abhijeet Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831617#comment-17831617 ] Abhijeet Kumar commented on KAFKA-15265: I plan to raise the PRs in the next couple of weeks. I

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831624#comment-17831624 ] Manikumar edited comment on KAFKA-16310 at 3/28/24 5:15 AM: [~chia7712]

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831624#comment-17831624 ] Manikumar commented on KAFKA-16310: --- [~chia7712] [~showuon] Can we revert the relavent changes from

Re: [PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia commented on PR #15609: URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022175562 Requesting review from @jolshan (reviewer of the parent PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228 ] Stanislav Spiridonov commented on KAFKA-16382: -- Wait, why is it not a bug? I have the real

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
soarez commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022452207 I think there is a JIRA already for this flaky test: [KAFKA-15915](https://issues.apache.org/jira/browse/KAFKA-15915) If this is correct, then you should update the PR title to refer to

[jira] [Commented] (KAFKA-16323) Failing test: fix testRemoteFetchExpiresPerSecMetric

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831291#comment-17831291 ] Chia-Ping Tsai commented on KAFKA-16323: It seems to me the root cause could be the `spy` does

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-27 Thread via GitHub
lucasbru commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1540879732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -25,22 +25,15 @@ import java.util.Map; /** - * Event for

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-03-27 Thread via GitHub
dajac commented on PR #15446: URL: https://github.com/apache/kafka/pull/15446#issuecomment-2022239076 @jeffkbkim There are failed tests that look related. Could you check them please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Comment Edited] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228 ] Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:57 AM:

[jira] [Commented] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831244#comment-17831244 ] Igor Soarez commented on KAFKA-16403: - The test only failed the one time. I agree it was likely a

[jira] [Resolved] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-16403. - Resolution: Not A Bug > Flaky test >

[jira] [Assigned] (KAFKA-16103) Review client logic for triggering offset commit callbacks

2024-03-27 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16103: -- Assignee: Lucas Brutschy (was: Lianet Magrans) > Review client logic for triggering

Re: [PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia commented on PR #15609: URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022517844 Thanks for the review @soarez I have updated the variable names in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-15558) Determine if Timer should be used elsewhere in PrototypeAsyncConsumer.updateFetchPositions()

2024-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831197#comment-17831197 ] Andrew Schofield commented on KAFKA-15558: -- I was referring to the way that there is

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
urbandan commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1540691777 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import

[jira] [Resolved] (KAFKA-16404) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testGetStreamsConfig

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-16404. - Resolution: Not A Bug Same as KAFKA-16403, this only failed once. It was likely the result of a

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Fix Version/s: 3.7.1 > Race condition while promoting future replica can lead to partition >

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Affects Version/s: 3.7.0 > Race condition while promoting future replica can lead to partition >

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Component/s: jbod > Race condition while promoting future replica can lead to partition >

[PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia opened a new pull request, #15609: URL: https://github.com/apache/kafka/pull/15609 This is a follow-up to [this](https://github.com/apache/kafka/pull/15486) PR which introduced the new `ABORTABLE_TRANSACTION` error as a part of KIP-890 efforts. However on further discussion, we

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1540643481 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Comment Edited] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228 ] Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:55 AM:

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831230#comment-17831230 ] Stanislav Spiridonov commented on KAFKA-16382: -- BTW if you take the wrong scenario from

[jira] [Updated] (KAFKA-16365) AssignmentsManager mismanages completion notifications

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16365: Priority: Critical (was: Major) > AssignmentsManager mismanages completion notifications >

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
viktorsomogyi commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022430965 @akatona84 I think this one exceeds the "minor" commit, I think you should create a jira ticket for this. Also, please add a description of your change that reveals the thinking

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-27 Thread via GitHub
lucasbru commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2022475971 > @lucasbru - Thanks again for reviewing the PR. Sorry about the misinterpretation on short circuting logic so here I updated the beginningOrEndOffsets API. It seems like the right

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-27 Thread via GitHub
lucasbru merged PR #15576: URL: https://github.com/apache/kafka/pull/15576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16404) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testGetStreamsConfig

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831202#comment-17831202 ] Matthias J. Sax commented on KAFKA-16404: - Sounds like an env issue to me. I would propose to

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1540685634 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831201#comment-17831201 ] Matthias J. Sax commented on KAFKA-16403: - Sound like an env issue but not a bug to me? I would

Re: [PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-27 Thread via GitHub
showuon merged PR #15561: URL: https://github.com/apache/kafka/pull/15561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-27 Thread via GitHub
dajac merged PR #15492: URL: https://github.com/apache/kafka/pull/15492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1540748533 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1540866456 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -320,4 +322,19 @@ static void createCompactedTopic(String topicName, short

Re: [PR] MINOR: enhance kafka-reassign-partitions command output [kafka]

2024-03-27 Thread via GitHub
KevinZTW commented on code in PR #15610: URL: https://github.com/apache/kafka/pull/15610#discussion_r1542216359 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -806,12 +806,10 @@ private static void executeMoves(Admin adminClient,

[jira] [Commented] (KAFKA-16435) Add test for KAFKA-16428

2024-03-27 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831605#comment-17831605 ] Kuan Po Tseng commented on KAFKA-16435: --- I'm willing to take over this ! Let me add some test~

[jira] [Assigned] (KAFKA-16435) Add test for KAFKA-16428

2024-03-27 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng reassigned KAFKA-16435: - Assignee: Kuan Po Tseng > Add test for KAFKA-16428 > > >

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-27 Thread via GitHub
Owen-CH-Leung commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2024287098 > printUsageAndExit Agree. Setting a dumb exit procedure solves the failed build. Let me revise that -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-27 Thread via GitHub
showuon commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1542235961 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4164,16 +4164,13 @@ class ReplicaManagerTest { mock(classOf[FetchDataInfo])

Re: [PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-27 Thread via GitHub
showuon merged PR #15549: URL: https://github.com/apache/kafka/pull/15549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15549: URL: https://github.com/apache/kafka/pull/15549#issuecomment-2024290120 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
Matej Sprysl created KAFKA-16432: Summary: KStreams: Joining KStreams and GlobalKTable requires a state store Key: KAFKA-16432 URL: https://issues.apache.org/jira/browse/KAFKA-16432 Project: Kafka

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
mjsax commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541286490 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -58,6 +61,8 @@ public class AbstractConfig { private final ConfigDef

[jira] [Updated] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Sprysl updated KAFKA-16432: - Description: h2.  Code: {code:java} final StreamsBuilder builder = new StreamsBuilder(); final

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541382798 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2023212508 Now that https://github.com/apache/kafka/pull/15075 got merged, this needs rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541472627 ## server/src/main/java/org/apache/kafka/security/CredentialProvider.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831463#comment-17831463 ] Chia-Ping Tsai commented on KAFKA-16310: @johnnyhsu thanks for offers the description. I add

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-27 Thread via GitHub
lianetm commented on PR #15612: URL: https://github.com/apache/kafka/pull/15612#issuecomment-2023088189 @lucasbru this is one more last split that I find would make sense. With this, all the tests left in the `PlainTextConsumer` do not seem to belong to any sensible group other than the

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
soarez commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541375369 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

[PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-03-27 Thread via GitHub
lucasbru opened a new pull request, #15613: URL: https://github.com/apache/kafka/pull/15613 The javadoc for `KafkaConsumer.commitSync` says: > Note that asynchronous offset commits sent previously with the {@link #commitAsync(OffsetCommitCallback)} > (or similar) are guaranteed to

  1   2   >