chia7712 commented on code in PR #15663:
URL: https://github.com/apache/kafka/pull/15663#discussion_r1552981401
##
build.gradle:
##
@@ -270,6 +270,7 @@ subprojects {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114426
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114805
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
vamossagar12 closed pull request #15653: Test PR without the circular
dependency code
URL: https://github.com/apache/kafka/pull/15653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vamossagar12 commented on PR #15653:
URL: https://github.com/apache/kafka/pull/15653#issuecomment-2039212910
The purpose of this PR was to validate a certain behaviour with circular
dependency (explained
[here](https://github.com/apache/kafka/pull/15642#discussion_r1551420344)) and
as
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553223975
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553225208
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
brandboat opened a new pull request, #15668:
URL: https://github.com/apache/kafka/pull/15668
related to KAFKA-16477,
After profiling the kafka tests, tons of `client-metrics-reaper` thread not
cleanup after BrokerServer shutdown.
The thread `client-metrics-reaper` comes from
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553235267
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1568,10 +1548,8 @@ public void
chia7712 commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1552954260
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition,
object Partition {
private
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition,
delayedOperations:
[
https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834261#comment-17834261
]
Johnny Hsu commented on KAFKA-16475:
hi [~cmccabe]
I am willing to work on this ticket, thanks!
>
chia7712 merged PR #15638:
URL: https://github.com/apache/kafka/pull/15638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039097741
> I think the class file size increasing is indeed a direct drawback after
adding -parameter option because we'll include all the parameters into .class
files. I'd like to know if
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553284545
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -514,8 +496,6 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reopened KAFKA-16305:
reopen for backport to 3.7
> Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS
Kuan Po Tseng created KAFKA-16477:
-
Summary: Detect thread leaked client-metrics-reaper in tests
Key: KAFKA-16477
URL: https://issues.apache.org/jira/browse/KAFKA-16477
Project: Kafka
Issue
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039025377
> However, this way still doesn't check whether "parameter name" is correct.
Probably, we can give another check is that if display name contains zk or
kraft, but not quorum, then
chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039262579
@nizhikov thanks for this patch. let's wait for #15664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553245804
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -365,11 +356,10 @@ public void
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2039443091
Heya @cadonna! I have rebased and hopefully addressed all of the first batch
of comments. The verifications which are missing are reported as
unnecessary/uncalled by Mockito, but if you
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553428780
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition,
object Partition {
private
chia7712 commented on PR #15668:
URL: https://github.com/apache/kafka/pull/15668#issuecomment-2039540752
@brandboat nice finding! Should we add the thread prefix to
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition,
delayedOperations:
[
https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-16475:
--
Assignee: Johnny Hsu
> Create unit test for TopicImageNode
>
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553060780
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov opened a new pull request, #15667:
URL: https://github.com/apache/kafka/pull/15667
This PR adds junit-platform.properties to core and removes outdated constant
from scala code.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553287165
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1798,8 +1746,6 @@ public void
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-2039360963
Hey Chris, sorry for the long delay on this. I finally got a chance to
verify the code that you provided and it makes sense. I agree that so far I was
only thinking about either
[
https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16305.
Fix Version/s: 3.7.1
Resolution: Fixed
push
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039019880
> 2. How could we avoid this things happen in the future? Like adding some
checking before the tests startup or something? Do you have any idea?
I don't have a good idea to
nizhikov opened a new pull request, #15666:
URL: https://github.com/apache/kafka/pull/15666
This PR adds `junit-platform.properties` to `tools` and removes outdated
constant from java code.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834200#comment-17834200
]
Gaurav Narula commented on KAFKA-16471:
---
[~chia7712] I'm not well versed with the backporting
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834229#comment-17834229
]
Chia-Ping Tsai commented on KAFKA-16471:
{quote}
perhaps we backport KAFKA-16305 to 3.7 and
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553289186
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1866,9 +1810,6 @@ public void
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553349919
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1652,81 +1598,64 @@ public void
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553347186
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -312,55 +302,40 @@ public void
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039041551
> > However, this way still doesn't check whether "parameter name" is
correct. Probably, we can give another check is that if display name contains
zk or kraft, but not quorum,
PoAn Yang created KAFKA-16476:
-
Summary: Check whether TestInfo contains correct parameter name
Key: KAFKA-16476
URL: https://issues.apache.org/jira/browse/KAFKA-16476
Project: Kafka
Issue Type:
FrankYang0529 commented on code in PR #15663:
URL: https://github.com/apache/kafka/pull/15663#discussion_r1553003195
##
build.gradle:
##
@@ -270,6 +270,7 @@ subprojects {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
showuon commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039081866
Sorry @FrankYang0529 , I saw this:
https://stackoverflow.com/questions/44067477/drawbacks-of-javac-parameters-flag
> Briefly, the stated reasons to make parameter names optional are
nizhikov commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039274380
@chia7712 Can you, please, double check PR number? It sees #15664 not
related to my changes
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039276618
sorry :(
the correct PR is #15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553357069
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
vamossagar12 commented on PR #15034:
URL: https://github.com/apache/kafka/pull/15034#issuecomment-2039191732
The instructions for signing up are
[here](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-GettingStarted).
--
This is an
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553224333
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
OmniaGM commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-2039474182
> @OmniaGM , there is compilation error in jdk8_scala2.12 job. Could you
have a look?
>
> ```
> [2024-04-04T09:19:51.266Z] [Error]
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553477271
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -248,9 +249,10 @@ object KafkaConfig {
val ConsumerGroupMaxSessionTimeoutMsProp =
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1553514811
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -761,6 +777,31 @@ public ClassicGroup classicGroup(
}
Philipp Trulson created KAFKA-16478:
---
Summary: Links for Kafka 3.5.2 release are broken
Key: KAFKA-16478
URL: https://issues.apache.org/jira/browse/KAFKA-16478
Project: Kafka
Issue Type:
viktorsomogyi merged PR #15605:
URL: https://github.com/apache/kafka/pull/15605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long
johnnychhsu commented on PR #15556:
URL: https://github.com/apache/kafka/pull/15556#issuecomment-2039670307
@vamossagar12 thanks for the comment.
sure! let's wait and monitor more builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
divijvaidya closed pull request #15099: MINOR: Increase parallelism for Jenkins
URL: https://github.com/apache/kafka/pull/15099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039753742
> > I think the class file size increasing is indeed a direct drawback after
adding -parameter option because we'll include all the parameters into .class
files. I'd like to know
viktorsomogyi commented on PR #15605:
URL: https://github.com/apache/kafka/pull/15605#issuecomment-2039754554
Aslo, thank you @akatona84 for the contribution, @soarez and @urbandan for
the reviews. Fixing flaky tests is always very welcomed, keep it up!
--
This is an automated message
qinghui-xu commented on PR #7139:
URL: https://github.com/apache/kafka/pull/7139#issuecomment-2039564348
For me this should be merged even just for the sake of the codebase sanity.
I can try to rebase it and resolve the conflict to update the PR.
--
This is an automated message from
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553481594
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ConsumerGroupMigrationPolicy.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553480909
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -677,6 +679,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsDoc = "The maximum heartbeat
dajac commented on code in PR #15587:
URL: https://github.com/apache/kafka/pull/15587#discussion_r1553499653
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2415,6 +2415,20 @@ private CoordinatorResult
omkreddy commented on PR #15665:
URL: https://github.com/apache/kafka/pull/15665#issuecomment-2039898497
Thanks for the Review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
omkreddy merged PR #15665:
URL: https://github.com/apache/kafka/pull/15665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm opened a new pull request, #15669:
URL: https://github.com/apache/kafka/pull/15669
Minor changes for improving the logging and docs related to the auto-commit
inflight logic, also adding tests to ensure the expected behaviour:
- auto-commit on the interval does not send a
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2039970916
Hey @lucasbru, could you take a look at this when you have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu resolved KAFKA-15583.
Resolution: Fixed
> High watermark can only advance if ISR size is larger than min ISR
>
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2040290159
@cadonna @lucasbru - Is it possible for me to ask for a review on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554177925
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
Calvin Liu created KAFKA-16479:
--
Summary: Add pagination supported describeTopic interface
Key: KAFKA-16479
URL: https://issues.apache.org/jira/browse/KAFKA-16479
Project: Kafka
Issue Type:
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554025678
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1554016667
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyAndJoinSide.java:
##
@@ -33,28 +34,36 @@
public class TimestampedKeyAndJoinSide {
OmniaGM opened a new pull request, #15670:
URL: https://github.com/apache/kafka/pull/15670
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
vamossagar12 closed pull request #10468: Kafka 12373:Improve KafkaRaftClient
handling of graceful shutdown
URL: https://github.com/apache/kafka/pull/10468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554165141
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
junrao commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553959430
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
CalvinConfluent commented on PR #15470:
URL: https://github.com/apache/kafka/pull/15470#issuecomment-2040217099
@mumrah Thanks for the review. Ticket filed.
https://issues.apache.org/jira/browse/KAFKA-15579
--
This is an automated message from the Apache Git Service.
To respond to the
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554011665
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
gharris1727 commented on code in PR #15642:
URL: https://github.com/apache/kafka/pull/15642#discussion_r1554188423
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##
@@ -69,6 +69,9 @@ public static void setup() {
lianetm commented on PR #15613:
URL: https://github.com/apache/kafka/pull/15613#issuecomment-2040495611
Thanks for the changes @lucasbru, looks good to me overall. This is tidying
up the whole async commit callbacks execution story. Left some comments, mostly
minor, and to make sure we're
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
jsancio opened a new pull request, #15671:
URL: https://github.com/apache/kafka/pull/15671
DRAFT
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554020736
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -229,7 +229,11 @@ private GroupRebalanceConfig
vamossagar12 closed pull request #10278: KAFKA-10526: leader fsync deferral on
write
URL: https://github.com/apache/kafka/pull/10278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vamossagar12 closed pull request #11592: KAFKA-13501: Avoid state restore via
rebalance if standbys are enabled
URL: https://github.com/apache/kafka/pull/11592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040402625
@ijuma Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
junrao commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040231361
@chia7712 : Thanks for the updated PR. Regarding the previous failed tests,
one possibility is that the data on the server passed the retention time and is
garbage collected. The default
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040270805
> Regarding the previous failed tests, one possibility is that the data on
the server passed the retention time and is garbage collected. The default
retention time is 7 days, which
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024796
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024079
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
vamossagar12 closed pull request #10842: KAFKA-12848: kafka streams jmh
benchmarks
URL: https://github.com/apache/kafka/pull/10842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on code in PR #15651:
URL: https://github.com/apache/kafka/pull/15651#discussion_r1554150631
##
release.py:
##
@@ -348,6 +348,9 @@ def command_release_announcement_email():
+An overview of the release and its notable changes can be found in the
+release
gaurav-narula commented on PR #15527:
URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040616724
@gharris1727 Thanks for pointing that out.
The warning below
```
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834456#comment-17834456
]
Matthias J. Sax commented on KAFKA-16478:
-
\cc [~mimaison] – seems you remove some older release
Phuc-Hong-Tran commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1554474003
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern
1 - 100 of 121 matches
Mail list logo
