gaurav-narula commented on PR #15776:
URL: https://github.com/apache/kafka/pull/15776#issuecomment-2068864485
CC: @soarez @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaurav-narula opened a new pull request, #15776:
URL: https://github.com/apache/kafka/pull/15776
Reviewers: Igor Soarez , Chia-Ping Tsai
Cherry-picks #15730 to 3.7 branch.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
[
https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-10551:
-
Assignee: Omnia Ibrahim
> Support topic IDs in Produce request
>
[
https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dujian reassigned KAFKA-16582:
--
Assignee: (was: dujian)
> Feature Request: Introduce max.record.size Configuration Parameter for
[
https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dujian reassigned KAFKA-16582:
--
Assignee: dujian
> Feature Request: Introduce max.record.size Configuration Parameter for
>
[
https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dujian reassigned KAFKA-16582:
--
Assignee: dujian
> Feature Request: Introduce max.record.size Configuration Parameter for
>
omkreddy merged PR #15771:
URL: https://github.com/apache/kafka/pull/15771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaurav-narula opened a new pull request, #15777:
URL: https://github.com/apache/kafka/pull/15777
Cherry picks #15136 to 3.7 branch. Depends on #15776 being cherry-picked
first.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1574417900
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software Foundation
gaurav-narula commented on PR #15777:
URL: https://github.com/apache/kafka/pull/15777#issuecomment-2068874029
CC: @soarez @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison commented on PR #15644:
URL: https://github.com/apache/kafka/pull/15644#issuecomment-2069139226
We're still having issues adding ppc64le (see
https://github.com/apache/kafka/pull/13817,
https://cwiki.apache.org/confluence/display/KAFKA/KIP-942%3A+Add+Power%28ppc64le%29+support).
chia7712 commented on PR #15769:
URL: https://github.com/apache/kafka/pull/15769#issuecomment-2069289874
@evalaiyc98 thanks for you contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16549.
Fix Version/s: 3.8.0
Resolution: Fixed
> suppress the warnings from
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574731972
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069514738
all failed tests pass on my local. merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 merged PR #15722:
URL: https://github.com/apache/kafka/pull/15722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839724#comment-17839724
]
PoAn Yang commented on KAFKA-16589:
---
Hi [~chia7712], is this ticket try to `createAdminClient` from
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839601#comment-17839601
]
Bruno Cadonna commented on KAFKA-16567:
---
I think as long as we do not enable the state updater by
[
https://issues.apache.org/jira/browse/KAFKA-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez updated KAFKA-6689:
Labels: (was: newbie)
> Kafka not release .deleted file.
>
Prashant-Jagtap commented on PR #15644:
URL: https://github.com/apache/kafka/pull/15644#issuecomment-2069055740
@mimaison Any update on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasbru commented on code in PR #15742:
URL: https://github.com/apache/kafka/pull/15742#discussion_r1574581701
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -228,13 +228,16 @@ private void process(final ErrorEvent event) {
lucasbru commented on code in PR #15742:
URL: https://github.com/apache/kafka/pull/15742#discussion_r1574580739
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1333,32 +1342,41 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839621#comment-17839621
]
Igor Soarez commented on KAFKA-8115:
Failed again:
{code:java}
java.util.concurrent.TimeoutException:
chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574671001
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1574810225
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,75 +53,98 @@
import static
[
https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dujian reassigned KAFKA-16582:
--
Assignee: (was: dujian)
> Feature Request: Introduce max.record.size Configuration Parameter for
[
https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839604#comment-17839604
]
Walter Hernandez commented on KAFKA-15736:
--
KRaft support seems supported:
[
https://issues.apache.org/jira/browse/KAFKA-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839620#comment-17839620
]
Igor Soarez commented on KAFKA-16504:
-
Another failed run, with the same failure
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass resolved KAFKA-16596.
-
Fix Version/s: 3.8.0
Assignee: Andras Katona
Resolution: Fixed
viktorsomogyi merged PR #15758:
URL: https://github.com/apache/kafka/pull/15758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm opened a new pull request, #15778:
URL: https://github.com/apache/kafka/pull/15778
This fixes a consumer system test that was failing for the new protocol. The
failure was because the test was expecting the eager behaviour of partitions
being revoked on every rebalance, and it was
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-16596:
Fix Version/s: 3.7.1
> Flaky test –
>
chia7712 commented on PR #15767:
URL: https://github.com/apache/kafka/pull/15767#issuecomment-2069300587
@charliecheng630 thanks for ur contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2069404596
> I think the better solution (or a workaround) for it, should be that we
set the `nextDeleteDelayMs = Math.max(1, fileDeleteDelayMs)` if if
logsToBeDeleted is empty. So, if
chia7712 commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069517654
@emitskevich-blp Thanks for fixing the incorrect docs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839733#comment-17839733
]
PoAn Yang commented on KAFKA-16589:
---
Got it. I'm interested in the issue. May I take it? Thank you.
>
[
https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16598:
--
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> Mirgrate `ResetConsumerGroupOffsetTest` to
[
https://issues.apache.org/jira/browse/KAFKA-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839609#comment-17839609
]
Walter Hernandez commented on KAFKA-2111:
-
*[mimaison|https://github.com/mimaison]* commented [on
Igor Soarez created KAFKA-16596:
---
Summary: Flaky test –
org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()
Key: KAFKA-16596
URL:
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839632#comment-17839632
]
Igor Soarez commented on KAFKA-16596:
-
Thanks both!
> Flaky test –
>
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1574626256
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,477 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on PR #15778:
URL: https://github.com/apache/kafka/pull/15778#issuecomment-2069255159
Hey @lucasbru , could you take a look when you have a chance? Similar issue
to the one on https://github.com/apache/kafka/pull/15661.
With this I get successful runs of the test
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1574660830
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long
chia7712 merged PR #15769:
URL: https://github.com/apache/kafka/pull/15769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15765:
URL: https://github.com/apache/kafka/pull/15765#issuecomment-2069414872
@m1a2st thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 merged PR #15765:
URL: https://github.com/apache/kafka/pull/15765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15745:
URL: https://github.com/apache/kafka/pull/15745#issuecomment-2069589870
@FrankYang0529 This PR will enhance our new test infra. However, @brandboat
is working at refactoring the infra at the same time. It seems to me this PR
should be blocked by #15761 in
[
https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839724#comment-17839724
]
PoAn Yang edited comment on KAFKA-16589 at 4/22/24 2:56 PM:
Hi [~chia7712],
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2069788585
> @FrankYang0529 thanks for updated PR. two minor comments left. PTAL
Hi @chia7712, I addressed last comments. Thanks for the review.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez resolved KAFKA-15736.
--
Resolution: Done
> KRaft support in PlaintextConsumerTest
>
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16567:
Assignee: (was: Walter Hernandez)
> Add New Stream Metrics based on KIP-869
lucasbru merged PR #15613:
URL: https://github.com/apache/kafka/pull/15613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Igor Soarez created KAFKA-16597:
---
Summary: Flaky test -
org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificStalePartitionStoresMultiStreamThreads()
Key: KAFKA-16597
URL:
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839624#comment-17839624
]
Viktor Somogyi-Vass commented on KAFKA-16596:
-
[~soarez] just merged the PR a couple of
chia7712 merged PR #15767:
URL: https://github.com/apache/kafka/pull/15767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1574708196
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long
[
https://issues.apache.org/jira/browse/KAFKA-15850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839657#comment-17839657
]
Apoorv Mittal commented on KAFKA-15850:
---
This has been completed as part of KIP-1019. Resolving
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574769505
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kirktrue commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1574860975
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def
chia7712 commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-2069776278
When testing 3.7 branch for #15776, I encountered following error:
```
java.util.concurrent.ExecutionException:
org.apache.kafka.common.errors.InvalidTopicException: Topic
[
https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-15715:
Assignee: Walter Hernandez
> KRaft support in UpdateFeaturesTest
>
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1574551794
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -37,6 +40,10 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest
viktorsomogyi commented on PR #15758:
URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069166189
Ok, a couple of tests failed but none of them is ClientUtilsTest, so I'm
merging this. Thank you @akatona84 for your contribution, @brandboat and
@chia7712 for the reviews.
--
viktorsomogyi commented on PR #15758:
URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069206424
Yea, just had the same thought, will do in a couple of minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839636#comment-17839636
]
Viktor Somogyi-Vass commented on KAFKA-16596:
-
Cherry-picked this onto 3.7 and 3.6 too.
>
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-16596:
Fix Version/s: 3.6.3
> Flaky test –
>
soarez commented on PR #15776:
URL: https://github.com/apache/kafka/pull/15776#issuecomment-2069583743
There is a large number of failed tests, but none of them are new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839717#comment-17839717
]
Viktor Somogyi-Vass commented on KAFKA-13459:
-
[~durban] have you planned to move ahead with
dongnuo123 commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1574897141
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -10331,6 +10333,461 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839731#comment-17839731
]
Chia-Ping Tsai commented on KAFKA-16589:
{quote}
is this ticket about removing
cadonna commented on code in PR #15742:
URL: https://github.com/apache/kafka/pull/15742#discussion_r1574508879
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1333,32 +1342,41 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16336:
Assignee: (was: Walter Hernandez)
> Remove Deprecated metric
[
https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-15156:
Assignee: Walter Hernandez
> Update cipherInformation correctly in
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574685410
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574732048
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574744528
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574750038
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839613#comment-17839613
]
Bruno Cadonna commented on KAFKA-16514:
---
I might have missed this, but why can we not just
[
https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839623#comment-17839623
]
Chia-Ping Tsai commented on KAFKA-16596:
this should be fixed by
soarez commented on code in PR #15701:
URL: https://github.com/apache/kafka/pull/15701#discussion_r1574584174
##
metadata/src/main/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfo.java:
##
@@ -191,6 +191,10 @@ public String failureMessage(
}
omkreddy commented on PR #15758:
URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069192637
Lets also cherry-pick to 3.7 and 3.6 branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574733563
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1574805564
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,494 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on PR #15698:
URL: https://github.com/apache/kafka/pull/15698#issuecomment-2069725394
Hi @cadonna, thanks for the comments!
- the unit test I added initially fails on
Chia-Ping Tsai created KAFKA-16598:
--
Summary: Mirgrate `ResetConsumerGroupOffsetTest` to new test infra
Key: KAFKA-16598
URL: https://issues.apache.org/jira/browse/KAFKA-16598
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839730#comment-17839730
]
黃竣陽 commented on KAFKA-16598:
-
I am able to handle this issue.
> Mirgrate `ResetConsumerGroupOffsetTest` to
[
https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16589:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> Consider removing
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2069841257
@chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574953974
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1574952989
##
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kamalcph commented on PR #15780:
URL: https://github.com/apache/kafka/pull/15780#issuecomment-2069948134
This PR is a follow-up of #15719.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575000110
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
Lucas Brutschy created KAFKA-16599:
--
Summary: Always await async commit callbacks in commitSync and
close
Key: KAFKA-16599
URL: https://issues.apache.org/jira/browse/KAFKA-16599
Project: Kafka
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575053494
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -173,63 +199,104 @@ public static class Builder {
private String listenerName;
private
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575079922
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839791#comment-17839791
]
Stanislav Spiridonov commented on KAFKA-16585:
--
If you check the example on
vamossagar12 commented on PR #15305:
URL: https://github.com/apache/kafka/pull/15305#issuecomment-2070326565
@showuon , I made some changes to the test so that we just heartbeat and not
have to rely upon FindCoordinator requests. Let me know what yo think. Thanks!
--
This is an automated
m1a2st opened a new pull request, #15779:
URL: https://github.com/apache/kafka/pull/15779
change the ResetConsumerGroupOffsetTest first to new test framework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839744#comment-17839744
]
Omnia Ibrahim commented on KAFKA-15089:
---
I can have a look once I finish KAFKA-15853
>
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1574974316
##
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##
@@ -18,41 +18,58 @@ package kafka.server
import java.net.Socket
import
1 - 100 of 175 matches
Mail list logo
