lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2069725394
Hi @cadonna, thanks for the comments! - the unit test I added initially fails on [this](https://github.com/apache/kafka/blob/d242c444562fe4be41a2bc53d47ab2a6f523b955/clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java#L276) assertion without the changes on this PR, I guess that's what you were looking for with your first comment? - agreed, we did not have test coverage to make sure that the `canSendRequest` and `nextHeartbeat` move along consistently. I added a func to validate them together, included it in the existing test that covers responses with errors, and added a new test to include it in the successful path too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
