Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1518786653
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -35,6 +38,8 @@
"about": "-1 if it didn't change since the last
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1987118580
hi @JimmyWang6, are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson B. updated KAFKA-16345:
--
Description:
When a client communicates with OIDC provider to retrieve an access token
RFC-6749 says
ChrisAHolland opened a new pull request, #15507:
URL: https://github.com/apache/kafka/pull/15507
I noticed that were were a few implementation quirks with the implementation
of `BoundedList.java` that could potentially lead to bugs if used improperly.
1. A constructor like method
chia7712 commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518695740
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518692934
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
florin-akermann commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1518681146
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(
ijuma commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518681734
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
florin-akermann commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1518681146
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(
ijuma commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518680219
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
}
florin-akermann commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-1986999670
> So I would have expected that some test need an update with either
advancing time pro-actively, or by expected certain result later in the test,
because windows are closes
florin-akermann commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1518671144
##
streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java:
##
@@ -71,11 +71,21 @@ void afterEach() {
@Test
florin-akermann commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1518667989
##
streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java:
##
@@ -71,11 +71,21 @@ void afterEach() {
@Test
florin-akermann commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1518667829
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java:
##
@@ -1901,6 +1903,66 @@ public void
chia7712 commented on code in PR #15502:
URL: https://github.com/apache/kafka/pull/15502#discussion_r1518650689
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -258,7 +258,11 @@ object RequestChannel extends Logging {
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518650602
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
ijuma commented on code in PR #15402:
URL: https://github.com/apache/kafka/pull/15402#discussion_r1518649604
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -336,33 +337,35 @@ public long timeToNextUpdate(long
chia7712 commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518649558
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
ijuma commented on code in PR #15402:
URL: https://github.com/apache/kafka/pull/15402#discussion_r1518649290
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -336,33 +337,35 @@ public long timeToNextUpdate(long
ijuma commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518649065
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
}
ijuma commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1518648733
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,19 +352,15 @@ class LogLoaderTest {
// Intercept all segment read calls
val
chia7712 merged PR #15504:
URL: https://github.com/apache/kafka/pull/15504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15289:
URL: https://github.com/apache/kafka/pull/15289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15488:
URL: https://github.com/apache/kafka/pull/15488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15488:
URL: https://github.com/apache/kafka/pull/15488#issuecomment-1986950699
the failed tests pass on my local.
```sh
./gradlew cleanTest core:test --tests QuorumControllerTest --tests
ReplicaManagerTest
```
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824971#comment-17824971
]
Linu Shibu edited comment on KAFKA-16356 at 3/9/24 5:30 PM:
Can I assign
[
https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824971#comment-17824971
]
Linu Shibu commented on KAFKA-16356:
Can I assign this to myself and work on it?
> Remove
[
https://issues.apache.org/jira/browse/KAFKA-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino resolved KAFKA-14683.
--
Reviewer: Greg Harris
Resolution: Fixed
> Replace EasyMock and PowerMock with
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino reopened KAFKA-16223:
--
> Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest
>
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino resolved KAFKA-16223.
--
Fix Version/s: 3.8.0
Reviewer: Greg Harris
Resolution: Fixed
>
hgeraldino opened a new pull request, #15506:
URL: https://github.com/apache/kafka/pull/15506
Follow up of https://github.com/apache/kafka/pull/15316
* Rename `WorkerSinkTaskMockitoTest` back to `WorkerSinkTaskTest`
* Tidy up the code a bit
### Committer Checklist (excluded
FrankYang0529 opened a new pull request, #15505:
URL: https://github.com/apache/kafka/pull/15505
There were different words for `metadata.version` like `metadata version` or
`metadataVersion`.
Unify format as `metadata.version`.
### Committer Checklist (excluded from commit
FrankYang0529 opened a new pull request, #15504:
URL: https://github.com/apache/kafka/pull/15504
It looks like there is no `inter.broker.protocol` config.
Change the name to `inter.broker.protocol.version`.
### Committer Checklist (excluded from commit message)
- [ ] Verify
soarez commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1518545295
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -355,10 +355,11 @@ class LogManager(logDirs: Seq[File],
} else if
kamalcph commented on PR #15413:
URL: https://github.com/apache/kafka/pull/15413#issuecomment-1986805186
> Yeah, totally; I think the important thing is correcting the
documentation, as people may be confused while reading it. Still, I don't know
where the documentation is. Is it a
35 matches
Mail list logo
