showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520862105
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -69,6 +97,15 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520861572
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -60,6 +63,31 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520858564
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +53,24 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520857036
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##
@@ -263,13 +262,8 @@ public RecordsInfo info() {
} else if (maxTimestamp
showuon commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1990459827
Please also address this comment in this PR:
https://github.com/apache/kafka/pull/15474#discussion_r1520262997 . Thanks.
--
This is an automated message from the Apache Git Service.
To
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1990325002
@chia7712 @cadonna Hi, saw you approved some recent PR's, wondering if you
could take a look at mine or suggest someone better suited that I can ask?
Thanks!
--
This is an
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520774849
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -931,17 +920,14 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825496#comment-17825496
]
Matthias J. Sax commented on KAFKA-16359:
-
Just to clarify: we cannot re-publish a 3.7.0
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -338,7 +338,6 @@ public void
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -338,7 +338,6 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16357.
-
Resolution: Duplicate
> Kafka Client JAR manifest breaks javac linting
>
[
https://issues.apache.org/jira/browse/KAFKA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16357:
Priority: Critical (was: Major)
> Kafka Client JAR manifest breaks javac linting
>
chia7712 commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520683129
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
[
https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16360.
-
Resolution: Invalid
Please don't use Jira to ask questions. Jira tickets are for bug
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520671475
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamWindowCloseTest.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520627804
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamStreamJoinUtil.java:
##
@@ -25,36 +25,46 @@
public final class StreamStreamJoinUtil {
-
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520626385
##
streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java:
##
@@ -71,11 +71,21 @@ void afterEach() {
@Test
void
mjsax commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1989699015
What Bruno says. Git history if you friend :)
https://github.com/apache/kafka/pull/6602/files#r278810522
I think we should keep the code as-is and close this PR w/o merging (or
mjsax commented on code in PR #15510:
URL: https://github.com/apache/kafka/pull/15510#discussion_r1520612406
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -223,9 +223,9 @@ private void emitNonJoinedOuterRecords(
Matthias J. Sax created KAFKA-16366:
---
Summary: Refactor KTable source optimization
Key: KAFKA-16366
URL: https://issues.apache.org/jira/browse/KAFKA-16366
Project: Kafka
Issue Type:
mjsax commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520582633
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520575467
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
chia7712 commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520572340
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
jolshan commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520542402
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
Igor Soarez created KAFKA-16365:
---
Summary: AssignmentsManager mismanages completion notifications
Key: KAFKA-16365
URL: https://issues.apache.org/jira/browse/KAFKA-16365
Project: Kafka
Issue
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520520996
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
junrao commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520506664
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +53,24 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
hgeraldino commented on PR #15506:
URL: https://github.com/apache/kafka/pull/15506#issuecomment-1989568163
Thanks @chia7712 for your review
@gharris1727 does this looks good to you? It's the final PR to consider the
`WorkerSinkTaskTest` migration done done
--
This is an automated
hgeraldino opened a new pull request, #15520:
URL: https://github.com/apache/kafka/pull/15520
This is the last remaining Kafka Connect test that needs migration from
PowerMock/EasyMock to Mockito.
Following the same approach as the `WorkerSinkTaskTest` migration, which was
migrated
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
[
https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825467#comment-17825467
]
Greg Harris commented on KAFKA-16291:
-
[~claudio.benfatto] That's a good idea, I agree that the
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520498085
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
Greg Harris created KAFKA-16364:
---
Summary: MM2 High-Resolution Offset Translation
Key: KAFKA-16364
URL: https://issues.apache.org/jira/browse/KAFKA-16364
Project: Kafka
Issue Type: New Feature
mjsax commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1520482326
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData
mjsax commented on PR #15519:
URL: https://github.com/apache/kafka/pull/15519#issuecomment-1989525897
Follow up from https://github.com/apache/kafka/pull/15419/files#r1513841644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax opened a new pull request, #15519:
URL: https://github.com/apache/kafka/pull/15519
For static member, the `group.instance.id` cannot change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
artemlivshits commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520443872
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
[
https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825454#comment-17825454
]
Greg Harris edited comment on KAFKA-15841 at 3/11/24 9:46 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825454#comment-17825454
]
Greg Harris commented on KAFKA-15841:
-
[~henriquemota] Okay I think i understand better what you're
bachmanity1 commented on PR #15475:
URL: https://github.com/apache/kafka/pull/15475#issuecomment-1989425275
@kirktrue @mimaison kind reminder. Could you please have a look at the KIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520418403
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -33,49 +33,6 @@
* The CurrentAssignmentBuilder
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520414314
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -170,72 +127,122 @@ public CurrentAssignmentBuilder
[
https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825439#comment-17825439
]
Greg Harris commented on KAFKA-16356:
-
[~linu] I have given you permissions to assign tickets. You
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -33,49 +33,6 @@
* The CurrentAssignmentBuilder
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520381484
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java:
##
@@ -528,27 +478,6 @@ public Map>
cherylws commented on PR #15518:
URL: https://github.com/apache/kafka/pull/15518#issuecomment-1989345872
@mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wcarlson5 commented on code in PR #15421:
URL: https://github.com/apache/kafka/pull/15421#discussion_r1520361134
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -170,9 +170,6 @@ public void init(final ProcessorContext context,
cherylws opened a new pull request, #15518:
URL: https://github.com/apache/kafka/pull/15518
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
mjsax opened a new pull request, #15517:
URL: https://github.com/apache/kafka/pull/15517
- add missing section to TOC
- add default value for client.id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520300581
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520299410
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
mimaison opened a new pull request, #15516:
URL: https://github.com/apache/kafka/pull/15516
Based on https://github.com/apache/kafka/pull/5927
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
JobseRyan closed pull request #15515: dummy PR to check acls
URL: https://github.com/apache/kafka/pull/15515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
JobseRyan opened a new pull request, #15515:
URL: https://github.com/apache/kafka/pull/15515
dummy PR
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
JobseRyan closed pull request #15514: User/rjobse/add xinfra identifier check
URL: https://github.com/apache/kafka/pull/15514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JobseRyan opened a new pull request, #15514:
URL: https://github.com/apache/kafka/pull/15514
Pull request to add a check for the client type and library version to check
if the client which is accessing this broker is a xinfra client
### Committer Checklist (excluded from commit
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520206161
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1520201655
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520191884
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -37,4 +42,28 @@ public static OptionalInt ofSentinel(int value) {
public
[
https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825402#comment-17825402
]
Igor Soarez commented on KAFKA-16363:
-
cc [~pprovenzano]
> Storage crashes if dir is unavailable
>
[
https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-16363:
---
Assignee: Igor Soarez
> Storage crashes if dir is unavailable
>
Igor Soarez created KAFKA-16363:
---
Summary: Storage crashes if dir is unavailable
Key: KAFKA-16363
URL: https://issues.apache.org/jira/browse/KAFKA-16363
Project: Kafka
Issue Type: Sub-task
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520171958
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1796,12 +1834,12 @@ public void onLoaded() {
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1400,35 +1440,35 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825397#comment-17825397
]
Greg Harris commented on KAFKA-16362:
-
cc [~mjsax] [~ableegoldman] I looked through the (currently
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1400,35 +1440,35 @@ private void
gharris1727 opened a new pull request, #15513:
URL: https://github.com/apache/kafka/pull/15513
This test uses the same value types on the left and right, and so wouldn't
be sensitive to a mixup between left and right values. So I changed one of the
stream types to `Long`, and updated the
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1400,35 +1440,35 @@ private void
mjsax commented on PR #15500:
URL: https://github.com/apache/kafka/pull/15500#issuecomment-1989056918
Merged to `trunk` and cherry-picked to `3.7` and `3.6` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1400,35 +1440,35 @@ private void
Greg Harris created KAFKA-16362:
---
Summary: Fix type-unsafety in KStreamKStreamJoin caused by
isLeftSide
Key: KAFKA-16362
URL: https://issues.apache.org/jira/browse/KAFKA-16362
Project: Kafka
soarez commented on PR #15451:
URL: https://github.com/apache/kafka/pull/15451#issuecomment-1989015331
@showuon could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520125834
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1211,13 +1192,99 @@ private
CoordinatorResult consumerGr
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1520116151
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1837,8 +1872,13 @@ void generateLeaderAndIsrUpdates(String
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115442
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2240,6 +2283,25 @@ private void updatePartitionDirectories(
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115750
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -336,10 +350,10 @@ public ControllerResult
registerBroker(
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520113443
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1211,13 +1192,99 @@ private
CoordinatorResult consumerGr
jolshan commented on PR #15364:
URL: https://github.com/apache/kafka/pull/15364#issuecomment-1988980430
> This is a non-backward compatible change. I think that we should do this
change to cleanup the record. As KIP-848 is only in early access in 3.7 and
that we clearly state that we
[
https://issues.apache.org/jira/browse/KAFKA-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16255:
--
Priority: Minor (was: Major)
> AsyncKafkaConsumer should not use partition.assignment.strategy
>
[
https://issues.apache.org/jira/browse/KAFKA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15553:
--
Priority: Minor (was: Major)
> Review consumer positions update
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16256:
--
Priority: Minor (was: Major)
> Update ConsumerConfig to validate use of group.remote.assignor and
>
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16298:
-
Assignee: Kirk True
> Ensure user callbacks exceptions are propagated to the user on consumer
Luke D created KAFKA-16361:
--
Summary: Rack aware sticky assignor minQuota violations
Key: KAFKA-16361
URL: https://issues.apache.org/jira/browse/KAFKA-16361
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825386#comment-17825386
]
Justine Olshan commented on KAFKA-16360:
Hey there – there was some discussion on the mailing
[
https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825385#comment-17825385
]
Greg Harris commented on KAFKA-16360:
-
Hi [~kaushik srinivas], thanks for your question!
The
kaushik srinivas created KAFKA-16360:
Summary: Release plan of 3.x kafka releases.
Key: KAFKA-16360
URL: https://issues.apache.org/jira/browse/KAFKA-16360
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825373#comment-17825373
]
Gaurav Narula commented on KAFKA-16359:
---
[~apoorvmittal10] I stumbled upon
cadonna commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1519991935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -278,32 +278,48 @@ private CompletedFetch handleInitializeSuccess(final
cadonna commented on PR #15491:
URL: https://github.com/apache/kafka/pull/15491#issuecomment-1988816400
> LGTM! I think it's a good solution in the current architecture, though
arguably a bit smelly.
Agree on the arguable smell. The alternative would be to use locks which I
disliked
[
https://issues.apache.org/jira/browse/KAFKA-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825365#comment-17825365
]
PoAn Yang commented on KAFKA-16354:
---
Hi [~gharris1727], I am interested in this. May I assign to
brandboat opened a new pull request, #15512:
URL: https://github.com/apache/kafka/pull/15512
as title, replace
- `assertTrue(obj instanceof X)` with `assertInstanceOf(X.class, obj)`
- `assertTrue(obj instanceof X, errormessge)` with
`assertInstanceOf(X.class, obj, errormessage)`
lucasbru commented on PR #15511:
URL: https://github.com/apache/kafka/pull/15511#issuecomment-1988762078
@lianetm @dajac Could you please have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825363#comment-17825363
]
Divij Vaidya commented on KAFKA-16114:
--
Sorry [~albedooo] , I won't have bandwidth any time
lucasbru opened a new pull request, #15511:
URL: https://github.com/apache/kafka/pull/15511
The goal of this PR is to change the following internals of the
reconciliation:
- Introduce a "local epoch" to the local target assignment. When a new
target is received by the server, we
lucasbru commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1519911603
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -278,32 +278,48 @@ private CompletedFetch
mumrah commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1519830343
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2240,6 +2283,25 @@ private void updatePartitionDirectories(
}
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal reassigned KAFKA-16359:
-
Assignee: Apoorv Mittal
> kafka-clients-3.7.0.jar published to Maven Central is
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825333#comment-17825333
]
Apoorv Mittal commented on KAFKA-16359:
---
Hi [~norrisjeremy] , thanks for reporting the issue. As
1 - 100 of 128 matches
Mail list logo
