Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-05 Thread via GitHub
brandboat commented on PR #15668: URL: https://github.com/apache/kafka/pull/15668#issuecomment-2040977883 > @brandboat nice finding! Should we add the thread prefix to

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554519247 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -654,6 +654,13 @@ static Map> getReplicaAssignmentForPartitions(Admi

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1554518847 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId [kafka]

2024-04-05 Thread via GitHub
github-actions[bot] commented on PR #15078: URL: https://github.com/apache/kafka/pull/15078#issuecomment-2040935039 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2040912811 @nizhikov Could you please rebase code to see the display name of tools test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-16472) Integration tests in Java don't really run kraft case

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16472. Resolution: Fixed > Integration tests in Java don't really run kraft case >

[jira] [Updated] (KAFKA-16472) Integration tests in Java don't really run kraft case

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16472: --- Fix Version/s: 3.8.0 3.7.1 > Integration tests in Java don't really run

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 merged PR #15663: URL: https://github.com/apache/kafka/pull/15663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040889410 I'm going to merge this PR in order to make other tool tests can run with KRaft. We can address all late reviews in other PRs. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-05 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1554474003 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-05 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1554466415 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

[jira] [Updated] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

2024-04-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16474: -- Labels: kip-848-client-support (was: ) > AsyncKafkaConsumer might send out heartbeat request without

[jira] [Updated] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

2024-04-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16474: -- Component/s: clients > AsyncKafkaConsumer might send out heartbeat request without waiting for its >

[jira] [Updated] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

2024-04-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16474: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer might send out heartbeat request without waiting for its >

[jira] [Commented] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834456#comment-17834456 ] Matthias J. Sax commented on KAFKA-16478: - \cc [~mimaison] – seems you remove some older release

[jira] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478 ] Matthias J. Sax deleted comment on KAFKA-16478: - was (Author: mjsax): \cc [~omkreddy] [~stanislavkozlovski] as last RMs – did any of you move artifacts and forgot to update the links?

[jira] [Commented] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834452#comment-17834452 ] Matthias J. Sax commented on KAFKA-16478: - \cc [~omkreddy] [~stanislavkozlovski] as last RMs –

[jira] [Commented] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834451#comment-17834451 ] Matthias J. Sax commented on KAFKA-16478: - [~der_eismann] – Thanks for reporting this. Do you

Re: [PR] MINOR: fix javadoc warnings [kafka]

2024-04-05 Thread via GitHub
gharris1727 commented on PR #15527: URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040626161 > I don't think that's a good idea. Usually IDEs help in figuring out the usages of fields/classes anyway. Should we remove that tag? I agree, let's remove that.

Re: [PR] MINOR: fix javadoc warnings [kafka]

2024-04-05 Thread via GitHub
gaurav-narula commented on PR #15527: URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040616724 @gharris1727 Thanks for pointing that out. The warning below ```

Re: [PR] KAFKA-15853: Move transactions configs out of core [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15670: URL: https://github.com/apache/kafka/pull/15670#discussion_r1554282432 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -1136,18 +1137,18 @@ class DynamicListenerConfig(server: KafkaBroker) extends

Re: [PR] MINOR: fix javadoc warnings [kafka]

2024-04-05 Thread via GitHub
gharris1727 commented on PR #15527: URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040586001 Hi @gaurav-narula I see some other javadoc warnings, do you think we should address these? ``` > Task :storage:storage-api:javadoc

[PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-05 Thread via GitHub
jsancio opened a new pull request, #15671: URL: https://github.com/apache/kafka/pull/15671 DRAFT ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on PR #15613: URL: https://github.com/apache/kafka/pull/15613#issuecomment-2040495611 Thanks for the changes @lucasbru, looks good to me overall. This is tidying up the whole async commit callbacks execution story. Left some comments, mostly minor, and to make sure we're

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-05 Thread via GitHub
gharris1727 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1554188423 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -69,6 +69,9 @@ public static void setup() {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554177925 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554165141 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15651: URL: https://github.com/apache/kafka/pull/15651#discussion_r1554150631 ## release.py: ## @@ -348,6 +348,9 @@ def command_release_announcement_email(): +An overview of the release and its notable changes can be found in the +release

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040402625 @ijuma Could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-13501: Avoid state restore via rebalance if standbys are enabled [kafka]

2024-04-05 Thread via GitHub
vamossagar12 closed pull request #11592: KAFKA-13501: Avoid state restore via rebalance if standbys are enabled URL: https://github.com/apache/kafka/pull/11592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-10526: leader fsync deferral on write [kafka]

2024-04-05 Thread via GitHub
vamossagar12 closed pull request #10278: KAFKA-10526: leader fsync deferral on write URL: https://github.com/apache/kafka/pull/10278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Kafka 12373:Improve KafkaRaftClient handling of graceful shutdown [kafka]

2024-04-05 Thread via GitHub
vamossagar12 closed pull request #10468: Kafka 12373:Improve KafkaRaftClient handling of graceful shutdown URL: https://github.com/apache/kafka/pull/10468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] KAFKA-15853: Move transactions configs out of core [kafka]

2024-04-05 Thread via GitHub
OmniaGM opened a new pull request, #15670: URL: https://github.com/apache/kafka/pull/15670 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-12848: kafka streams jmh benchmarks [kafka]

2024-04-05 Thread via GitHub
vamossagar12 closed pull request #10842: KAFKA-12848: kafka streams jmh benchmarks URL: https://github.com/apache/kafka/pull/10842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-04-05 Thread via GitHub
gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1554016667 ## streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyAndJoinSide.java: ## @@ -33,28 +34,36 @@ public class TimestampedKeyAndJoinSide {

Re: [PR] KAFKA-16389: ConsumerEventHandler does not support incremental assignment changes causing failure in system test [kafka]

2024-04-05 Thread via GitHub
philipnee commented on PR #15661: URL: https://github.com/apache/kafka/pull/15661#issuecomment-2040290159 @cadonna @lucasbru - Is it possible for me to ask for a review on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554025678 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024796 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024079 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554020736 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -229,7 +229,11 @@ private GroupRebalanceConfig

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1554011665 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040270805 > Regarding the previous failed tests, one possibility is that the data on the server passed the retention time and is garbage collected. The default retention time is 7 days, which

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -984,6 +984,8 @@ public void close(final Timer timer) {

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-05 Thread via GitHub
junrao commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040231361 @chia7712 : Thanks for the updated PR. Regarding the previous failed tests, one possibility is that the data on the server passed the retention time and is garbage collected. The default

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-04-05 Thread via GitHub
CalvinConfluent commented on PR #15470: URL: https://github.com/apache/kafka/pull/15470#issuecomment-2040217099 @mumrah Thanks for the review. Ticket filed. https://issues.apache.org/jira/browse/KAFKA-15579 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-16479) Add pagination supported describeTopic interface

2024-04-05 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-16479: -- Summary: Add pagination supported describeTopic interface Key: KAFKA-16479 URL: https://issues.apache.org/jira/browse/KAFKA-16479 Project: Kafka Issue Type:

[jira] [Resolved] (KAFKA-15583) High watermark can only advance if ISR size is larger than min ISR

2024-04-05 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15583. Resolution: Fixed > High watermark can only advance if ISR size is larger than min ISR >

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-04-05 Thread via GitHub
junrao commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1553959430 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-04-05 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-05 Thread via GitHub
lianetm commented on PR #15669: URL: https://github.com/apache/kafka/pull/15669#issuecomment-2039970916 Hey @lucasbru, could you take a look at this when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-05 Thread via GitHub
lianetm opened a new pull request, #15669: URL: https://github.com/apache/kafka/pull/15669 Minor changes for improving the logging and docs related to the auto-commit inflight logic, also adding tests to ensure the expected behaviour: - auto-commit on the interval does not send a

Re: [PR] MINOR: Increase parallelism for Jenkins [kafka]

2024-04-05 Thread via GitHub
divijvaidya closed pull request #15099: MINOR: Increase parallelism for Jenkins URL: https://github.com/apache/kafka/pull/15099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: Add 3.6.2 to system tests [kafka]

2024-04-05 Thread via GitHub
omkreddy merged PR #15665: URL: https://github.com/apache/kafka/pull/15665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add 3.6.2 to system tests [kafka]

2024-04-05 Thread via GitHub
omkreddy commented on PR #15665: URL: https://github.com/apache/kafka/pull/15665#issuecomment-2039898497 Thanks for the Review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-04-05 Thread via GitHub
viktorsomogyi commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2039754554 Aslo, thank you @akatona84 for the contribution, @soarez and @urbandan for the reviews. Fixing flaky tests is always very welcomed, keep it up!  -- This is an automated message

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
FrankYang0529 commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039753742 > > I think the class file size increasing is indeed a direct drawback after adding -parameter option because we'll include all the parameters into .class files. I'd like to know

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-04-05 Thread via GitHub
viktorsomogyi merged PR #15605: URL: https://github.com/apache/kafka/pull/15605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-05 Thread Philipp Trulson (Jira)
Philipp Trulson created KAFKA-16478: --- Summary: Links for Kafka 3.5.2 release are broken Key: KAFKA-16478 URL: https://issues.apache.org/jira/browse/KAFKA-16478 Project: Kafka Issue Type:

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

2024-04-05 Thread via GitHub
dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1553514811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -761,6 +777,31 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16383: fix flaky IdentityReplicationIntegrationTest .testReplicateFromLatest [kafka]

2024-04-05 Thread via GitHub
johnnychhsu commented on PR #15556: URL: https://github.com/apache/kafka/pull/15556#issuecomment-2039670307 @vamossagar12 thanks for the comment. sure! let's wait and monitor more builds -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-05 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1553499653 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,20 @@ private CoordinatorResult

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-05 Thread via GitHub
dajac commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1553481594 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ConsumerGroupMigrationPolicy.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-05 Thread via GitHub
dajac commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1553480909 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -677,6 +679,7 @@ object KafkaConfig { val ConsumerGroupMaxHeartbeatIntervalMsDoc = "The maximum heartbeat

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-05 Thread via GitHub
dajac commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1553477271 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -248,9 +249,10 @@ object KafkaConfig { val ConsumerGroupMaxSessionTimeoutMsProp =

Re: [PR] KAFKA-8735: Check properties file existence first [kafka]

2024-04-05 Thread via GitHub
qinghui-xu commented on PR #7139: URL: https://github.com/apache/kafka/pull/7139#issuecomment-2039564348 For me this should be merged even just for the sake of the codebase sanity. I can try to rebase it and resolve the conflict to update the PR. -- This is an automated message from

Re: [PR] MINOR: remove redundant check in appendLegacyRecord [kafka]

2024-04-05 Thread via GitHub
chia7712 merged PR #15638: URL: https://github.com/apache/kafka/pull/15638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16475) Create unit test for TopicImageNode

2024-04-05 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834261#comment-17834261 ] Johnny Hsu commented on KAFKA-16475: hi [~cmccabe]  I am willing to work on this ticket, thanks!  >

[jira] [Assigned] (KAFKA-16475) Create unit test for TopicImageNode

2024-04-05 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnny Hsu reassigned KAFKA-16475: -- Assignee: Johnny Hsu > Create unit test for TopicImageNode >

Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15668: URL: https://github.com/apache/kafka/pull/15668#issuecomment-2039540752 @brandboat nice finding! Should we add the thread prefix to

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
OmniaGM commented on code in PR #15335: URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition, delayedOperations:

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
OmniaGM commented on code in PR #15335: URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition, delayedOperations:

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
OmniaGM commented on code in PR #15335: URL: https://github.com/apache/kafka/pull/15335#discussion_r1553428780 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition, object Partition { private

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15335: URL: https://github.com/apache/kafka/pull/15335#discussion_r1552954260 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition, object Partition { private

[PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-05 Thread via GitHub
brandboat opened a new pull request, #15668: URL: https://github.com/apache/kafka/pull/15668 related to KAFKA-16477, After profiling the kafka tests, tons of `client-metrics-reaper` thread not cleanup after BrokerServer shutdown. The thread `client-metrics-reaper` comes from

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
OmniaGM commented on PR #15335: URL: https://github.com/apache/kafka/pull/15335#issuecomment-2039474182 > @OmniaGM , there is compilation error in jdk8_scala2.12 job. Could you have a look? > > ``` > [2024-04-04T09:19:51.266Z] [Error]

[jira] [Created] (KAFKA-16477) Detect thread leaked client-metrics-reaper in tests

2024-04-05 Thread Kuan Po Tseng (Jira)
Kuan Po Tseng created KAFKA-16477: - Summary: Detect thread leaked client-metrics-reaper in tests Key: KAFKA-16477 URL: https://issues.apache.org/jira/browse/KAFKA-16477 Project: Kafka Issue

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1553357069 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on PR #14716: URL: https://github.com/apache/kafka/pull/14716#issuecomment-2039443091 Heya @cadonna! I have rebased and hopefully addressed all of the first batch of comments. The verifications which are missing are reported as unnecessary/uncalled by Mockito, but if you

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553349919 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1652,81 +1598,64 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553347186 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -312,55 +302,40 @@ public void

[jira] [Resolved] (KAFKA-16305) Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS handshake

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16305. Fix Version/s: 3.7.1 Resolution: Fixed push

[jira] [Reopened] (KAFKA-16305) Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS handshake

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-16305: reopen for backport to 3.7 > Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS

[jira] [Commented] (KAFKA-16471) SslTransportLayer may leak SSLEngine resources

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834229#comment-17834229 ] Chia-Ping Tsai commented on KAFKA-16471: {quote} perhaps we backport KAFKA-16305 to 3.7 and

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553289186 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1866,9 +1810,6 @@ public void

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-04-05 Thread via GitHub
vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-2039360963 Hey Chris, sorry for the long delay on this. I finally got a chance to verify the code that you provided and it makes sense. I agree that so far I was only thinking about either

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553287165 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1798,8 +1746,6 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553284545 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -514,8 +496,6 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553245804 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -365,11 +356,10 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553235267 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1568,10 +1548,8 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553224333 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -309,49 +300,49 @@ public void

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553225208 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -309,49 +300,49 @@ public void

  1   2   >