Re: Turbogears2 migration: custom error pages

2016-07-18 Thread Alessandro Molina
On Wed, Jun 29, 2016 at 9:31 PM, Thomas De Schampheleire < patrickdeping...@gmail.com> wrote: > > I have pushed a rebased version to your kallithea-tg repo. I first > marked the existing changes as obsolete, but it seems this information > did not transfer to Bitbucket, don't know why (is your

Re: Turbogears2 migration: custom error pages

2016-06-22 Thread Alessandro Molina
On Mon, Jun 13, 2016 at 8:41 PM, Thomas De Schampheleire < patrickdeping...@gmail.com> wrote: > Question is now: do you agree with this current split and shall I push > it to kallithea-tg, or do you prefer I make some changes first? > Sorry for taking so long to reply, pretty much overwhelmed

Re: Turbogears2 migration: custom error pages

2016-06-13 Thread Thomas De Schampheleire
On Tue, Jun 7, 2016 at 9:20 AM, Thomas De Schampheleire wrote: > On Tue, Jun 7, 2016 at 12:43 AM, Alessandro Molina > wrote: >> >> >> On Tue, May 31, 2016 at 9:02 AM, Thomas De Schampheleire >> wrote: >>> >>>

Re: Turbogears2 migration: custom error pages

2016-06-07 Thread Thomas De Schampheleire
On Tue, Jun 7, 2016 at 12:43 AM, Alessandro Molina wrote: > > > On Tue, May 31, 2016 at 9:02 AM, Thomas De Schampheleire > wrote: >> >> >> If the dotted notation is more common or a better strategy, we could >> also just switch to it? > >

Re: Turbogears2 migration: custom error pages

2016-06-06 Thread Alessandro Molina
On Tue, May 31, 2016 at 9:02 AM, Thomas De Schampheleire < patrickdeping...@gmail.com> wrote: > > If the dotted notation is more common or a better strategy, we could > also just switch to it? > It has some advantages as all template paths are expressed in relation to python packages, so makes

Re: Turbogears2 migration: custom error pages

2016-05-31 Thread Thomas De Schampheleire
On Mon, May 30, 2016 at 11:10 PM, Alessandro Molina wrote: > > > On Sun, May 29, 2016 at 9:19 PM, Thomas De Schampheleire > wrote: >> >> >> > Currently, paster is still used. I briefly tried using gearbox (the >> > supposed replacement)

Re: Turbogears2 migration: custom error pages

2016-05-30 Thread Alessandro Molina
On Sun, May 29, 2016 at 9:19 PM, Thomas De Schampheleire < patrickdeping...@gmail.com> wrote: > > > Currently, paster is still used. I briefly tried using gearbox (the > > supposed replacement) but it did not work. I did not spend more time > > on that to focus on the rest, but it should be

Re: Turbogears2 migration: custom error pages

2016-05-29 Thread Thomas De Schampheleire
On Tue, May 24, 2016 at 7:13 PM, Mads Kiilerich wrote: > On 05/23/2016 08:34 PM, Thomas De Schampheleire wrote: >> >> This rebase could also incur some squashing of patches, to make it more >> ready for upstreaming. What do you think of that? > > > I haven't checked the repo

Re: Turbogears2 migration: custom error pages

2016-05-24 Thread Mads Kiilerich
On 05/23/2016 08:34 PM, Thomas De Schampheleire wrote: This rebase could also incur some squashing of patches, to make it more ready for upstreaming. What do you think of that? I haven't checked the repo recently, but it seems like there has been quite a bit of experimenting and going back

Re: Turbogears2 migration: custom error pages

2016-05-24 Thread Thomas De Schampheleire
On Tue, May 24, 2016 at 8:38 AM, Alessandro Molina wrote: > You probably just have to add 400 to errorpage.status_codes option in config > > See >

Re: Turbogears2 migration: custom error pages

2016-05-23 Thread Thomas De Schampheleire
Hi Alessandro, On Fri, Feb 19, 2016 at 10:14 PM, Thomas De Schampheleire wrote: > On Thu, Feb 18, 2016 at 4:23 PM, Alessandro Molina > wrote: >> >> >> On Thu, Feb 18, 2016 at 4:13 PM, Thomas De Schampheleire >>

Re: Turbogears2 migration: custom error pages

2016-02-19 Thread Thomas De Schampheleire
On Thu, Feb 18, 2016 at 4:23 PM, Alessandro Molina wrote: > > > On Thu, Feb 18, 2016 at 4:13 PM, Thomas De Schampheleire > wrote: >> >> >> So this means that Kallithea would start using the 'default' routing >> method used by Turbogears

Re: Turbogears2 migration: custom error pages

2016-02-18 Thread Alessandro Molina
On Thu, Feb 18, 2016 at 12:05 PM, Thomas De Schampheleire < patrickdeping...@gmail.com> wrote: > > Thanks, for basic 404 it indeed works. > However, I discovered at least one scenario where it does not: > Thanks for pointing that out. The reason is that when dispatching errors we do not pass

Re: Turbogears2 migration: custom error pages

2016-02-18 Thread Thomas De Schampheleire
On Thu, Feb 18, 2016 at 11:24 AM, Alessandro Molina wrote: > > > On Thu, Feb 18, 2016 at 10:56 AM, Alessandro Molina > wrote: >> >> >> >> On Thu, Feb 18, 2016 at 10:26 AM, Thomas De Schampheleire >> wrote: >>>