Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread hauptmech
Hi Wayne, Really awesome that you are creating this documentation! A couple thoughts: * No one reads documentation unless they have to. Usually after stabbing in the dark for a while. * If one has to read documentation, one wants it short and to the point. * Whatever basic knowledge you want

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Marco Ciampa
My 2 cents suggestions... On Fri, Jun 22, 2018 at 11:29:11AM -0500, Adam Wolf wrote: > I think this looks pretty good. Agree. [...] > What about adding a sentence near the beginning that says something > like "Ideally, upgrading to a new version of KiCad would take no > effort on your part.

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
OK, thank you. You are right. I see the difference now. I was deleting the layer tag to test it. The board has the layer tag but it is empty. I also confirm the error you mention. But I'm still not sure about the patch's approach. I think I am in agreement with JP here that the correct way

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
Ah. This is not an error in the board. This is just an NPTH. If you click on it in GAL, you will see it. I think the correct patch to this should check the pad type instead of drawing one with no layers. -S Am Fr., 22. Juni 2018 um 12:33 Uhr schrieb Andrzej Wolski < awolski.ki...@gmail.com>:

Re: [Kicad-developers] [PATCH] Save through hole pads color to config file

2018-06-22 Thread Kevin Cozens
On 2018-06-22 06:56 AM, Andrzej Wolski wrote: From ebfb1d5cc9ebdeddaa518f14e7c86b7e5c1bbdaa Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 01:35:05 +0200 Subject: [PATCH] Save through hole pads color to config file This seems like it changes the contents of an existing

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
No, this IS an error in the board :) If you open pad properties and click OK, it won't let you save it as is, you will have to enable copper layers. NPTH pads also HAVE TO exists on copper layers (I don't understand why, but they do). Also, as I already mentioned, current GAL behavior is

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
IIRC you have to leave (layers) to reproduce this. This is a board where I found the issue: https://github.com/mntmn/reform/blob/master/electronics/reform-motherboard.kicad_pcb There are two mPCIE connectors in the center, they have NPTH alignment holes, you can see them in legacy mode.

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
Those pads are shown in 4.0 GAL and in 5.0 legacy, only 5.0 GAL has this problem, so to me this is a regression fix rather than workaround. Fixing those pads may be a good idea, but that is another matter. Andrzej W dniu 2018-06-22 o 20:03, jp charras pisze: Le 22/06/2018 à 19:51, Andrzej

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Wayne Stambaugh
Good catch. I just pushed the fix to my repo. Thanks. Wayne On 06/22/2018 02:33 PM, Steven A. Falco wrote: > A small typo - the last note in the file has the phrase "by using opening". > That should either be "by using" or "by opening". > > Steve > > On 06/22/2018 12:10 PM, Wayne

Re: [Kicad-developers] Bug Tracker Milestone

2018-06-22 Thread Wayne Stambaugh
I'm fine with this going into 5.1 as long as we are not changing the board file format which doesn't appear to be the case with these changes. On 06/22/2018 10:28 AM, Jeff Young wrote: > The dialog work started life as eradicating the g_UserUnit global > variable so that the different apps

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Steven A. Falco
A small typo - the last note in the file has the phrase "by using opening". That should either be "by using" or "by opening". Steve On 06/22/2018 12:10 PM, Wayne Stambaugh wrote: > I pushed the v5 upgrade document to my personal repo[1] on git hub. I > made it part of the KiCad

Re: [Kicad-developers] [PATCH] Save through hole pads color to config file

2018-06-22 Thread Wayne Stambaugh
Hi Andrzej, Good catch. I merged your patch. Thank you for your contribution to KiCad. Cheers, Wayne On 06/22/2018 06:56 AM, Andrzej Wolski wrote: > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to :

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Adam Wolf
We can install different versions of the KiCad apps on macOS, but it is not easy to have different versions of the "support directory" at the same time. Adam On Fri, Jun 22, 2018 at 1:21 PM Wayne Stambaugh wrote: > > On 06/22/2018 12:29 PM, Adam Wolf wrote: > > I think this looks pretty good. >

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Wayne Stambaugh
On 06/22/2018 12:29 PM, Adam Wolf wrote: > I think this looks pretty good. > > Is there somewhere we suggest people should go to ask for help? The KiCad user forum is the best place to go for help. > > What about adding a sentence near the beginning that says something > like "Ideally,

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
Andrzej- I just tested this, editing a file to remove the layers from a pad and KiCad automatically adds the pad back to all copper layers. I see the pad in pcbnew and can edit it. Can you provide a board that demonstrates the issue? Maybe it was only the test board I used? -S Am Fr., 22.

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread jp charras
Le 22/06/2018 à 19:51, Andrzej Wolski a écrit : > Hi Seth, > > current behavior is that malformed pad holes are always hidden, so you can't > see on the screen > something that exists on your PCB and will be plotted in drill files. This > patch makes those holes > visible. > > Andrzej OK,

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
Hi Seth, current behavior is that malformed pad holes are always hidden, so you can't see on the screen something that exists on your PCB and will be plotted in drill files. This patch makes those holes visible. Andrzej W dniu 2018-06-22 o 17:46, Seth Hillbrand pisze: ​Andrzej- Can you

Re: [Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Adam Wolf
I think this looks pretty good. Is there somewhere we suggest people should go to ask for help? What about adding a sentence near the beginning that says something like "Ideally, upgrading to a new version of KiCad would take no effort on your part. We take effort to minimize changes that

[Kicad-developers] Version 5 upgrade document review.

2018-06-22 Thread Wayne Stambaugh
I pushed the v5 upgrade document to my personal repo[1] on git hub. I made it part of the KiCad documentation but I don't have a strong opinion about where to add it. This just seemed like the most logic place. Please review it when you get a chance. If you find any issues let me know, send me

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
​Andrzej- Can you explain the issue that this patch addresses? I read the commit message but it looks like malformed pads (GetLayerSet().any() == 0) are no longer hidden. This seems counter-intuitive but maybe I'm just not seeing the problem. Thanks! Seth​ Am Fr., 22. Juni 2018 um 03:57 Uhr

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
No, the patch didn't go the wrong way. If you try to shorten the right side of the bar, for some characters it will look really bad, and in case of "I" it will turn into dot. This is before patch: https://imgur.com/a/TjibR0Q Andrzej W dniu 2018-06-22 o 15:40, Kevin Cozens pisze: On

Re: [Kicad-developers] explode an intersection, how to start?

2018-06-22 Thread Ouabache Designworks
On Thu, Jun 21, 2018 at 9:22 PM, jc wrote: > I would like to explode an intersect, like 2 lines,if crossed, turn into 4. > > > This can be done easily with a line of command in autocad, 30yrs ago. > > I want to mske that happen in 4.0.7. Where should i start? > > Start by asking if you really

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-22 Thread Wayne Stambaugh
On 06/22/2018 09:19 AM, Carsten Schoenert wrote: > Am 22.06.2018 um 14:28 schrieb Wayne Stambaugh: >> This is not a trivial fix. Blindly copying the default global library >> tables every time they change would overwrite any user customization >> which is a not an option. It then becomes a merge

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Kevin Cozens
On 2018-06-22 07:01 AM, Andrzej Wolski wrote: This is an illustration of what this patch do: https://imgur.com/a/GxIeLkA Hm... did the patch go the wrong way with the change to the position and length of the bar over non-italicized text? Before the bar started at the left side of the letter

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-22 Thread Carsten Schoenert
Am 22.06.2018 um 14:28 schrieb Wayne Stambaugh: > This is not a trivial fix. Blindly copying the default global library > tables every time they change would overwrite any user customization > which is a not an option. It then becomes a merge operation which is > far more complex. I'm not

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-22 Thread Adam Wolf
Wayne, I can pull the text into the DMG or else link to it--Seth's idea of putting some text in the background to tell users who are upgrading to actually read the README will remove any guilt I have about excited users just assuming they know what to do and skipping any docs. Rather than a "we

Re: [Kicad-developers] Bug Tracker Milestone

2018-06-22 Thread Wayne Stambaugh
Nick, Thanks for taking care of this. It was on my list. There is one caveat. We will need to be diligent about what changes we allow into 5.0.1 versus 5.1.0. Please keep in mind that micro releases are bug fix only so no string or feature changes. Minor feature and string changes will have

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-22 Thread Wayne Stambaugh
On 06/22/2018 01:05 AM, Carsten Schoenert wrote: > Hi, > > Am 22.06.2018 um 04:52 schrieb Adam Wolf: > ... >> Is there any way we can detect if the fp-lib-table is out of sync and >> tell a user at run time? > > I'm too seeing this point not only related to the update now from V4 to > V5 and

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-22 Thread Wayne Stambaugh
I plan on pushing the preliminary v4 to v5 guide to my personal repo today for review. Hopefully, I can get enough comments and feedback by the end of the weekend to finalize and merge it into the master kicad documentation repo by Monday at the latest. How hard would it be to provide a link to

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

2018-06-22 Thread Wayne Stambaugh
Thank you for testing it. I appreciate the help. On 06/21/2018 09:07 PM, Kaspar Emanuel wrote: > Works great for me on latest nightly. Thanks again. > > On 20 June 2018 at 18:52, Wayne Stambaugh > wrote: > > Kasper, > > I just pushed the fix for this. 

Re: [Kicad-developers] explode an intersection, how to start?

2018-06-22 Thread Greg Smith
Have a look at Python or KiCommand plugin. Also, consider asking this question on KiCad user forums. Greg S. > On Jun 21, 2018, at 11:22 PM, jc wrote: > > I would like to explode an intersect, like 2 lines,if crossed, turn into 4. > > > This can be done easily with a line of command in

[Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
From d82e05f3328c95cb4443af7a2c0040ff1766fc96 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 12:07:56 +0200 Subject: [PATCH] GAL: Draw hole even if pad has no layer While pcbnew does not allow to create THT pad without a copper layer, there are boards that somehow have

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
This is an illustration of what this patch do: https://imgur.com/a/GxIeLkA Andrzej ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More

[Kicad-developers] [PATCH] Save through hole pads color to config file

2018-06-22 Thread Andrzej Wolski
From ebfb1d5cc9ebdeddaa518f14e7c86b7e5c1bbdaa Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 01:35:05 +0200 Subject: [PATCH] Save through hole pads color to config file TH Pads color is now user settable, so should be saved in config file. ---

[Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
From db2243f6fff9f1666049b501f45f582c2837caf2 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 12:51:53 +0200 Subject: [PATCH] Fix overbar drawing for non-italic text Overbar was always indented inward, regardless if text was italic or not. --- common/gal/stroke_font.cpp |

Re: [Kicad-developers] Bug Tracker Milestone

2018-06-22 Thread Nick Østergaard
Hello Seth I have created the following milestone names: 5.1.0 This is for fixes that are backportable from master, it could be string fixes and minor features. 5.0.1 Post release fixes that does not involve string changes. Att. Wayne, I would like you to say this is ok, or if we should use