Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-19 Thread Jeremy Katz
On Sun, 2007-09-16 at 22:00 +0200, Avi Kivity wrote: The attached patch adds support for a relatively basic boot device selection menu to the bochs bios code. [snip] This is nice! Two comments: - it would be nice for qemu to provide the bios an indication if the '-boot' parameter was

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-19 Thread Avi Kivity
Jeremy Katz wrote: On Sun, 2007-09-16 at 22:00 +0200, Avi Kivity wrote: The attached patch adds support for a relatively basic boot device selection menu to the bochs bios code. [snip] This is nice! Two comments: - it would be nice for qemu to provide the bios an

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-17 Thread Luca
On 9/16/07, Avi Kivity [EMAIL PROTECTED] wrote: - coding this stuff in rombios32.c instead of rombios.c (with its strange idea of C) is *much* preferable for maintainability. The strange code style is due to the compiler used (bcc). I see that today it's possible to make as and gcc to emit

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-17 Thread Avi Kivity
Luca wrote: On 9/16/07, Avi Kivity [EMAIL PROTECTED] wrote: - coding this stuff in rombios32.c instead of rombios.c (with its strange idea of C) is *much* preferable for maintainability. The strange code style is due to the compiler used (bcc). I see that today it's possible to

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-16 Thread Avi Kivity
Jeremy Katz wrote: I sent this to the bochs list earlier today, but given that kvm is already carrying patches for the BIOS, it may be worthwhile/interesting to add this also as it can make the user experience substantially nicer. -- Begin forwarded message -- The attached patch adds

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-14 Thread Anthony Liguori
Hi Jeremy, I gave this patch a try today against the latest git 1edeb9c05aa034633978f31e2c773a1be55ed337 and I cannot get past the Press F10... prompt. I'm on an Intel Core 2 Duo processor. It does work though with -no-kvm. Have you tested this patch with KVM? Regards, Anthony Liguori

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-12 Thread Anthony Liguori
Very cool! My mailer doesn't want to quote your patch, but I noticed the following: + +/* set the default based on the keypress or menu */ +switch(scan) { +case 0x3D: +outb_cmos(0x3d, 0x01); +break; +case 0x3E: +outb_cmos(0x3d, 0x02); +

Re: [kvm-devel] [PATCH] Add support for a basic boot menu to the bios

2007-09-12 Thread Jeremy Katz
On Wed, 2007-09-12 at 15:19 -0500, Anthony Liguori wrote: Very cool! Long-term itch of mine scratched :-) My mailer doesn't want to quote your patch, but I noticed the following: + +/* set the default based on the keypress or menu */ [snip] But the CMOS memory isn't persisted in