Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-20 Thread Noel Power
On 18/10/10 14:06, Povilas Kanapickas wrote: Hello, I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. As more than thousand of files have been changed

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-20 Thread Noel Power
sending again :/ On 18/10/10 14:06, Povilas Kanapickas wrote: Hello, I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. As more than thousand of files

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote: I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Wow. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. Ok -

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote: I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. So - I did some more review; I left a few useful / commented pieces in that were removed, but so

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Povilas Kanapickas
I was also interested in things like the UI string changes in binfilters - what was all that about ? :-) That was certainly not intended. It seems my editor has screwed up as it somehow didn't like some files. It couldn't open them using UTF-8, so I forced another encoding. That might be the

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Thorsten Behrens
Michael Meeks wrote: Everything except the 'filters' patch has been either pushed, or sent to the component maintainer for review. libs-gui parts (basebmp basegfx) just pushed. Kept a few useful bits in the */test, */workben subdirs, those are often playgrounds / staging areas for code.