[PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-07 Thread David Stevens
If a virtio_pci_device supports native PCI power management and has the No_Soft_Reset bit set, then skip resetting and reinitializing the device when suspending and restoring the device. This allows system-wide low power states like s2idle to be used in systems with stateful virtio devices that

Re: [PATCH] nvdimm-btt: fix a potential memleak in btt_freelist_init

2023-12-07 Thread dinghao . liu
> Dave Jiang wrote: > > > > [snip] > > First off thanks for the patch. This code seems to have a few things to > clean up. > > > > > On 12/6/23 20:43, Dinghao Liu wrote: > > > When an error happens in btt_freelist_init(), its caller > > > discover_arenas() will directly free arena, which

Re: [PATCH RFC v2 16/27] arm64: mte: Manage tag storage on page allocation

2023-12-07 Thread Hyesoo Yu
Hi. On Wed, Nov 29, 2023 at 01:33:37PM +, Alexandru Elisei wrote: > Hi, > > On Wed, Nov 29, 2023 at 06:10:40PM +0900, Hyesoo Yu wrote: > > On Sun, Nov 19, 2023 at 04:57:10PM +, Alexandru Elisei wrote: > > > [..] > > > +static int order_to_num_blocks(int order) > > > +{ > > > + return

Re: [PATCH RFC v2 15/27] arm64: mte: Check that tag storage blocks are in the same zone

2023-12-07 Thread Hyesoo Yu
Hi~ On Thu, Nov 30, 2023 at 12:00:11PM +, Alexandru Elisei wrote: > Hi, > > On Wed, Nov 29, 2023 at 05:57:44PM +0900, Hyesoo Yu wrote: > > On Sun, Nov 19, 2023 at 04:57:09PM +, Alexandru Elisei wrote: > > > alloc_contig_range() requires that the requested pages are in the same > > >

[PATCH 6/6] module: add install target for modules.builtin.ranges

2023-12-07 Thread Kris Van Hees
When CONFIG_BUILTIN_RANGES is enable, the modules.builtin.ranges file should be installed in the module install location. Signed-off-by: Kris Van Hees Reviewed-by: Nick Alcock --- scripts/Makefile.modinst | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/Makefile.modinst

[PATCH 5/6] kbuild: generate modules.builtin.ranges when linking the kernel

2023-12-07 Thread Kris Van Hees
Signed-off-by: Kris Van Hees Reviewed-by: Nick Alcock --- scripts/Makefile.vmlinux | 17 + 1 file changed, 17 insertions(+) diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux index c9f3e03124d7..c23d40b023ff 100644 --- a/scripts/Makefile.vmlinux +++

[PATCH 4/6] module: script to generate offset ranges for builtin modules

2023-12-07 Thread Kris Van Hees
The offset range data for builtin modules is generated using: - modules.builtin.objs: associates object files with module names - vmlinux.o: provides load order of sections and offset of first member per section - vmlinux.o.map: provides offset of object file content per section The

Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory

2023-12-07 Thread Hyesoo Yu
Hi, I'm sorry for the late response, I was on vacation. On Sun, Dec 03, 2023 at 12:14:30PM +, Alexandru Elisei wrote: > Hi, > > On Wed, Nov 29, 2023 at 05:44:24PM +0900, Hyesoo Yu wrote: > > Hello. > > > > On Sun, Nov 19, 2023 at 04:57:05PM +, Alexandru Elisei wrote: > > > Allow the

[PATCH 3/6] kbuild: generate a linker map for vmlinux.o

2023-12-07 Thread Kris Van Hees
When CONFIG_BUILTIN_RANGES is set, a linker map for vmlinux.o needs to be generated. The generation of offset range data for builtin modules depends on that linker map to know what offsets in an ELF section belong to an object file for a particular builtin module. Signed-off-by: Kris Van Hees

[PATCH 2/6] module: add CONFIG_BUILTIN_RANGES option

2023-12-07 Thread Kris Van Hees
The CONFIG_BUILTIN_RANGES option controls whether offset range data is generated for kernel modules that are built into the kernel image. Signed-off-by: Kris Van Hees Reviewed-by: Nick Alcock Reviewed-by: Alan Maguire --- kernel/module/Kconfig | 17 + 1 file changed, 17

[PATCH 1/6] kbuild: add modules.builtin.objs

2023-12-07 Thread Kris Van Hees
From: Luis Chamberlain The file modules.builtin names all modules that are built into the kernel; this is checked by modprobe to not fail when trying to load something built-in. But for tools which want to see which object files make up each module, we want to help them with such a mapping as it

[PATCH 0/6] Generate address range data for built-in modules

2023-12-07 Thread Kris Van Hees
Especially for tracing applications, it is convenient to be able to refer to a symbol using a pair and to be able to translate an address into a pair. But that does not work if the module is built into the kernel because the object files that comprise the built-in module implementation are

Re: [PATCH v2 2/2] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-07 Thread Huang, Ying
Vishal Verma writes: > Add a sysfs knob for dax devices to control the memmap_on_memory setting > if the dax device were to be hotplugged as system memory. > > The default memmap_on_memory setting for dax devices originating via > pmem or hmem is set to 'false' - i.e. no memmap_on_memory

Re: [PATCH V1] rpmsg: glink: smem: validate index before fifo read write

2023-12-07 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 04:36:31PM +0530, Deepak Kumar Singh wrote: > Fifo head and tail index can be modified with wrong values from > untrusted remote procs. Glink smem is not validating these index > before using to read or write fifo. This can result in out of > bound memory access if head and

[PATCH v2] ring-buffer: Add offset of events in dump on mismatch

2023-12-07 Thread Steven Rostedt
From: "Steven Rostedt (Google)" On bugs that have the ring buffer timestamp get out of sync, the config CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS, that checks for it and if it is detected it causes a dump of the bad sub buffer. It shows each event and their timestamp as well as the delta in the

Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch

2023-12-07 Thread Steven Rostedt
On Thu, 7 Dec 2023 17:19:24 -0500 Mathieu Desnoyers wrote: > On 2023-12-07 17:16, Steven Rostedt wrote: > > [...] > > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > > index 8d2a4f00eca9..b10deb8a5647 100644 > > --- a/kernel/trace/ring_buffer.c > > +++

Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch

2023-12-07 Thread Mathieu Desnoyers
On 2023-12-07 17:16, Steven Rostedt wrote: [...] diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 8d2a4f00eca9..b10deb8a5647 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct

[PATCH] ring-buffer: Add offset of events in dump on mismatch

2023-12-07 Thread Steven Rostedt
From: "Steven Rostedt (Google)" On bugs that have the ring buffer timestamp get out of sync, the config CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS, that checks for it and if it is detected it causes a dump of the bad sub buffer. It shows each event and their timestamp as well as the delta in the

Re: [PATCH] vdpa: Fix an error handling path in eni_vdpa_probe()

2023-12-07 Thread Christophe JAILLET
Le 20/10/2022 à 21:21, Christophe JAILLET a écrit : After a successful vp_legacy_probe() call, vp_legacy_remove() should be called in the error handling path, as already done in the remove function. Add the missing call. Fixes: e85087beedca ("eni_vdpa: add vDPA driver for Alibaba ENI")

[PATCH 1/3] nvdimm/btt: fix btt_blk_cleanup() kernel-doc

2023-12-07 Thread Randy Dunlap
Correct the function parameters to prevent kernel-doc warnings: btt.c:1567: warning: Function parameter or member 'nd_region' not described in 'btt_init' btt.c:1567: warning: Excess function parameter 'maxlane' description in 'btt_init' Signed-off-by: Randy Dunlap Cc: Vishal Verma Cc: Dan

[PATCH 3/3] nvdimm/namespace: fix kernel-doc for function params

2023-12-07 Thread Randy Dunlap
Adjust kernel-doc notation to prevent warnings when using -Wall. namespace_devs.c:76: warning: No description found for return value of 'nd_is_uuid_unique' namespace_devs.c:343: warning: No description found for return value of 'shrink_dpa_allocation' namespace_devs.c:668: warning: No

[PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params

2023-12-07 Thread Randy Dunlap
Adjust kernel-doc notation to prevent warnings when using -Wall. dimm_devs.c:59: warning: Function parameter or member 'ndd' not described in 'nvdimm_init_nsarea' dimm_devs.c:59: warning: Excess function parameter 'nvdimm' description in 'nvdimm_init_nsarea' dimm_devs.c:59: warning: No

Re: [PATCH] nvdimm-btt: fix a potential memleak in btt_freelist_init

2023-12-07 Thread Ira Weiny
Dave Jiang wrote: > [snip] First off thanks for the patch. This code seems to have a few things to clean up. > > On 12/6/23 20:43, Dinghao Liu wrote: > > When an error happens in btt_freelist_init(), its caller > > discover_arenas() will directly free arena, which makes > > arena->freelist

Re: [PATCH v2 2/2] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-07 Thread Verma, Vishal L
On Thu, 2023-12-07 at 08:29 +, Zhijian Li (Fujitsu) wrote: > Hi Vishal, > > > On 07/12/2023 12:36, Vishal Verma wrote: > > + > > +What:  /sys/bus/dax/devices/daxX.Y/memmap_on_memory > > +Date:  October, 2023 > > +KernelVersion: v6.8 > > +Contact:   nvd...@lists.linux.dev

Re: [PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning

2023-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 6 Dec 2023 17:41:43 +0100 you wrote: > After backporting commit 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY > flag support") in CentOS Stream 9, CI reported the following error: > > In file included from

Re: [PATCH] nvdimm-btt: fix a potential memleak in btt_freelist_init

2023-12-07 Thread Dave Jiang
On 12/6/23 20:43, Dinghao Liu wrote: > When an error happens in btt_freelist_init(), its caller > discover_arenas() will directly free arena, which makes > arena->freelist allocated in btt_freelist_init() a leaked > memory. Fix this by freeing arena->freelist in all error > handling paths of

[PATCH RT 1/2] Revert "sched/rt: Provide migrate_disable/enable() inlines"

2023-12-07 Thread Daniel Wagner
v4.19.299-rt130-rc1 stable review patch. If anyone has any objections, please let me know. --- This reverts commit 56e8949825226341d28dd5156b3d0057684ff669. The tree contains already the migrate_disable/enable() helpers thus this stable backport conflicts (b) with the existing

[PATCH RT 0/2] Linux v4.19.299-rt130-rc1

2023-12-07 Thread Daniel Wagner
Dear RT Folks, This is the RT stable review cycle of patch 4.19.299-rt130-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release is also available on kernel.org https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git on the

[PATCH RT 2/2] Linux 4.19.299-rt130

2023-12-07 Thread Daniel Wagner
v4.19.299-rt130-rc1 stable review patch. If anyone has any objections, please let me know. --- Signed-off-by: Daniel Wagner --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index 90303f5aabcf..6fa797e5b850 100644

Re: [PATCH v2] tracing: Allow creating instances with specified system events

2023-12-07 Thread Dmytro Maluka
On Tue, Dec 05, 2023 at 09:18:36PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A trace instance may only need to enable specific events. As the eventfs > directory of an instance currently creates all events which adds overhead, > allow internal instances to be created

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-07 Thread Yunsheng Lin
On 2023/12/7 14:00, Jason Wang wrote: > On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: ... >> + >> +static int tun_alloc(void) >> +{ >> + struct ifreq ifr; >> + int fd, e; >> + >> + fd = open("/dev/net/tun", O_RDWR); >> + if (fd < 0) { >> +

Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation

2023-12-07 Thread Yunsheng Lin
On 2023/12/7 11:15, Jakub Kicinski wrote: > On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: >> __GFP_DIRECT_RECLAIM is xor'd to avoid >> direct reclaim in skb_page_frag_refill(), but it is not >> xor'd in __page_frag_cache_refill(). > > xor is not the same thing as masking a bit off. You

Re: [PATCH v2 2/2] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-07 Thread Zhijian Li (Fujitsu)
Hi Vishal, On 07/12/2023 12:36, Vishal Verma wrote: > + > +What:/sys/bus/dax/devices/daxX.Y/memmap_on_memory > +Date:October, 2023 > +KernelVersion: v6.8 > +Contact: nvd...@lists.linux.dev > +Description: > + (RW) Control the memmap_on_memory