RE: [PATCH v9 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Peter Rosin
On September 7, 2018 11:48:37 PM GMT+02:00, Ajay Gupta wrote: >> >> Per your comments on v8, the address has to be programmed before >the >> >> transfer, but you fail to do that if the first message is a read. >> > This will never happen. Hint: I2C_AQ_COMB_WRITE_FIRST >> >> Yes, it will. If the

[PATCH v10 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Ajay Gupta
Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C controller which can be accessed over I2C. This driver adds I2C bus driver to communicate with Type-C controller. I2C client driver will be part of USB Type-C UCSI driver. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko

[PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-07 Thread Ajay Gupta
Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C interface. This UCSI I2C driver uses I2C bus driver interface for communicating with Type-C controller. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko Acked-by: Heikki Krogerus --- Changes from v1 -> v2

RE: [PATCH v9 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-07 Thread Ajay Gupta
Hi Peter, > >>> + memcpy(buf1, ((const void *)uc->ppm.data) + 0x20, sizeof(buf1)); > >>> + memcpy(buf2, ((const void *)uc->ppm.data) + 0x8, sizeof(buf2)); > >>> + > >>> + status = ccg_write(uc, *(u16 *)buf, buf1, sizeof(buf1)); > >> > >> This seems to be endian-dependent. May I suggest that you

RE: [PATCH v9 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Ajay Gupta
Hi Peter, > >> Hmm, what do you need to sync read/write with? > > What if there are multiple clients and each of them wants to use I2C bus for > read/write? > > Even in UCSI client, user may want to change alt mode which will > > result in read/write request in a thread. So we have to synchronize

Re: [PATCH v9 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-07 Thread Peter Rosin
On 2018-09-07 19:28, Ajay Gupta wrote: > Hi Peter, > >> -Original Message- >> From: Peter Rosin >> Sent: Friday, September 7, 2018 2:13 AM >> To: Ajay Gupta ; w...@the-dreams.de; >> heikki.kroge...@linux.intel.com >> Cc: linux-usb@vger.kernel.org; linux-...@vger.kernel.org >> Subject:

Re: [PATCH v9 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Peter Rosin
On 2018-09-07 19:15, Ajay Gupta wrote: > Hi Peter, >>> Signed-off-by: Ajay Gupta >>> Reviewed-by: Andy Shevchenko >>> Reviewed-by: Heikki Krogerus >>> --- >>> Changes from v1 -> v2 >>> None >>> Changes from v2 -> v3 >>> Fixed review comments from Andy and Thierry >>> Rename

RE: [PATCH v9 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-07 Thread Ajay Gupta
Hi Peter, > -Original Message- > From: Peter Rosin > Sent: Friday, September 7, 2018 2:13 AM > To: Ajay Gupta ; w...@the-dreams.de; > heikki.kroge...@linux.intel.com > Cc: linux-usb@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH v9 2/2] usb: typec: ucsi: add support for

RE: [PATCH v9 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Ajay Gupta
Hi Peter, > > Signed-off-by: Ajay Gupta > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Heikki Krogerus > > --- > > Changes from v1 -> v2 > > None > > Changes from v2 -> v3 > > Fixed review comments from Andy and Thierry > > Rename i2c-gpu.c -> i2c-nvidia-gpu.c > > Changes from v3

Re: [PATCH] usb: typec: Group all TCPCI/TCPM code together

2018-09-07 Thread Guenter Roeck
On Fri, Sep 07, 2018 at 05:06:12PM +0300, Heikki Krogerus wrote: > On Fri, Sep 07, 2018 at 06:35:12AM -0700, Guenter Roeck wrote: > > On 09/07/2018 05:56 AM, Heikki Krogerus wrote: > > > Moving all the drivers that depend on the Port Controller > > > Manager under a new a new directory

Re: usb 3-1: device descriptor read/64, error -110

2018-09-07 Thread Alan Stern
On Fri, 7 Sep 2018, Cristian wrote: > Hello, > > Open report in: > https://bugzilla.kernel.org/show_bug.cgi?id=201037 > > dmesg: > [7.008154] usb 3-1: device descriptor read/64, error -110 Here's some more of the log: [7.008154] usb 3-1: device descriptor read/64, error -110 [

usb 3-1: device descriptor read/64, error -110

2018-09-07 Thread Cristian
Hello, Open report in: https://bugzilla.kernel.org/show_bug.cgi?id=201037 dmesg: [7.008154] usb 3-1: device descriptor read/64, error -110 Best regards, -- Cristian Aravena Romero (caravena)

Re: [PATCH] usb: typec: Group all TCPCI/TCPM code together

2018-09-07 Thread Heikki Krogerus
On Fri, Sep 07, 2018 at 06:35:12AM -0700, Guenter Roeck wrote: > On 09/07/2018 05:56 AM, Heikki Krogerus wrote: > > Moving all the drivers that depend on the Port Controller > > Manager under a new a new directory drivers/usb/typec/tcpci/ > > and making Guenter Roeck as the designated reviewer of

Re: [PATCH] usb: typec: Group all TCPCI/TCPM code together

2018-09-07 Thread Guenter Roeck
On 09/07/2018 05:56 AM, Heikki Krogerus wrote: Moving all the drivers that depend on the Port Controller Manager under a new a new directory drivers/usb/typec/tcpci/ and making Guenter Roeck as the designated reviewer of that code. Signed-off-by: Heikki Krogerus --- Hi guys, This should be

[PATCH] usb: typec: Group all TCPCI/TCPM code together

2018-09-07 Thread Heikki Krogerus
Moving all the drivers that depend on the Port Controller Manager under a new a new directory drivers/usb/typec/tcpci/ and making Guenter Roeck as the designated reviewer of that code. Signed-off-by: Heikki Krogerus --- Hi guys, This should be fairly trivial change. There is no functional

Re: [PATCH v3 02/10] usb: roles: Handle driver reference counting

2018-09-07 Thread Heikki Krogerus
On Thu, Sep 06, 2018 at 10:59:34PM +0200, Hans de Goede wrote: > HI, > > On 04-09-18 13:22, Heikki Krogerus wrote: > > This fixes potential "BUG: unable to handle kernel paging > > request at ..." from happening. > > > > Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches") > >

Re: [PATCH v9 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-07 Thread Peter Rosin
On 2018-09-07 01:56, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C UCSI driver. > >

Re: [PATCH v9 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-07 Thread Peter Rosin
On 2018-09-07 01:56, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta > Reviewed-by: Andy Shevchenko >

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 11:33:23AM +0300, Felipe Balbi wrote: > > Hi Greg, > > "Gopal, Saranya" writes: > >> > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> b/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> > index dad2d19..0d1ea82 100644 > >> > ---

RE: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Felipe Balbi
Hi Greg, "Gopal, Saranya" writes: >> > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c >> b/drivers/usb/roles/intel-xhci-usb-role-switch.c >> > index dad2d19..0d1ea82 100644 >> > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c >> > +++

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Heikki Krogerus
+Hans On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > >

RE: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Gopal, Saranya
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, September 07, 2018 12:49 PM > To: Gopal, Saranya > Cc: linux-usb@vger.kernel.org; heikki.kroge...@linux.intel.com; Kuppuswamy, > Sathyanarayanan ; K V, Abhilash > ; Balaji, M > Subject: Re: [PATCH

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > > Signed-off-by:

[PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread saranya . gopal
From: Saranya Gopal This patch adds static DRD mode for host/device mode switch. This fixes the issue where device mode was not working after DUT switches to host mode with 3.0 OTG connector. Signed-off-by: Saranya Gopal Signed-off-by: M Balaji Reviewed-by: Heikki Krogerus Reviewed-by:

Re: [PATCH V5] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 11:45:18AM +0530, saranya.go...@intel.com wrote: > From: saranya That's not right :( > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. >

[PATCH V5] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread saranya . gopal
From: saranya This patch adds static DRD mode for host/device mode switch. This fixes the issue where device mode was not working after DUT switches to host mode with 3.0 OTG connector. Signed-off-by: saranya Signed-off-by: M Balaji Reviewed-by: Heikki Krogerus Reviewed-by: Kuppuswamy