Re: [PATCH] USB: serial: iuu_phoenix: remove redundant assignment of DIV to itself

Am 20.11.2017 18:40, schrieb Colin King: > From: Colin Ian King > > The assignment of DIV to itself is redundant and can be removed. > > Signed-off-by: Colin Ian King > --- > drivers/usb/serial/iuu_phoenix.c | 1 - > 1 file changed, 1

Re: [PATCH] usb: storage: fix infinite wait loop by incrementing loop counter

Am 02.02.2017 14:19, schrieb Colin King: > From: Colin Ian King > > If jumpshot_get_status continues to return a failed result then the > wait loop will spin forever because the waitcount counter is never > being incremented and we don't ever timeout. Fix this by

Re: [patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

much better readable than the original. nice work re, wh Am 28.05.2016 06:48, schrieb Dan Carpenter: > This loop is supposed to set all the .num[] values to -1 but it's off by > one so it skips the first element and sets one element past the end of > the array. > > I've cleaned up the loop a

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

Am 27.05.2016 14:23, schrieb Michal Nazarewicz: > On Fri, May 27 2016, Dan Carpenter wrote: >> This loop is supposed to set all the .num values to -1 but it's doesn't >> set the first element and it sets one element beyond the end of the >> array. Really there is no reason for it to be done

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

Am 27.05.2016 13:23, schrieb Dan Carpenter: > This loop is supposed to set all the .num values to -1 but it's doesn't > set the first element and it sets one element beyond the end of the > array. Really there is no reason for it to be done backwards. And > "ret" is the wrong variable to use

Re: problems with cp210x

Am 17.03.2016 18:04, schrieb Greg KH: > On Thu, Mar 17, 2016 at 05:41:13PM +0100, walter harms wrote: >> >> >> Am 29.02.2016 17:10, schrieb Greg KH: >>> On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: >>>> Hello List, >>>> >

Re: problems with cp210x

Am 29.02.2016 17:10, schrieb Greg KH: > On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: >> Hello List, >> >> is someone aware of a problem with DTR in that driver ? >> >> I use: Linux version 3.4.53-MMI-SW.401_0.1-43 > > That's a very old a

Re: problems with cp210x

I am aware of it, the system is a prototype and they wanted to stay with something they know. I will ask for am update. re, wh Am 29.02.2016 17:10, schrieb Greg KH: > On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: >> Hello List, >> >> is someone aware

problems with cp210x

Hello List, is someone aware of a problem with DTR in that driver ? I use: Linux version 3.4.53-MMI-SW.401_0.1-43 My test was to use TIOCMBIS to set RTS and DTR while RTS is fine DTR is dead. re, wh ps: please mail me directly i am not a list member. -- To unsubscribe from this list: send

Re: [PATCH] UVC: use GFP_ATOMIC under spin lock.

Am 19.11.2012 22:34, schrieb Cyril Roelandt: Found using the following semantic patch: spml @@ @@ spin_lock_irqsave(...); ... when != spin_unlock_irqrestore(...); * GFP_KERNEL /spml Signed-off-by: Cyril Roelandt tipec...@gmail.com --- drivers/usb/gadget/uvc_video.c |2 +- 1

Re: [patch] USB: usbtest: prevent a divide by zero bug

Am 17.11.2012 16:06, schrieb Dan Carpenter: If param-length is zero, then this could lead to a divide by zero bug later in the function when we do: size %= max; Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c