Re: [PATCH 4/4] powerpc/64s: Use POWER10 stsync barrier for wmb()

2023-06-13 Thread Michael Ellerman
Michael Ellerman writes: > Nicholas Piggin writes: >> The most expensive ordering for hwsync to provide is the store-load >> barrier, because all prior stores have to be drained to the caches >> before subsequent instructions can complete. >> >> stsync just orders stores which means it can just

Re: [PATCH] powerpc/xmon: Fix comparing pointer

2023-06-13 Thread Christophe Leroy
Le 14/06/2023 à 07:48, wuyonggang...@208suo.com a écrit : > [Vous ne recevez pas souvent de courriers de wuyonggang...@208suo.com. > D?couvrez pourquoi ceci est important ? > https://aka.ms/LearnAboutSenderIdentification ] > > Fix the following coccicheck warning: > >

[PATCH] powerpc/xmon: Fix comparing pointer

2023-06-13 Thread wuyonggang001
Fix the following coccicheck warning: arch/powerpc/xmon/spu-dis.c:51:34-35: WARNING comparing pointer to 0 Signed-off-by: Yonggang Wu --- arch/powerpc/xmon/spu-dis.c | 384 ++-- 1 file changed, 193 insertions(+), 191 deletions(-) diff --git

Re: [PATCH 2/4] powerpc/64s: Add POWER10 store sync mnemonics

2023-06-13 Thread Nicholas Piggin
On Tue Jun 13, 2023 at 3:31 PM AEST, Joel Stanley wrote: > On Fri, 9 Jun 2023 at 10:01, Nicholas Piggin wrote: > > > > ISA v3.1 introduces new sync types for store ordering. > > > > stncisync > > stcisync > > stsync > > > > Add ppc-opcode defines for these. This changes PPC_RAW_SYNC to take

Re: [PATCH 00/16] Add support for DAX vmemmap optimization for ppc64

2023-06-13 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > This patch series implements changes required to support DAX vmemmap > optimization for ppc64. The vmemmap optimization is only enabled with radix > MMU > translation and 1GB PUD mapping with 64K page size. The patch series also > split > hugetlb vmemmap

Re: [PATCH] KVM: PPC: remove unneeded variable

2023-06-13 Thread Paul Mackerras
On Wed, Jun 14, 2023 at 10:34:45AM +0800, baomingtong...@208suo.com wrote: > fix the following coccicheck warning: > > arch/powerpc/kvm/book3s_pr.c:424:5-6: Unneeded variable: "r". > > Signed-off-by: Mingtong Bao > --- > arch/powerpc/kvm/book3s_pr.c | 4 ++-- > 1 file changed, 2 insertions(+),

[PATCH] KVM: PPC: remove unneeded variable

2023-06-13 Thread baomingtong001
fix the following coccicheck warning: arch/powerpc/kvm/book3s_pr.c:424:5-6: Unneeded variable: "r". Signed-off-by: Mingtong Bao --- arch/powerpc/kvm/book3s_pr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Leo Yan
On Tue, Jun 13, 2023 at 11:34:11PM -0300, Arnaldo Carvalho de Melo wrote: [...] > > Since have applied this patch, it's no need to give my review tag :) > > No, I usually can add a Reviewed-by tag even after having applied it to > my local tree, as I still need to run tests before making it

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 14, 2023 at 09:59:14AM +0800, Leo Yan escreveu: > On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > > From: Sourabh Jain > > > > > > Script doesn't use sys library, so remove it. > > >

Re: [PATCH 06/17] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:34PM +0530, Athira Rajeev escreveu: > From: Akanksha J N > > Fix the shellcheck warnings on powerpc and x86 for testcase > trace+probe_vfs_getname.sh. Add quotes to prevent word splitting > which are caused by unquoted command expansions. > > Before fix: > > $

[powerpc:fixes] BUILD SUCCESS dfaed3e1fa7099de8de4e89cbe7eb9c1bca27dfe

2023-06-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes branch HEAD: dfaed3e1fa7099de8de4e89cbe7eb9c1bca27dfe powerpc/64s/radix: Fix exit lazy tlb mm switch with irqs enabled elapsed time: 728m configs tested: 5 configs skipped: 112 The following configs have

Re: [PATCH v1 01/21] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec

2023-06-13 Thread Leizhen (ThunderTown)
On 2023/6/13 1:27, Eric DeVolder wrote: > The config options for kexec and crash features are consolidated > into new file kernel/Kconfig.kexec. Under the "General Setup" submenu > is a new submenu "Kexec and crash handling" where all the kexec and > crash options that were once in the

Re: [PATCH v1 05/21] arm64/kexec: refactor for kernel/Kconfig.kexec

2023-06-13 Thread Leizhen (ThunderTown)
On 2023/6/13 1:27, Eric DeVolder wrote: > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_HAS_ and ARCH_SUPPORTS_ entries to recreate the > equivalent set of KEXEC and CRASH options. > > Signed-off-by: Eric

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Leo Yan
On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > From: Sourabh Jain > > > > Script doesn't use sys library, so remove it. > > Please Cc the persons working on that file, I added Leo to the CC list >

Re: [kvm-unit-tests v4 00/12] powerpc: updates, P10, PNV support

2023-06-13 Thread Joel Stanley
On Thu, 8 Jun 2023 at 07:58, Nicholas Piggin wrote: > > Posting again, a couple of patches were merged and accounted for review > comments from last time. I saw some failures in the spr tests running on a power9 powernv system: $ TESTNAME=sprs TIMEOUT=90s ACCEL= ./powerpc/run powerpc/sprs.elf

Re: [PATCH v4 27/34] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-13 Thread Dinh Nguyen
On 6/12/23 16:04, Vishal Moola (Oracle) wrote: Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/nios2/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 01/13] nios2: define virtual address space for modules

2023-06-13 Thread Dinh Nguyen
On 6/1/23 05:12, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" nios2 uses kmalloc() to implement module_alloc() because CALL26/PCREL26 cannot reach all of vmalloc address space. Define module space as 32MiB below the kernel base and switch nios2 to use vmalloc for module allocations.

Re: [PATCH 16/17] perf tests task_analyzer: print command on failure

2023-06-13 Thread Hagen Paul Pfeifer
* Arnaldo Carvalho de Melo | 2023-06-13 17:07:52 [-0300]: >> From: Aditya Gupta >> >> Instead of printing "perf command failed" everytime, print the exact >> command that run earlier > >Looks like a nice improvement, added the test authors to the CC list on >this message, Thank you Aditya and

Re: [PATCH v1 00/21] refactor Kconfig to consolidate KEXEC and CRASH options

2023-06-13 Thread Kees Cook
On Mon, Jun 12, 2023 at 01:27:52PM -0400, Eric DeVolder wrote: > The Kconfig is refactored to consolidate KEXEC and CRASH options from > various arch//Kconfig files into new file kernel/Kconfig.kexec. This looks very nice! > [...] > - The boolean ARCH_HAS_ in effect allows the arch to determine

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Edgecombe, Rick P
On Tue, 2023-06-13 at 09:19 +0200, Geert Uytterhoeven wrote: > Acked-by: Geert Uytterhoeven Thanks!

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Edgecombe, Rick P
On Tue, 2023-06-13 at 10:43 +0300, Mike Rapoport wrote: > On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote: > > The x86 Shadow stack feature includes a new type of memory called > > shadow > > stack. This shadow stack memory has some unusual properties, which > > requires > > some

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Edgecombe, Rick P
On Tue, 2023-06-13 at 14:26 +0200, David Hildenbrand wrote: > > Acked-by: David Hildenbrand Thanks!

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread David Hildenbrand
On 13.06.23 02:10, Rick Edgecombe wrote: The x86 Shadow stack feature includes a new type of memory called shadow stack. This shadow stack memory has some unusual properties, which requires some core mm changes to function properly. One of these unusual properties is that shadow stack memory is

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Mike Rapoport
On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote: > The x86 Shadow stack feature includes a new type of memory called shadow > stack. This shadow stack memory has some unusual properties, which requires > some core mm changes to function properly. > > One of these unusual properties

Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check

2023-06-13 Thread Sean Christopherson
+ Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be trivial, but it still needs eyeballs from the relevant maintainers. On Wed, Mar 15, 2023, Wei Wang wrote: > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device > framework (e.g. KVM_CREATE_DEVICE) is

Re: [PATCH 00/13] mm: jit/text allocator

2023-06-13 Thread Mike Rapoport
On Tue, Jun 13, 2023 at 02:56:14PM -0400, Kent Overstreet wrote: > On Thu, Jun 08, 2023 at 09:41:16PM +0300, Mike Rapoport wrote: > > On Tue, Jun 06, 2023 at 11:21:59AM -0700, Song Liu wrote: > > > On Mon, Jun 5, 2023 at 3:09 AM Mark Rutland wrote: > > > > > > [...] > > > > > > > > > > Can you

Re: [PATCH 00/17] tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:28PM +0530, Athira Rajeev escreveu: > Patchset covers a set of fixes for coding/formatting issues observed while > running shellcheck tool on the perf test shell scripts. Shellcheck is a static > analysis tool that can find semantic/syntax bugs in the shell scripts.

Re: [PATCH 16/17] perf tests task_analyzer: print command on failure

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:44PM +0530, Athira Rajeev escreveu: > From: Aditya Gupta > > Instead of printing "perf command failed" everytime, print the exact > command that run earlier Looks like a nice improvement, added the test authors to the CC list on this message, Thanks, applied. -

Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:43PM +0530, Athira Rajeev escreveu: > From: Aditya Gupta > > ${$1} gives bad substitution error on sh, bash, and zsh. This seems like > a typo, and this patch modifies it to $1, since that is what it's usage > looks like from wherever `check_exec_0` is called.

Re: [PATCH v2 2/2] powerpc/mm: Add memory_block_size as a kernel parameter

2023-06-13 Thread Reza Arbab
On Fri, Jun 09, 2023 at 11:38:51AM +0530, Aneesh Kumar K.V wrote: Certain devices can possess non-standard memory capacities, not constrained to multiples of 1GB. Provide a kernel parameter so that we can map the device memory completely on memory hotplug. Case in point; the memory block size

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > From: Sourabh Jain > > Script doesn't use sys library, so remove it. Please Cc the persons working on that file, I added Leo to the CC list of this message. Thanks, applied. - Arnaldo > Report by pylint: > W0611: Unused

Re: [PATCH v2 1/2] powerpc/mm: Cleanup memory block size probing

2023-06-13 Thread Reza Arbab
On Fri, Jun 09, 2023 at 11:38:50AM +0530, Aneesh Kumar K.V wrote: Parse the device tree in early init to find the memory block size to be used by the kernel. Consolidate the memory block size device tree parsing to one helper and use that on both powernv and pseries. We still want to use

Re: [PATCH 0/3] Move the ARCH_DMA_MINALIGN definition to asm/cache.h

2023-06-13 Thread Catalin Marinas
On Tue, Jun 13, 2023 at 04:42:40PM +, Christophe Leroy wrote: > > > Le 13/06/2023 à 17:52, Catalin Marinas a écrit : > > Hi, > > > > The ARCH_KMALLOC_MINALIGN reduction series defines a generic > > ARCH_DMA_MINALIGN in linux/cache.h: > > > >

[PATCH 14/17] tools/perf/tests: Fix all POSIX sh warnings in stat+shadow_stat.sh

2023-06-13 Thread Athira Rajeev
From: Spoorthy S Running shellcheck -S on stat+shadow_stat.sh testcase, generates SC2046 and SC2034 warnings, $ shellcheck -S warning tests/shell/stat+shadow_stat.sh res=`printf "%.2f" $(echo "scale=6; $num / $cyc" | bc -q)` : Quote this to prevent word

[PATCH 07/17] perf/tests/shell : Shellcheck fixes for perf test "test_arm_coresight.sh"

2023-06-13 Thread Athira Rajeev
From: Anushree Mathur Fixed the following shellcheck issues in test_arm_coresight.sh file: In tools/perf/tests/shell/test_arm_coresight.sh line 31: trap - exit term int ^--^ SC2039: In POSIX sh, using lower/mixed case for signal names is undefined.

Re: [PATCH 00/13] mm: jit/text allocator

2023-06-13 Thread Kent Overstreet
On Thu, Jun 08, 2023 at 09:41:16PM +0300, Mike Rapoport wrote: > On Tue, Jun 06, 2023 at 11:21:59AM -0700, Song Liu wrote: > > On Mon, Jun 5, 2023 at 3:09 AM Mark Rutland wrote: > > > > [...] > > > > > > > > Can you give more detail on what parameters you need? If the only > > > > > > extra >

Re: [PATCH 3/9] cpu/SMT: Store the current/max number of threads

2023-06-13 Thread Thomas Gleixner
On Tue, Jun 13 2023 at 19:16, Laurent Dufour wrote: > On 10/06/2023 23:26:18, Thomas Gleixner wrote: >> On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: >>> #ifdef CONFIG_HOTPLUG_SMT >>> enum cpuhp_smt_control cpu_smt_control __read_mostly = CPU_SMT_ENABLED; >>> +static unsigned int

[PATCH 11/17] perf/tests/shell: fix shellscript errors for lock_contention.sh

2023-06-13 Thread Athira Rajeev
From: Abhirup Deb Use quotes around variables to prevent POSIX word expansion, use uppercase for signals(INT, TERM, EXIT) to avoid mixed/lower case naming of signals and replace "==" with "=" as "==" is not supported by POSIX shell. Signed-off-by: Athira Rajeev Signed-off-by: Kajol Jain

Re: [PATCH] powerpc/iommu: TCEs are incorrectly manipulated with DLPAR add/remove of memory

2023-06-13 Thread Gaurav Batra
Hello Michael, I found this bug while going though the code. This bug is exposed when DDW is smaller than the max memory of the LPAR. This will result in creating DDW which will have Dynamically mapped TCEs (no direct mapping). I would like to stress that this  bug is exposed only in

[PATCH 09/17] tools/perf/tests: Fix shellcheck issues in test_task_analyzer.sh file

2023-06-13 Thread Athira Rajeev
From: Aboorva Devarajan Fixed the following shellcheck issues in test_task_analyzer.sh file: SC2086: Double quote to prevent globbing and word splitting warnings in shell-check. Fixes the following shellcheck issues, SC2086: Double quote to prevent globbing and word splitting warnings in

[PATCH 13/17] tools/perf/tests: Fix all POSIX sh warnings in perf shell test test_brstack.sh

2023-06-13 Thread Athira Rajeev
From: Geetika Fix all the POSIX sh warnings in perf shell test test_brstack.sh Warnings fixed : * In POSIX sh, using lower/mixed case for signal names is undefined. Correcting that in this script. * In POSIX sh, 'local' is undefined. local is supported in many shells, but it's not in POSIX. In

[PATCH 10/17] tools/perf/tests: fix test_arm_spe.sh signal case issues

2023-06-13 Thread Athira Rajeev
From: Abhirup Deb Running shellcheck -S on test_arm_spe.sh throws below warnings: #shellcheck -S warning tests/shell/test_arm_spe.sh In tests/shell/test_arm_spe.sh line 30: trap cleanup_files exit term int ^--^ SC3049 (warning): In POSIX sh, using lower/mixed case for

[PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Athira Rajeev
From: Sourabh Jain Script doesn't use sys library, so remove it. Report by pylint: W0611: Unused import sys (unused-import) Signed-off-by: Athira Rajeev Signed-off-by: Kajol Jain Signed-off-by: Sourabh Jain --- tools/perf/scripts/python/arm-cs-trace-disasm.py | 1 - 1 file changed, 1

[PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-13 Thread Athira Rajeev
From: Aditya Gupta ${$1} gives bad substitution error on sh, bash, and zsh. This seems like a typo, and this patch modifies it to $1, since that is what it's usage looks like from wherever `check_exec_0` is called. This issue due to ${$1} caused all function calls to give error in

[PATCH 17/17] perf tests task_analyzer: skip tests if no libtraceevent support

2023-06-13 Thread Athira Rajeev
From: Aditya Gupta Test "perf script task-analyzer tests" fails in environment with missing libtraceevent support, as perf record fails to create the perf.data file, which further tests depend on. Instead, when perf is not compiled with libtraceevent support, skip those tests instead of failing

[PATCH 02/17] tools/perf/tests: fix shellcheck warning for stat+json_output

2023-06-13 Thread Athira Rajeev
From: Disha Goel Running shellcheck on stat+json_output testcase, generates below warning: [ $(id -u) != 0 ] && [ $(cat /proc/sys/kernel/perf_event_paranoid) -gt $1 ] ^--^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2046

[PATCH 04/17] tools/perf/tests: fix shellcheck warnings for daemon.sh

2023-06-13 Thread Athira Rajeev
From: Shirisha G Running shellcheck -S on daemon.sh throws below warnings: Result from shellcheck: # shellcheck -S warning daemon.sh local line_name=`echo "${line}" | awk 'BEGIN { FS = ":" } ; { print $2 }'` ^---^ SC2155: Declare and assign separately to avoid masking

Re: [PATCH 3/9] cpu/SMT: Store the current/max number of threads

2023-06-13 Thread Laurent Dufour
On 10/06/2023 23:26:18, Thomas Gleixner wrote: > On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: >> #ifdef CONFIG_HOTPLUG_SMT >> enum cpuhp_smt_control cpu_smt_control __read_mostly = CPU_SMT_ENABLED; >> +static unsigned int cpu_smt_max_threads __ro_after_init; >> +unsigned int

[PATCH] powerpc/iommu: TCEs are incorrectly manipulated with DLPAR add/remove of memory

2023-06-13 Thread Gaurav Batra
When memory is dynamically added/removed, iommu_mem_notifier() is invoked. This routine traverses through all the DMA windows (DDW only, not default windows) to add/remove "direct" TCE mappings. The routines for this purpose are tce_clearrange_multi_pSeriesLP() and

[PATCH 00/17] tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts

2023-06-13 Thread Athira Rajeev
Patchset covers a set of fixes for coding/formatting issues observed while running shellcheck tool on the perf test shell scripts. Shellcheck is a static analysis tool that can find semantic/syntax bugs in the shell scripts. Patches 1-14 fixes the issues found with shellcheck. Patch 15, 16 and

[PATCH 03/17] shellcheck : fixing signal names and adding double quotes for expression in test_arm_callgraph_fp

2023-06-13 Thread Athira Rajeev
From: Spoorthy S Running shellcheck -S on test_arm_calligraph_fp throws warnings SC2086 and SC3049,   $shellcheck -S warning tests/shell/test_arm_callgraph_fp.sh  rm -f $PERF_DATA : Double quote to prevent globbing and word splitting.  trap cleanup_files exit

[PATCH 16/17] perf tests task_analyzer: print command on failure

2023-06-13 Thread Athira Rajeev
From: Aditya Gupta Instead of printing "perf command failed" everytime, print the exact command that run earlier Signed-off-by: Athira Rajeev Signed-off-by: Kajol Jain Signed-off-by: Aditya Gupta --- tools/perf/tests/shell/test_task_analyzer.sh | 24 ++-- 1 file changed, 12

[PATCH 12/17] tools/perf/tests: fixed shellcheck warnings for perf shell scripts

2023-06-13 Thread Athira Rajeev
From: Samir Mulani Fixed the shellcheck warnings in buildid.sh, record+probe_libc_inet_pton.sh and record+script_probe_vfs_getname.sh perf shell scripts: 1. Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. 2. Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. 3. Used * argument to

[PATCH 08/17] tools/perf/tests/shell/stat_all_metrics: Fix shellcheck warning SC2076 in stat_all_metrics.sh

2023-06-13 Thread Athira Rajeev
From: Barnali Guha Thakurata Fixed shellcheck warning SC2076 in stat_all_metrics.sh. Before the patch: shell$ shellcheck stat_all_metrics.sh In stat_all_metrics.sh line 9: if [[ "$result" =~ "${m:0:50}" ]] || [[ "$result" =~ "" ]] ^-^ SC2076: Don't quote

[PATCH 05/17] tools/perf/tests: Fix shellcheck warnings for stat+csv_output

2023-06-13 Thread Athira Rajeev
From: Korrapati Likhitha Running the shellcheck on stat+csv_output resulted in the following warning. Result with shellcheck without patch: = $ shellcheck -S warning stat+csv_output.sh In stat+csv_output.sh line 23: [ $(uname -m) = "s390x" ] && exp='^[6-7]$'

[PATCH 06/17] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh

2023-06-13 Thread Athira Rajeev
From: Akanksha J N Fix the shellcheck warnings on powerpc and x86 for testcase trace+probe_vfs_getname.sh. Add quotes to prevent word splitting which are caused by unquoted command expansions. Before fix: $ shellcheck -S warning trace+probe_vfs_getname.sh In trace+probe_vfs_getname.sh

Re: [PATCH 0/3] Move the ARCH_DMA_MINALIGN definition to asm/cache.h

2023-06-13 Thread Christophe Leroy
Le 13/06/2023 à 17:52, Catalin Marinas a écrit : > Hi, > > The ARCH_KMALLOC_MINALIGN reduction series defines a generic > ARCH_DMA_MINALIGN in linux/cache.h: > > https://lore.kernel.org/r/20230612153201.554742-2-catalin.mari...@arm.com/ > > Unfortunately, this causes a duplicate definition

Re: linux-next: Tree for Jun 13 (drivers/net/ethernet/freescale/fs_enet/mii-fec.c)

2023-06-13 Thread Randy Dunlap
On 6/12/23 23:59, Stephen Rothwell wrote: > Hi all, > > Changes since 20230609: > on PPC32: ../drivers/net/ethernet/freescale/fs_enet/mii-fec.c: In function 'fs_enet_mdio_probe': ../drivers/net/ethernet/freescale/fs_enet/mii-fec.c:130:50: warning: format '%x' expects argument of type

[PATCH 2/3] microblaze: Move the ARCH_{DMA,SLAB}_MINALIGN definitions to asm/cache.h

2023-06-13 Thread Catalin Marinas
The microblaze architecture defines ARCH_DMA_MINALIGN in asm/page.h. Move it to asm/cache.h to allow a generic ARCH_DMA_MINALIGN definition in linux/cache.h without redefine errors/warnings. While at it, also move ARCH_SLAB_MINALIGN to asm/cache.h for consistency. Signed-off-by: Catalin Marinas

[PATCH 3/3] sh: Move the ARCH_DMA_MINALIGN definition to asm/cache.h

2023-06-13 Thread Catalin Marinas
The sh architecture defines ARCH_DMA_MINALIGN in asm/page.h. Move it to asm/cache.h to allow a generic ARCH_DMA_MINALIGN definition in linux/cache.h without redefine errors/warnings. Signed-off-by: Catalin Marinas Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc:

[PATCH 1/3] powerpc: Move the ARCH_DMA_MINALIGN definition to asm/cache.h

2023-06-13 Thread Catalin Marinas
The powerpc architecture defines ARCH_DMA_MINALIGN in asm/page_32.h and only if CONFIG_NOT_COHERENT_CACHE is enabled (32-bit platforms only). Move this macro to asm/cache.h to allow a generic ARCH_DMA_MINALIGN definition in linux/cache.h without redefine errors/warnings. Signed-off-by: Catalin

[PATCH 0/3] Move the ARCH_DMA_MINALIGN definition to asm/cache.h

2023-06-13 Thread Catalin Marinas
Hi, The ARCH_KMALLOC_MINALIGN reduction series defines a generic ARCH_DMA_MINALIGN in linux/cache.h: https://lore.kernel.org/r/20230612153201.554742-2-catalin.mari...@arm.com/ Unfortunately, this causes a duplicate definition warning for microblaze, powerpc (32-bit only) and sh as these

Re: linux-next: build failure after merge of the mm tree

2023-06-13 Thread Catalin Marinas
Hi Stephen, On Tue, Jun 13, 2023 at 04:21:19PM +1000, Stephen Rothwell wrote: > After merging the mm tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > In file included from arch/powerpc/include/asm/page.h:247, > from

Re: [PATCH v14 00/15] phy: Add support for Lynx 10G SerDes

2023-06-13 Thread Vladimir Oltean
On Mon, Jun 12, 2023 at 04:46:16PM -0400, Sean Anderson wrote: > On 6/12/23 12:33, Vladimir Oltean wrote: > > On Mon, Jun 12, 2023 at 10:35:21AM -0400, Sean Anderson wrote: > >> > And if SERDES protocol switching was not physically possible, would this > >> > patch set still have value? > > More

Re: [PATCH 4/4] powerpc/64s: Use POWER10 stsync barrier for wmb()

2023-06-13 Thread Michael Ellerman
Nicholas Piggin writes: > The most expensive ordering for hwsync to provide is the store-load > barrier, because all prior stores have to be drained to the caches > before subsequent instructions can complete. > > stsync just orders stores which means it can just be a barrer that > goes down the

Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()

2023-06-13 Thread Michael Ellerman
Uwe Kleine-König writes: > On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-König wrote: >> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() >> call-back type"), all drivers being converted to .probe_new() and then >> 03c835f498b5 ("i2c: Switch .probe() to not take an id

Re: [PATCH v2 15/23] s390: allow pte_offset_map_lock() to fail

2023-06-13 Thread Claudio Imbrenda
On Thu, 8 Jun 2023 12:27:22 -0700 (PDT) Hugh Dickins wrote: > In rare transient cases, not yet made possible, pte_offset_map() and > pte_offset_map_lock() may not find a page table: handle appropriately. > > Add comment on mm's contract with s390 above __zap_zero_pages(), > and fix old comment

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Geert Uytterhoeven
On Tue, Jun 13, 2023 at 2:13 AM Rick Edgecombe wrote: > The x86 Shadow stack feature includes a new type of memory called shadow > stack. This shadow stack memory has some unusual properties, which requires > some core mm changes to function properly. > > One of these unusual properties is that

Re: [PATCH v4 25/34] m68k: Convert various functions to use ptdescs

2023-06-13 Thread Geert Uytterhoeven
On Mon, Jun 12, 2023 at 11:05 PM Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to

Re: [PATCH] powerpc: Switch i2c drivers back to use .probe()

2023-06-13 Thread Uwe Kleine-König
Hello, On Thu, May 25, 2023 at 10:56:22PM +0200, Uwe Kleine-König wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > convert back

Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()

2023-06-13 Thread Uwe Kleine-König
Hello, On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-König wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back

linux-next: build failure after merge of the mm tree

2023-06-13 Thread Stephen Rothwell
Hi all, After merging the mm tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: In file included from arch/powerpc/include/asm/page.h:247, from arch/powerpc/include/asm/thread_info.h:13, from include/linux/thread_info.h:60,

Re: [PATCH] powerpc/xmon: Fix comparing pointer

2023-06-13 Thread Christophe Leroy
Le 13/06/2023 à 05:38, wuyonggang...@208suo.com a écrit : > > > Fix the following coccicheck warning: > > arch/powerpc/xmon/spu-dis.c:51:34-35: WARNING comparing pointer to 0 Please send text messages, not html. And please check your patch, a lot of lines have no modifications but