https://github.com/asb approved this pull request.
https://github.com/llvm/llvm-project/pull/92143
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
asb wrote:
My thoughts:
* Thanks to @negge and others for clarifying who this is affecting and how
* It's very unfortunate we've broken some use cases here. Though as, by my
understand, this is affecting people using internal flags as opposed to
documented top-level flags I feel there's not a
https://github.com/asb commented:
Probably best reviewed by someone who has more familiarity with
RISCVTargetDefEmitter, but I took a look anyway.
I think this direction is OK, though I can't help but feel moving from the ISA
naming strings to the more verbose listing of features is a bit of
@@ -51,6 +51,14 @@ def Feature64Bit
def FeatureDummy
: SubtargetFeature<"dummy", "Dummy", "true", "Dummy">;
+class RISCVProfile features>
+: SubtargetFeature;
+
+def RVI20U32 : RISCVProfile<"rvi20u32", [Feature32Bit, FeatureStdExtI]>;
+def RVI20U64 :
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/90187
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asb approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/87376
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
asb wrote:
Thanks for splitting this out. The changes look good to me, but could you
please add a brief release note to llvm/docs/ReleaseNotes? Perhaps something
like "The default [atomics
mapping](https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-atomic.adoc)
was
https://github.com/asb approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/82322
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asb approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/81568
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asb approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/81905
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asb approved this pull request.
In case it's helpful, explicit LGTM from me on backporting this.
@preames looks like you need to rebase
https://github.com/llvm/llvm-project/pull/80238
___
llvm-branch-commits mailing list
asb wrote:
The proposed formatting change is undesired. `main` has this section of code
bracketed by `// clang-format off` and on. It doesn't seem worth cherry-picking
that too for this backport, but I can if wanted.
https://github.com/llvm/llvm-project/pull/80018
asb wrote:
This patch came after the branch, but really it's cleaning up something we
should have done a while ago once the extension was ratified at the end of last
year.
https://github.com/llvm/llvm-project/pull/80018
___
llvm-branch-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/80018
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/80018
The Zicond extension was ratified in the last few months, with no changes that
affect the LLVM implementation. Although there's surely more tuning that could
be done about when to select Zicond or not, there are no
https://github.com/asb milestoned
https://github.com/llvm/llvm-project/pull/80018
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: Alex Bradbury
Date: 2023-03-06T20:41:28Z
New Revision: ae37edf1486d35ac6f441c5ff489ab46a94e125e
URL:
https://github.com/llvm/llvm-project/commit/ae37edf1486d35ac6f441c5ff489ab46a94e125e
DIFF:
https://github.com/llvm/llvm-project/commit/ae37edf1486d35ac6f441c5ff489ab46a94e125e.diff
Author: Alex Bradbury
Date: 2022-09-05T10:48:03+01:00
New Revision: 4ba6a9c9f65bbc8bd06e3652cb20fd4dfc846137
URL:
https://github.com/llvm/llvm-project/commit/4ba6a9c9f65bbc8bd06e3652cb20fd4dfc846137
DIFF:
https://github.com/llvm/llvm-project/commit/4ba6a9c9f65bbc8bd06e3652cb20fd4dfc846137.diff
Author: Alex Bradbury
Date: 2022-03-07T10:58:20Z
New Revision: 9d54fe21c67fdb76bfd95c329a31bda2cb91c520
URL:
https://github.com/llvm/llvm-project/commit/9d54fe21c67fdb76bfd95c329a31bda2cb91c520
DIFF:
https://github.com/llvm/llvm-project/commit/9d54fe21c67fdb76bfd95c329a31bda2cb91c520.diff
Author: Alex Bradbury
Date: 2020-09-05T13:26:44+01:00
New Revision: 7030fc50d93e5b08bde9743fb54f24c4a44a8e4a
URL:
https://github.com/llvm/llvm-project/commit/7030fc50d93e5b08bde9743fb54f24c4a44a8e4a
DIFF:
https://github.com/llvm/llvm-project/commit/7030fc50d93e5b08bde9743fb54f24c4a44a8e4a.diff
20 matches
Mail list logo