Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: Hi all, This webrev adds support for JSR 292 to Zero: http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: +// NB the x86 code for this (in methodHandles_x86.cpp, search for +//

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 5, 2011, at 2:49 PM, Christian Thalinger wrote: Does this code pass the jtreg tests in jdk/test/java/lang/invoke/ ? It passed their previous incarnation in jdk/test/java/dyn, with this webrev applied to stop the tests disabling themselves:

Re: Review Request: Zero JSR 292 support

2011-04-11 Thread Gary Benson
Christian Thalinger wrote: On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: John Rose wrote: On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: This webrev adds support for JSR 292 to Zero:

Re: Review Request: Zero JSR 292 support

2011-04-11 Thread Christian Thalinger
On Apr 11, 2011, at 3:16 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: John Rose wrote: On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: This webrev adds support for

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: John Rose wrote: On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: This webrev adds support for JSR 292 to Zero: http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ Most impressive! I think this

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: This webrev adds support for JSR 292 to Zero: http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: +// NB the x86 code for this (in methodHandles_x86.cpp,

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: Christian Thalinger wrote: hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: + assert(false, Should have thrown incompatible class change exception); I'd use ShouldNotReachHere

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: Christian Thalinger wrote: hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: + assert(false, Should have thrown incompatible class change exception);

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: Christian Thalinger wrote: hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: + assert(false, Should have