Re: Does unicorn waits after_work to consider a worker ready?

2014-05-04 Thread Bráulio Bhavamitra
Thanks very much Eric. Just looked at the Unicorn's source code and the answer to the subject's question is yes. Also, I have made the configuration a little shorter, and made worker killer optional: https://gist.github.com/brauliobo/11298486 regards, bráulio On Fri, May 2, 2014 at 8:43 PM,

Re: Does unicorn waits after_work to consider a worker ready?

2014-05-02 Thread Eric Wong
Bráulio Bhavamitra brau...@eita.org.br wrote: That's the ruby design, as the heap only grows, so with a request that loads a lot of data the heap will grow big and never shrink. http://izumi.plan99.net/blog/index.php/2007/10/12/how-the-ruby-heap-is-implemented/ That's ancient, I was waiting

Re: Does unicorn waits after_work to consider a worker ready?

2014-05-01 Thread Bráulio Bhavamitra
On Thu, May 1, 2014 at 3:18 PM, Eric Wong normalper...@yhbt.net wrote: Bráulio Bhavamitra brau...@eita.org.br wrote: On Wed, Apr 30, 2014 at 10:33 PM, Eric Wong normalper...@yhbt.net wrote: You do not need to sleep before warmup. Warm up requests are expensive. This sleep based on worker.nr

Does unicorn waits after_work to consider a worker ready?

2014-04-30 Thread Bráulio Bhavamitra
Hello all, I had to use `sleep` (see https://gist.github.com/brauliobo/11298486) to make rolling restart on my unicorn configuration. But I'm worried if unicorn consider the worker ready for request even before after_fork finishes. Could you say if that is true? regards, bráulio -- Lute pela

Re: Does unicorn waits after_work to consider a worker ready?

2014-04-30 Thread Eric Wong
Bráulio Bhavamitra brau...@eita.org.br wrote: Hello all, I had to use `sleep` (see https://gist.github.com/brauliobo/11298486) to make rolling restart on my unicorn configuration. Btw, rack 1.6 (when released) should have a native warmup method thanks to Aman. It's currently in rack.git.