Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]

2023-10-23 Thread Michael McMahon
On Mon, 23 Oct 2023 14:29:59 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]

2023-10-23 Thread Aleksei Efimov
On Mon, 23 Oct 2023 14:29:59 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]

2023-10-23 Thread Daniel Fuchs
On Mon, 23 Oct 2023 14:26:50 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]

2023-10-23 Thread Daniel Jeliński
> This patch fixes the encoding of IPv6 addresses in the URI provided to > ProxySelector. > > The original code percent-encoded the square brackets added around the IPv6 > addresses, producing URIs that could not be parsed correctly. > > The proposed code does not percent-encode the IPv6

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-23 Thread Daniel Jeliński
On Fri, 20 Oct 2023 12:00:51 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]

2023-10-23 Thread Jaikiran Pai
On Mon, 23 Oct 2023 14:26:50 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-23 Thread Daniel Jeliński
On Mon, 23 Oct 2023 12:24:19 GMT, Jaikiran Pai wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove redundant checks > > src/java.base/share/classes/java/net/SocksSocketImpl.java line 307: > >> 305:

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-23 Thread Jaikiran Pai
On Fri, 20 Oct 2023 12:00:51 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-23 Thread Daniel Fuchs
On Fri, 20 Oct 2023 12:00:51 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-23 Thread Jaikiran Pai
On Fri, 20 Oct 2023 12:00:51 GMT, Daniel Jeliński wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

2023-10-20 Thread Daniel Jeliński
> This patch fixes the encoding of IPv6 addresses in the URI provided to > ProxySelector. > > The original code percent-encoded the square brackets added around the IPv6 > addresses, producing URIs that could not be parsed correctly. > > The proposed code does not percent-encode the IPv6

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Daniel Jeliński
On Fri, 20 Oct 2023 09:43:20 GMT, Michael McMahon wrote: >> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Michael McMahon
On Thu, 19 Oct 2023 12:10:02 GMT, Daniel Jeliński wrote: > This patch fixes the encoding of IPv6 addresses in the URI provided to > ProxySelector. > > The original code percent-encoded the square brackets added around the IPv6 > addresses, producing URIs that could not be parsed correctly. >

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Daniel Jeliński
On Fri, 20 Oct 2023 08:37:33 GMT, Alan Bateman wrote: > why ProxySelector loads sun.net.spi.DefaultProxySelector reflectively. Yeah, I was curious about that too; as far as I can tell, this won't prevent a class loader deadlock, and I can't think of any other reason. I can file a PR to

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Alan Bateman
On Fri, 20 Oct 2023 08:03:01 GMT, Daniel Jeliński wrote: > ProxySelector.getDefault may return null if someone explicitly calls > ProxySelector.setDefault(null); otherwise it's initialized to an instance of > DefaultProxySelector Right, I guess part of my puzzlement is to understand why

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Daniel Jeliński
On Thu, 19 Oct 2023 12:10:02 GMT, Daniel Jeliński wrote: > This patch fixes the encoding of IPv6 addresses in the URI provided to > ProxySelector. > > The original code percent-encoded the square brackets added around the IPv6 > addresses, producing URIs that could not be parsed correctly. >

Re: RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Alan Bateman
On Thu, 19 Oct 2023 12:10:02 GMT, Daniel Jeliński wrote: > This patch fixes the encoding of IPv6 addresses in the URI provided to > ProxySelector. > > The original code percent-encoded the square brackets added around the IPv6 > addresses, producing URIs that could not be parsed correctly. >

RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses

2023-10-20 Thread Daniel Jeliński
This patch fixes the encoding of IPv6 addresses in the URI provided to ProxySelector. The original code percent-encoded the square brackets added around the IPv6 addresses, producing URIs that could not be parsed correctly. The proposed code does not percent-encode the IPv6 addresses at all.