Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

2024-04-05 Thread Jaikiran Pai
On Fri, 5 Apr 2024 12:42:04 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/net/ServerSocket.java line 264: >> >>> 262: * 0 and 65535, inclusive. >>> 263: * >>> 264: * @see StandardSocketOptions >> >> What would you think about dropping this link, and

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

2024-04-05 Thread Jaikiran Pai
On Fri, 5 Apr 2024 12:19:13 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove repeated usages of {@link} > > src/java.base/share/classes/java/net/ServerSocket.java line 264: > >> 262:

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

2024-04-05 Thread Alan Bateman
On Fri, 5 Apr 2024 12:06:21 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only changes to java.net.ServerSocket >> and java.net.Socket classes? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes >> currently refer to the legacy

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

2024-04-05 Thread Jaikiran Pai
> Can I please get a review of this doc-only changes to java.net.ServerSocket > and java.net.Socket classes? > > As noted in https://bugs.openjdk.org/browse/JDK-8329745, these classes > currently refer to the legacy `java.net.SocketOptions` interface and instead > should be refering to the

Re: RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

2024-04-05 Thread Jaikiran Pai
On Fri, 5 Apr 2024 11:29:14 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/net/ServerSocket.java line 867: >> >>> 865: * setting of {@link StandardSocketOptions#SO_REUSEADDR >>> SO_REUSEADDR}. >>> 866: * >>> 867: * The behaviour when {@link