[PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread ggrundstrom
Main include file for device structures and defines. Signed-off-by: Glenn Grundstrom [EMAIL PROTECTED] --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes.h 2007-10-19 09:59:12.0 -0500 @@ -0,0 +1,613 @@ +/* + * Copyright (c) 2006

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Stephen Hemminger
On Fri, 19 Oct 2007 15:04:08 -0500 [EMAIL PROTECTED] wrote: Main include file for device structures and defines. Signed-off-by: Glenn Grundstrom [EMAIL PROTECTED] You are starting off on the wrong foot. +#ifdef CONFIG_INFINIBAND_NES_DEBUG +#define assert(expr)

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Roland Dreier
You are starting off on the wrong foot. ??? +if(!(expr)) { \ + printk(KERN_ERR PFX Assertion failed! %s, %s, %s, line %d\n, \ + #expr, __FILE__, __FUNCTION__,

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Stephen Hemminger
On Fri, 19 Oct 2007 22:22:44 -0700 Roland Dreier [EMAIL PROTECTED] wrote: You are starting off on the wrong foot. ??? That was a introductory comment because even in reviewing the first file (which had almost no code), I saw so many style issues. +if(!(expr)) {