Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-27 Thread Arnd Bergmann
On Thu, Jul 27, 2017 at 11:00 AM, Sathya Perla wrote: > On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote: > [...] >> >> On today's linux-next: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function >> `bnxt_dl_register': >>

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-27 Thread Sathya Perla
On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote: [...] > > On today's linux-next: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': > bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' > bnxt_vfr.c:(.text+0x14c0): undefined

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-27 Thread Arnd Bergmann
On Wed, Jul 26, 2017 at 3:18 PM, Arnd Bergmann wrote: > On Wed, Jul 26, 2017 at 12:54 PM, Sathya Perla > wrote: >> On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: >> [...] Sathya already sent 3 patches to fix some of these

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-26 Thread Arnd Bergmann
On Wed, Jul 26, 2017 at 12:54 PM, Sathya Perla wrote: > On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: > [...] >>> Sathya already sent 3 patches to fix some of these issues. But I need >>> to rework one of his patch and resend. >> >> Ok, thanks.

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-26 Thread Sathya Perla
On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: [...] >> Sathya already sent 3 patches to fix some of these issues. But I need >> to rework one of his patch and resend. > > Ok, thanks. I just ran into one more issue, and don't know if that's included > as well. If not,

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-26 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 6:36 PM, Michael Chan wrote: > On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote: >> The sriov_lock is used to serialize the sriov code with the vfr code. >> However, when SRIOV is disabled, the lock is not there at all,

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-25 Thread Michael Chan
On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote: > The sriov_lock is used to serialize the sriov code with the vfr code. > However, when SRIOV is disabled, the lock is not there at all, leading > to a build error: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function

[PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-25 Thread Arnd Bergmann
The sriov_lock is used to serialize the sriov code with the vfr code. However, when SRIOV is disabled, the lock is not there at all, leading to a build error: drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function 'bnxt_dl_eswitch_mode_set':