Hey Andy and others,
from my perspective as an application developer, I would look for
providing an abstract but robust implementation that would allow anyone
to implement such a concrete rich text field without any roadblocks.
Maybe even going as far as going for a more abstract
I'm speaking from ignorance, but in the same way that java 2d lets you do
image reading and writing with great tools to implement it, but it also
provides defaults for png, gif, jpeg, etc.
A good foundation to build your own is critical. But it does not obviate
the need for a useful default.
On
Hi,
Far be it from me to tell the FX team what it should do, I am still
wondering the following:
- A 3rd party control, RichTextFX already exists -- what is this new
proposal adding that RichTextFX does not have?
- What (if anything) is stopping a 3rd party from building a
RichTextArea
On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev wrote:
> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
> two methods:
> - public ObservableMap getProperties();
> - public boolean hasProperties();
>
> 2. Node, MenuItem, and Toggle now extend ContainsProperties
On Thu, 22 Feb 2024 23:18:46 GMT, Marius Hanl wrote:
> maybe it's time to setup a VM on my Windows machine. Are there any
> recommendations I may should follow for the setup? :-)
I don't know of any supported way to run macOS in a VM on a Windows host, but
perhaps others will be able to help.
On Thu, 22 Feb 2024 23:11:55 GMT, Nir Lisker wrote:
>> The only thing I can point at is the OCA (which is linked in the CONTRIBUTOR
>> guidelines), which states that contributions need to be an original work.
>>
>> So to double-check: Aside from that image (and the ones derived from it),
>>
On Thu, 22 Feb 2024 15:41:55 GMT, Kevin Rushforth wrote:
> @Maran23 I see from the description that you tested this on mac. How did you
> test it? Did you run with `-PFULL_TEST=true`?
No, I checked the example in the ticket as well as the handling of dialogs in
general on Mac.
Unfortuantely,
On Thu, 22 Feb 2024 23:04:50 GMT, Nir Lisker wrote:
>> StringJoiner seems to provide little benefit for maps or key=value pairs.
>> Do you know of an alternative?
>
> A `StringJoiner` seems suitable to me in this case:
>
> new StringJoiner(",", "PhongMaterial[", "]")
>
On Thu, 22 Feb 2024 23:07:21 GMT, Kevin Rushforth wrote:
>> Perhaps the contribution guidelines should mention what resources can be
>> included. In all other open source projects I worked on it was enough that
>> the resource wasn't licensed (or had something like
>>
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and
On Thu, 22 Feb 2024 22:51:56 GMT, Nir Lisker wrote:
>> sorry, Nir. ;-)
>
> Perhaps the contribution guidelines should mention what resources can be
> included. In all other open source projects I worked on it was enough that
> the resource wasn't licensed (or had something like
>
On Thu, 22 Feb 2024 22:50:06 GMT, Andy Goryachev wrote:
>>> also, the first `+` is unnecessary
>>
>> I think it was done for uniformity with the other properties. I would use a
>> `StringJoiner` these days for such a task anyway.
>
> StringJoiner seems to provide little benefit for maps or
On Thu, 22 Feb 2024 22:44:05 GMT, Nir Lisker wrote:
>> Weird, I specifically reverted the auto-formatting, not sure how it got in.
>> Will revert.
>
>> also, the first `+` is unnecessary
>
> I think it was done for uniformity with the other properties. I would use a
> `StringJoiner` these
On Thu, 22 Feb 2024 22:42:18 GMT, Andy Goryachev wrote:
>> OK, it will be after the weekend when I can come back to this. Reviewers can
>> assume that only the background will change.
>
> sorry, Nir. ;-)
Perhaps the contribution guidelines should mention what resources can be
included. In
On Thu, 22 Feb 2024 22:20:56 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
>> line 848:
>>
>>> 846: + ", specularPower=" + getSpecularPower() + ",
>>> diffuseMap=" + getDiffuseMap() + ", specularMap="
>>> 847:
On Thu, 22 Feb 2024 22:40:59 GMT, Nir Lisker wrote:
>> All of them, since they were derived from the original. I can still tell
>> what the source is.
>
> OK, it will be after the weekend when I can come back to this. Reviewers can
> assume that only the background will change.
sorry, Nir.
On Thu, 22 Feb 2024 22:36:06 GMT, Kevin Rushforth wrote:
>> Do I only need to switch the ones in the introduction that show the
>> multiplication of the color and the map, or all of the new images that use
>> it as a background? The latter will be a lot of work.
>
> All of them, since they
On Thu, 22 Feb 2024 22:31:59 GMT, Nir Lisker wrote:
>> To add to this, such approval would be unlikely, and I am not in favor of
>> making the request. Perhaps you can find suitable images already in the
>> repo? Here is one that might work:
>>
>>
On Thu, 22 Feb 2024 22:21:49 GMT, Kevin Rushforth wrote:
>> What would an approval require?
>
> To add to this, such approval would be unlikely, and I am not in favor of
> making the request. Perhaps you can find suitable images already in the repo?
> Here is one that might work:
>
>
Something like this might be reasonable as long as we also add "and
hasn't been modified in the current release". I could easily image the
case where an incubating feature goes into, say JavaFX 26 in March, and
by the time feedback comes in that prompts a change in the API, it's
July or August
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Thu, 22 Feb 2024 22:18:38 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
> line 848:
>
On Thu, 22 Feb 2024 22:19:27 GMT, Nir Lisker wrote:
>> But it's still third-party content and cannot go in without approval.
>
> What would an approval require?
To add to this, such approval would be unlikely, and I am not in favor of
making the request. Perhaps you can find suitable images
On Thu, 22 Feb 2024 22:17:27 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Thu, 22 Feb 2024 22:13:33 GMT, Kevin Rushforth wrote:
>> No, it's a standard in image processing: https://en.wikipedia.org/wiki/Lenna.
>
> But it's still third-party content and cannot go in without approval.
What would an approval require?
-
PR Review Comment:
On Thu, 22 Feb 2024 22:10:35 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/paint/doc-files/color and
>> map/map.png line 1:
>>
>>> (failed to retrieve contents of file, check the PR for context)
>> Is this a licensed image?
>
> No, it's a standard in image
On Thu, 22 Feb 2024 20:49:20 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/docs/javafx/scene/paint/doc-files/color and
> map/map.png
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
>
W.r.t to (3) perhaps we could include in the write up an expectation
that continued incubation implies continued updates.
Meaning if there are no updates in a release then that either means it
is ready to be final next time round, or that the
author is no longer actively pursuing it and this
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
>
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
>
Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
`Material`). Except for the introduction, I divided the documentation into 3
sections: qualitative explanation, mathematical model (I wouldn't think it
necessary, but the current doc explains it), and examples.
The
Dear Daniel:
Thank you for your kind words!
Re: StyledTextArea/TextField.
This is a very interesting question. It is definitely out of scope right now,
but we can certainly talk about it.
One major difference between the new control and the regular TextField/TextArea
is that we add a
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every
On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox wrote:
> Turning on warnings-as-errors for the macOS glass native code. Deprecated
> declarations are excluded and still appear as warnings.
>
> In the code that tries to locate the application's dock icon there were three
> instances where `NO` was
On Mon, 19 Feb 2024 11:45:04 GMT, Thiago Milczarek Sayao
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add compile-time checks to GdkSeat
>
> The rationale was:
>
> This tells which events get delivered to the
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote:
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
Hi Andy, others,
I highly appreciate and welcome the effort of a built-in RichTextArea .
A question that popped up in my mind is whether this work might include
work in the area of *rich* TextField also? Probably it is out of scope.
Anyhow, JavaFX Textfields are used in even more areas in UI
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where
Hi all,
This pull request contains a clean backport of commit
[ab68b716](https://github.com/openjdk/jfx/commit/ab68b716fbfd807918ca4a1bc096dcf40d9cfcbd)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Jose Pereda on 21 Dec 2023 and
Hi,
This possible bug is reported here:
https://bugs.openjdk.org/browse/JDK-8322251
Running the code bellow produces incorrect text on Ubuntu 24.04 (still not
released). I would like to fix it, but some hints would be appreciated.
I might be missing a font, but the same text render fine on GTK
On Tue, 20 Feb 2024 15:48:26 GMT, Andy Goryachev wrote:
>> I see that the tests don't run on all the platforms. I will look into this
>> and update the PR
>
> A valid concern about specific fonts, similar to
> https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
>
> What was the
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Tue, 20 Feb 2024 10:18:36 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The
On Tue, 20 Feb 2024 10:18:36 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The
49 matches
Mail list logo
