On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds
> This change brings the number of javadoc warnings back to 91 (to be fixed in
> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>
> - adds missing information in `@param` tags
> - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the
> warning due to
On Thu, 29 Feb 2024 00:07:37 GMT, Kevin Rushforth wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote:
> This change brings the number of javadoc warnings back to 91 (to be fixed in
> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>
> - adds missing information in `@param` tags
> - adds `@SuppressWarnings("doclint:missing")`
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
> classes that generated javadoc's "missing comments" warning.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
On Thu, 29 Feb 2024 18:39:03 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Thu, 29 Feb 2024 18:39:03 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote:
> This change brings the number of javadoc warnings back to 91 (to be fixed in
> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>
> - adds missing information in `@param` tags
> - adds `@SuppressWarnings("doclint:missing")`
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> It is important to note that even though the constraints are given by the
> user in unsnapped coordinates, they are converted to snapped
On Wed, 14 Feb 2024 20:53:46 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java
>> line 421:
>>
>>> 419: if (oldIndex == newIndex) {
>>> 420: if (!isItemChanged(oldValue, newValue)) {
>>> 421:
On Sat, 24 Feb 2024 17:38:11 GMT, Marius Hanl wrote:
>> `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all
>> other implementations of the cell.
>>
>> This also means that the `TreeTableRow` always updates the item, although it
>> should not, resulting in a
On Thu, 29 Feb 2024 17:27:28 GMT, John Hendrikx wrote:
> Arial is one of the most available fonts across platforms.
No it is not, as we can see from
https://github.com/openjdk/jfx/pull/1236#issuecomment-1939005318
so perhaps we check and pick an alternative if Arial is not present? What is
On Thu, 29 Feb 2024 17:24:53 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> missing
>
> modules/javafx.base/src/main/java/javafx/event/Event.java line 45:
>
>> 43: */
>> 44:
On Thu, 29 Feb 2024 17:33:14 GMT, John Hendrikx wrote:
>> @hjohn how do you get this coverage diagram?
>>
>> The BreakIterator is a part of the existing code, we should probably have
>> this discussion outside of this PR. I agree, there might be a situation
>> when the app wants to select a
> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
> classes that generated javadoc's "missing comments" warning.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
missing
-
Changes:
- all:
On Thu, 29 Feb 2024 15:59:58 GMT, Andy Goryachev wrote:
>> I disagree on this. The code is complicated and full of branches. Manual
>> testing is very error prone. However, since you restored most of the code
>> to its original (which wasn't tested either) I could live with it. Still,
>>
On Thu, 29 Feb 2024 16:53:26 GMT, Andy Goryachev wrote:
> Adding `@SuppressWarnings("doclint")` to Serializable classes to silence the
> javadoc "missing comments" warning.
> (There is no javadoc command group for serialization like doclint:missing)
>
> Pros:
> - the classes are fairly
On Thu, 29 Feb 2024 15:49:47 GMT, Andy Goryachev wrote:
> > FontHelper.getNativeFont(
>
> perhaps we could pick a suitable font based on the platform? to make sure we
> always get a valid font?
The points tested will be specific to the font used, similar to the problems
with the #1236 PR.
Adding `@SuppressWarnings("doclint")` to Serializable classes to silence the
javadoc "missing comments" warning.
(There is no javadoc command group for serialization like doclint:missing)
Pros:
- the classes are fairly stable, we can ask the reviewers to pay extra
attention to any javadoc
On Thu, 29 Feb 2024 16:09:47 GMT, Jayathirth D V wrote:
> This is 22u backport for updating libjpeg version to 9f.
> Original bug : https://bugs.openjdk.org/browse/JDK-8324233
This pull request has now been integrated.
Changeset: e54102ca
Author:Jayathirth D V
Committer: Kevin Rushforth
This is 22u backport for updating libjpeg version to 9f.
Original bug : https://bugs.openjdk.org/browse/JDK-8324233
-
Commit messages:
- Backport b99eb45828317e4c195b46eb0c9371d4645f2c6c
Changes: https://git.openjdk.org/jfx22u/pull/15/files
Webrev:
On Thu, 29 Feb 2024 13:23:40 GMT, John Hendrikx wrote:
>> I believe the tests added in this PR are helpful in making sure that the
>> HitInfo calculation does not give results like character index less than 0
>> or character index greater than total length of the text or out of bound
>>
Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel
from IME calls on macOS
Reviewed-by: jbhaskar, arapte
-
Commit messages:
- 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
Changes:
On Thu, 29 Feb 2024 05:38:05 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation
On Tue, 20 Feb 2024 05:50:19 GMT, Jayathirth D V wrote:
> IJG has released latest version of libjpeg 9f and we need to update our
> version also match 9f changes.
> IJG reference : https://www.ijg.org/
>
> With updated changes both headless and headful tests are green on all
> platforms.
>
>
On Tue, 27 Feb 2024 10:00:41 GMT, Karthik P K wrote:
>> I'm not sure if we could write headless test for this. Could you please
>> point me to a test which could be helpful for me?
>
> I believe the tests added in this PR are helpful in making sure that the
> HitInfo calculation does not give
On Thu, 29 Feb 2024 05:38:05 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation
On Thu, 29 Feb 2024 09:28:04 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Thu, 29 Feb 2024 11:46:11 GMT, Nir Lisker wrote:
> This pull request contains a backport of commit
> [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull request has now been
On Thu, 29 Feb 2024 11:46:11 GMT, Nir Lisker wrote:
> This pull request contains a backport of commit
> [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
Clean backport of doc-only fixed
On Tue, 27 Feb 2024 17:58:13 GMT, Anirvan Sarkar wrote:
> Replace Thread.currentThread().getId() with Thread.currentThread().threadId()
This pull request has now been integrated.
Changeset: 5512a5ad
Author:Anirvan Sarkar
Committer: John Hendrikx
URL:
This pull request contains a backport of commit
[d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport d9645730f1e76e95e0bb93ceaeb5550390bf95c1
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
>
On Thu, 29 Feb 2024 09:22:38 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The
On Thu, 29 Feb 2024 09:22:38 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The
On Thu, 29 Feb 2024 09:28:04 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
On Thu, 29 Feb 2024 06:21:34 GMT, Ambarish Rapte wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update
>
> modules/javafx.graphics/src/main/native-iio/libjpeg/UPDATING.txt line 12:
>
>> 10: 3) OpenJFX imports
> IJG has released latest version of libjpeg 9f and we need to update our
> version also match 9f changes.
> IJG reference : https://www.ijg.org/
>
> With updated changes both headless and headful tests are green on all
> platforms.
>
> Also while updating to 9f noticed that many files don't
Hi all,
This pull request contains a clean backport of commit
[40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Kevin Rushforth on 30 Jan 2024
On Wed, 28 Feb 2024 05:19:06 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
Hi Krishna,
Usually these are caused by doing something on the wrong thread in my
experience. In our application we've had to be very careful about doing
things on the right thread. Mostly it's fine to create things off the app
thread and add them on the app thread, but that's not always the
44 matches
Mail list logo
