Hi there,
Thank you Robert for your feedback! As a fellow application and custom
component developer, I can't wait for this feature to get in.
I wonder if anyone else have any objections or feedback, specifically John
Hendrikx and Martin Fox. I hope the new proposal addresses the concerns
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp
On Thu, 25 Apr 2024 20:09:53 GMT, Carl Christian Snethlage
wrote:
> Tried on my local machine (win10) w/o patch with narrator:
Thank you for checking this out!
so you see the windows cursor decouple from the narrator focus rectangle? And
when you press left/right, the narrator focus does
On Thu, 25 Apr 2024 19:54:37 GMT, Oliver Kopp wrote:
> ... and no luck with Eclipse ...
I assume you imported the whole jfx repository into Eclipse as a gradle build
as described here
https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse
If not, you could still use
On Thu, 25 Apr 2024 19:28:47 GMT, Phil Race wrote:
> Backport to jfx22u
This pull request has now been integrated.
Changeset: 77e7e251
Author:Phil Race
URL:
https://git.openjdk.org/jfx22u/commit/77e7e2514c25fa5f653938a6d0cbd4b1b6abe74f
Stats: 7 lines in 1 file changed: 4 ins; 0
On Thu, 25 Apr 2024 19:39:02 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 25 Apr 2024 19:39:02 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp
Backport to jfx22u
-
Commit messages:
- Backport 5182ea16ace78c4f61e2c38981aab62f6153294e
Changes: https://git.openjdk.org/jfx22u/pull/27/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u=27=00
Issue: https://bugs.openjdk.org/browse/JDK-8322251
Stats: 7 lines in 1 file
On Thu, 25 Apr 2024 18:03:17 GMT, Andy Goryachev wrote:
> focus rectangle follows the windows cursor and announces the letter at the
> cursor.
I did not change branches, but downloaded a binary from the net.
I type "abcdef" in the text field and then press cursor left - no change of the
On Thu, 25 Apr 2024 06:37:00 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 25 Apr 2024 15:37:09 GMT, Andy Goryachev wrote:
> Nope, this fix breaks Narrator.
I think, I do not get what Narrator is doing.
If I type "Testx" into a Text field, what should be highlighted?
On Thu, 25 Apr 2024 14:26:06 GMT, Karthik P K wrote:
> The text was not getting selected on adding the `TextField` to the scene
> initially, subsequently removing and adding the `TextField` to the scene
> selects the entire text present in the `TextField`.
>
> Made changes in the
On Thu, 25 Apr 2024 12:55:48 GMT, Oliver Kopp wrote:
> Can you help me
Sure! So I copied the test class (renamed, since we have another one with the
name of TextAreaTest to `tests\system\src\test\java\test\com\sun\glass\ui\win`,
same dir where WinTextRangeProviderTest.java resides. Here is
On Thu, 25 Apr 2024 06:49:24 GMT, Oliver Kopp wrote:
> I tested it with a JFX distribution without the fix. Also happens there.
Nope, this fix breaks Narrator. The window cursor is moving but the narrator
outlines the trailing 't' as Ambarish described.
(every time I change branches for the
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
The text was not getting selected on adding the `TextField` to the scene
initially, subsequently removing and adding the `TextField` to the scene
selects the entire text present in the `TextField`.
Made changes in the `TextFieldBehavior` constructor to select the text on
adding the
On Fri, 19 Apr 2024 14:42:23 GMT, Thiago Milczarek Sayao
wrote:
>> Wayland implementation will require EGL.
>>
>> EGL works with Xorg as well. The idea is to be EGL first and if it fails,
>> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available.
>>
>>
>> See:
>> [Switching
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Thu, 22 Feb 2024 17:16:42 GMT, n-gabe wrote:
> There is a ConcurrentModificationException in MediaPlayer when removing a
> MediaView from it. The root cause is that you can't iterate over a HashSet
> with for (WeakReference vref : viewRefs) and removing items from
> the collection by
On Fri, 19 Apr 2024 17:33:39 GMT, Andy Goryachev wrote:
>> I am new to testing in the JFX project. It seems that `test.` is required as
>> package prefix. Thus, I did not use the approach of package-private methods
>> and classes, but needed to make the class and the tested method public.
>>
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
Hi,
I did some more work on the JavaFX Headless platform that is available in
[1] and I am using it to run the systemtests. I am not yet running the
robot-based systemtests, but there is already some robot code in the
Headless platform.
The other systemtests are going pretty well. On my linux,
On Wed, 24 Apr 2024 15:28:30 GMT, Ambarish Rapte wrote:
> Windows Narrator reads only the last character of the Text in a TextArea,
> when moving the cursor, and the focus rect does not move with cursor.
I tested it with a JFX distribution without the fix. Also happens there. Can
you check,
On Wed, 24 Apr 2024 15:26:27 GMT, Kevin Rushforth wrote:
>> Interesting = @kevinrushforth what do you think?
>
> An excellent question. If it is robust, then it seems OK. Using Junit5
> Assumptions is more flexible, though, so might lean toward wanting to use
> that. Either way, test this on
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp
31 matches
Mail list logo
