Hi Krishna,
Usually these are caused by doing something on the wrong thread in my
experience. In our application we've had to be very careful about doing
things on the right thread. Mostly it's fine to create things off the app
thread and add them on the app thread, but that's not always the
On Thu, 16 Feb 2023 15:15:11 GMT, Dean Wookey wrote:
> Each time a menu would change scenes, a new set of ListChangeListeners would
> be added to the items in the menu. The bigger problem however is that these
> list change listeners have a strong reference to the scene which is
>
On Wed, 1 Mar 2023 13:36:46 GMT, Kevin Rushforth wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more comments and fixed IdentityWrapper hashcode.
>
> @arapte can you be the sec
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
TableView).
>
> I'm looking at these issues, but I think they're dependent on this fix.
> Either I can add to this PR or I can wait to see what comes out of this and
> fix them subsequently.
Dean Wookey has updated the pull request incrementally with one additional
commit since the last re
On Wed, 22 Feb 2023 19:31:29 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Wed, 22 Feb 2023 19:21:41 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Thu, 23 Feb 2023 09:26:29 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 285:
>>
>>> 283: }
>>> 284:
>>> 285: private static void removeAcceleratorsFromScene(List>> MenuItem> items, Scene scene) {
Each time a menu would change scenes, a new set of ListChangeListeners would be
added to the items in the menu. The bigger problem however is that these list
change listeners have a strong reference to the scene which is potentially a
much bigger leak.
The first commit was more
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButto
doesn't
> remove the additional instance.
>
> This pull request just removes the redundant code in the MenuButtonSkinBase.
Dean Wookey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commits:
- Implemented alternative
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
On Fri, 4 Nov 2022 19:51:53 GMT, Kevin Rushforth wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>>
On Mon, 7 Nov 2022 18:11:28 GMT, Dean Wookey wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java
>> line 154:
>>
>>> 152: sceneChangeListener = (scene, oldValue, newValue) -> {
>>> 153:
On Fri, 4 Nov 2022 21:14:20 GMT, Andy Goryachev wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added changing scene tests for accelerator change listeners
>
> modules/javafx.contr
doesn't
> remove the additional instance.
>
> This pull request just removes the redundant code in the MenuButtonSkinBase.
Dean Wookey has updated the pull request incrementally with one additional
commit since the last revision:
Added changing scene tests for accelerator chang
When menu buttons are added and removed from the scene, an accelerator change
listener is added to each menu item in the menu. There is nothing stopping the
same change listener being added multiple times.
MenuButtonSkinBase calls the
Hi Andrea,
You can have a look at this post to see if it helps you.
https://stackoverflow.com/a/7316/4489577
Dean
On Tue, Jul 12, 2022 at 10:59 AM Andrea Vacondio
wrote:
> Hello,
> can anyone point me or tell me the current support regarding JavaFX drag
> and drop of Outlook attachments?
20 matches
Mail list logo
