On Fri, 24 Feb 2023 09:23:59 GMT, Karthik P K wrote:
>>> I get the impression this code also needs to use `caretWidth / 2` instead
>>> of `0` and `1`.
>>>
>> Here also same comment as above for the `newX < caretWidth/2` condition. But
>> while comparing the `oldX`, `caretWidth/2` should be
On Thu, 23 Feb 2023 09:11:05 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Fri, 24 Feb 2023 06:20:22 GMT, Karthik P K wrote:
>> I would also recommend testing the code on Windows with the screen scale set
>> to 225%, as it might show issues related to fractional scale.
>
>> I get the impression this code also needs to use `caretWidth / 2` instead of
>> `0` and
On Fri, 24 Feb 2023 06:26:21 GMT, Karthik P K wrote:
> > I think this class may benefit from a few tests that test with a very wide
> > caret, to see if positioning is what you'd expect in those cases as well. I
> > get the impression a lot of the code assumes a narrow caret (1 or 2 pixels)
>
On Thu, 23 Feb 2023 16:29:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 805:
>>
>>> 803: // appear at the left of the centered prompt.
>>> 804: newX = midPoint -
>>>
On Thu, 23 Feb 2023 09:20:26 GMT, John Hendrikx wrote:
> I think this class may benefit from a few tests that test with a very wide
> caret, to see if positioning is what you'd expect in those cases as well. I
> get the impression a lot of the code assumes a narrow caret (1 or 2 pixels)
> and
On Thu, 23 Feb 2023 09:11:56 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Thu, 23 Feb 2023 16:34:11 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 818:
>>
>>> 816: } else if (newX < 0 && oldX > 1) {
>>> 817: textTranslateX.set(caretWidth / 2);
>>> 818:
On Thu, 23 Feb 2023 16:29:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 805:
>>
>>> 803: // appear at the left of the centered prompt.
>>> 804: newX = midPoint -
>>>
On Thu, 23 Feb 2023 08:52:19 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Thu, 23 Feb 2023 07:36:43 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
11 matches
Mail list logo
