On Tue, 27 Feb 2024 12:13:09 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
> line 170:
>
>> 168: *
On Tue, 27 Feb 2024 11:24:08 GMT, Ambarish Rapte wrote:
> PhongMaterial is not suitable for surfaces that reflect or refract the
> incident light.
But it does reflect the incident light as explained in the paragraphs before.
-
PR Review Comment:
On Tue, 27 Feb 2024 11:53:35 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
> line 115:
>
>> 113: *
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>