On Wed, 27 Mar 2024 21:22:47 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Whitespace?
build.gradle line 4049:
> 4047:
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
Looks like the line specified by
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Whitespace?
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new:
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
I added the application to the
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added gradle script
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new:
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte wrote:
> Executing the LightingSample manually fails with an exception
I think the package names of the main and resources weren't aligned.
> The copyright year new files should be 2024 only. Some new files have more
> than one copyright year.
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with five additional
commits since the last revision:
- Added spacing
- Renamed constant
- Updated benchmark reset message
- Simplified models creation
- Revert
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49:
>
>> 47:
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
copyright headers
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new:
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Undo files move
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new:
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
An observation out of scope of this PR.
The effect of lighting on mesh vs a box is quite different.
Notice the screenshot, left side is a Box and right side is Mesh, both
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
providing few more comments
tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49:
> 47: stopGraphic.setBoundsType(TextBoundsType.VISUAL);
>
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
Couple quick comments:
- Executing the LightingSample manually fails with an exception
Caused by: java.lang.NullPointerException: Input stream must not be null
at
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
Reviewer: @arapte
@jayathirthrao you might also want to take a look?
-
PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-1976604084
Update for the 3D lighting test tool as described in the JBS issue.
-
Commit messages:
- Whitespaces
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1387/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1387=00
Issue: https://bugs.openjdk.org/browse/JDK-8327179
18 matches
Mail list logo
