On Sun, 19 Feb 2023 18:29:16 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is
On Fri, 24 Feb 2023 22:28:08 GMT, Phil Race wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual test is
On Fri, 24 Feb 2023 22:23:18 GMT, Phil Race wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual test is
On Fri, 24 Feb 2023 22:03:59 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8290866
>
> tests/manual/text/EmojiTest.java line 54:
>
>> 52: transparent background pixels.
>> 53:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is provided which uses a Text node, Label control
> and
On Fri, 24 Feb 2023 19:58:50 GMT, Phil Race wrote:
>> or check for null again after synchronized(this)
>
> It doesn't matter, does it ? In that one in a million case we'd just build
> the tables twice.
OK
-
PR: https://git.openjdk.org/jfx/pull/1047
On Fri, 24 Feb 2023 21:21:54 GMT, Phil Race wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual test is
On Fri, 24 Feb 2023 21:21:54 GMT, Phil Race wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual test is
On Fri, 24 Feb 2023 21:35:49 GMT, Kevin Rushforth wrote:
> Merge `jfx20` branch into master.
This pull request has now been integrated.
Changeset: a9166295
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/a9166295861784fb95a0d104b704e72f658fbe0e
Stats: 59 lines in
Merge `jfx20` branch into master.
-
Commit messages:
- Merge jfx20
- 8301022: Video distortion is observed while playing youtube video
- 8173321: TableView: Click on right trough has no effect when cell height is
higher than viewport height
- 8090647: Mnemonics : on windows we
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is provided which uses a Text node, Label control
> and
On Fri, 24 Feb 2023 20:31:47 GMT, Phil Race wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual test is
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is provided which uses a Text node, Label control
> and
On Fri, 24 Feb 2023 19:28:49 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java
>> line 1456:
>>
>>> 1454:private boolean isSbixGlyph(int glyphID) {
>>> 1455:if (sbixStrikes == null) {
>>> 1456:synchronized (this)
On Fri, 24 Feb 2023 18:58:37 GMT, Kevin Rushforth wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual
On Fri, 24 Feb 2023 19:25:47 GMT, Andy Goryachev wrote:
> I think the condition to select one behavior or the other might be whether
> all the text fits in the visible area. If it does - use existing logic. If it
> does not - shift the text to the right.
Yes this approach can be used. But I
On Fri, 24 Feb 2023 19:17:08 GMT, Andy Goryachev wrote:
> > app works with no clipping on macOS 12.6.1
>
> clipping occurs on retina at any resolution, from "Larger Text" to "More
> Space". It might be specific to Ventura, and possibly to the flag emojis. I
> tried to paste random code
On Fri, 24 Feb 2023 19:06:59 GMT, Kevin Rushforth wrote:
>> This fix properly supports colour rendering of Emoji on macOS
>>
>>
>> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
>> if there is font
>> support for the requested code point.
>>
>> A simple manual
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is
On Fri, 24 Feb 2023 09:23:59 GMT, Karthik P K wrote:
>>> I get the impression this code also needs to use `caretWidth / 2` instead
>>> of `0` and `1`.
>>>
>> Here also same comment as above for the `newX < caretWidth/2` condition. But
>> while comparing the `oldX`, `caretWidth/2` should be
On Fri, 24 Feb 2023 06:33:04 GMT, Karthik P K wrote:
> Yes this behavior looks unnatural. I see this issue in the mainline as well.
I think the condition to select one behavior or the other might be whether all
the text fits in the visible area. If it does - use existing logic. If it
does
On Fri, 24 Feb 2023 19:10:23 GMT, Phil Race wrote:
> app works with no clipping on macOS 12.6.1
clipping occurs on retina at any resolution, from "Larger Text" to "More
Space". It might be specific to Ventura, and possibly to the flag emojis. I
tried to paste random code blocks, see no
On Fri, 24 Feb 2023 18:57:54 GMT, Andy Goryachev wrote:
> > So I suspect something specific to what you are doing in your test .. not a
> > general emoji problem.
>
> or specific to my Mac Ventura 13.1. In my test, i am setting the font
> explicitly. A simpler test clips the flag symbols on
On Thu, 23 Feb 2023 09:52:08 GMT, Dean Wookey wrote:
>> I'm not in favor of using `Private` in a method name. That is clear from the
>> method signature and overloading methods is a valid choice In my opinion,
>> this is fine as is.
>> But we could also think about naming it:
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Fri, 24 Feb 2023 09:49:33 GMT, Dean Wookey wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 366:
>>
>>> 364: public boolean equals(Object o) {
>>> 365: if (this == o) return true;
>>> 366: if
On Fri, 24 Feb 2023 18:48:20 GMT, Phil Race wrote:
> So I suspect something specific to what you are doing in your test .. not a
> general emoji problem.
or specific to my Mac Ventura 13.1. In my test, i am setting the font
explicitly. A simpler test clips the flag symbols on both retina
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is
On Fri, 24 Feb 2023 16:50:05 GMT, Andy Goryachev wrote:
> Another question: on non-retina monitor, emojis appear blurry when text size
> is set to 12. I vaguely recall that when resizing down, the resizing
> operation might be followed by a sharpening filter (or perhaps some other op
> can be
On Fri, 24 Feb 2023 16:44:35 GMT, Andy Goryachev wrote:
> I see some clipping of the emoji flag sequence characters, for example
> \ud83c\uddfa\ud83c\udde6 when moving from the primary retina (scale=2) to
> secondary external (scale=1) monitor:
I tried the same size and sequence and in the
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs -
> if there is font
> support for the requested code point.
>
> A simple manual test is
On Thu, 23 Feb 2023 20:12:16 GMT, Andy Goryachev wrote:
> documentation change
> **targeting jfx20 branch**
>
> - fixed all incorrect references in "Also has all properties of ..."
> - added a link to Shape where it was missing
> - fixed chart -> Chart
This pull request has now been
On Fri, 24 Feb 2023 00:24:56 GMT, Thiago Milczarek Sayao
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review changes
Yes, I'll do a review
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
This pull request has now been integrated.
Changeset: 7bf2372b
Author:Nir Lisker
URL:
https://git.openjdk.org/jfx/commit/7bf2372baf8ea719b8b611cd1476596d8c141c50
Stats: 55
On Thu, 23 Feb 2023 20:12:16 GMT, Andy Goryachev wrote:
> documentation change
> **targeting jfx20 branch**
>
> - fixed all incorrect references in "Also has all properties of ..."
> - added a link to Shape where it was missing
> - fixed chart -> Chart
Looks good. Since this is a simple bug
On Fri, 24 Feb 2023 00:24:56 GMT, Thiago Milczarek Sayao
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review changes
This looks good.
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
> Each time a menu would change scenes, a new set of ListChangeListeners would
> be added to the items in the menu. The bigger problem however is that these
> list change listeners have a strong reference to the scene which is
> potentially a much bigger leak.
>
> The first commit was more
On Wed, 22 Feb 2023 19:31:29 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Thu, 23 Feb 2023 09:11:05 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Fri, 24 Feb 2023 06:20:22 GMT, Karthik P K wrote:
>> I would also recommend testing the code on Windows with the screen scale set
>> to 225%, as it might show issues related to fractional scale.
>
>> I get the impression this code also needs to use `caretWidth / 2` instead of
>> `0` and
On Wed, 22 Feb 2023 19:21:41 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
44 matches
Mail list logo
