I think we should wait and don't do this in the short term.
Many recent apps don't care for platform appearance at all.
Take Microsoft windows for an example, there are many layers of "evolution"
and they all look different on the same OS.
Linux will be a nightmare, you have many desktop
Modified the resize algorithm to work well with fractional scale, thanks for
deeper understanding of the problem thanks to @hjohn and @mstr2 .
It is important to note that even though the constraints are given by the user
in unsnapped coordinates, they are converted to snapped values, since
my two drachmas (in addition to the comments in the PR and elsewhere):
#3 I think this API should be unidirectional, i.e. limited to reporting the
platform preferences and their runtime changes to the application (the key set
is immutable, and values cannot be put by the application). Whenever
On Tue, 13 Jun 2023 14:27:32 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $
On Thu, 15 Jun 2023 14:42:43 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> The fix looks good to me.
> Can we add a test to verify the changes?
> Another minor comment:
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There should be no impact since the constructor is package
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Thu, 15 Jun 2023 16:21:35 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request
On Thu, 15 Jun 2023 16:21:35 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request
> I replicated the fix on #1054 on Linux.
>
> Also fixes [Monocle: Stage no longer gets focus after fix for
> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix
On Wed, 14 Jun 2023 15:40:41 GMT, Andy Goryachev wrote:
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There
On Thu, 15 Jun 2023 12:53:39 GMT, Jose Pereda wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2011, 2023, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> `2022, 2023,`
>
> this is one is
On Thu, 15 Jun 2023 12:16:20 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request
On Thu, 15 Jun 2023 12:50:07 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review changes
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
>
On Thu, 15 Jun 2023 12:16:20 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request
On Mon, 24 Apr 2023 11:25:28 GMT, Jose Pereda wrote:
>> Now I see that the call will actually get delayed.
>>
>> `javafx.stage.Window` will do the calls when the window will be shown(). On
>> line 1162 `WindowStage.setScene` is called:
>>
>>
>> peer.setScene(SceneHelper.getPeer(getScene()));
> I replicated the fix on #1054 on Linux.
>
> Also fixes [Monocle: Stage no longer gets focus after fix for
> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
I've recently run into JDK-8149134: when a Text node has been added to a
TextFlow, the Text node's selectionStart and selectionEnd properties are
interpreted relative to the whole TextFlow rather than the individual span,
which means that a selectionFill color may be applied in the wrong place.
On Wed, 1 Mar 2023 13:36:46 GMT, Kevin Rushforth wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more comments and fixed IdentityWrapper hashcode.
>
> @arapte can you be the second reviewer?
@kevinrushforth
19 matches
Mail list logo
