[Openvpn-devel] [XS] Change in openvpn[master]: Test change

2023-10-09 Thread unauthorized (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/401?usp=email to review the following change. Change subject: Test change

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-10-09 Thread unauthorized (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld. unauthorized has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [PATCH] Remove ability to use configurations without TLS by default

2023-10-09 Thread Frank Lichtenheld
From: Arne Schwabe OpenVPN 2.6 already warned about this feature being removed. OpenVPN 2.7 will with this change no longer accept these configurations without having a --allow-deprecated-insecure-static-crypto added to the command line or the configuration itself. This will serve as a last and

[Openvpn-devel] [PATCH] Add warning for the --show-groups command that some groups are missing

2023-10-09 Thread Frank Lichtenheld
From: Arne Schwabe OpenSSL has a weird way of only reporting EC curves that are implemented in a certain way in the list of all EC curves. Note this fact and point out that also the very important curves X448 and X25519 are affected. Change-Id: I86641bf60d62a50e9b2719e809d2429d65c00097

[Openvpn-devel] [PATCH] Print peer temporary key details

2023-10-09 Thread Frank Lichtenheld
From: Arne Schwabe The peer temporary key in TLS session is related to the PFS exchange/generation. From the SSL_get_peer_tmp_key manual page: For example, if ECDHE is in use, then this represents the peer's public ECDHE key. Change-Id: Iaf12bb51a2aac7bcf19070f0b56fa3b1a5863bc3 Acked-by:

[Openvpn-devel] [PATCH] Add warning if a p2p NCP client connects to a p2mp server

2023-10-09 Thread Frank Lichtenheld
From: Arne Schwabe Change-Id: I85ae4e1167e1395b4f59d5d0ecf6c38befcaa8a7 Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/323 This mail reflects

[Openvpn-devel] [PATCH] Change type of frame.mss_fix to uint16_t

2023-10-09 Thread Frank Lichtenheld
Since in the end this always ends up as an uint16_t anyway, just make the conversion much earlier. Cleans up the code and removes some -Wconversion warnings. v2: - proper error handling in options.c v4: - also introduce a minimum mssfix Change-Id: Id8321dfbb8ad8d79f4bb2a9da61f8cd6b6c6ee26

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email ) Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [M] Change in openvpn[master]: Print peer temporary key details

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/364?usp=email ) Change subject: Print peer temporary key details .. Patch Set 6:

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default