[OPSAWG] Tsvart last call review of draft-ietf-opsawg-ipfix-tcpo-v6eh-11

2024-04-20 Thread Wesley Eddy via Datatracker
Reviewer: Wesley Eddy Review result: Ready This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them

Re: [OPSAWG] Tsvart early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-05

2024-01-17 Thread Wesley Eddy
On 1/17/2024 3:34 AM, mohamed.boucad...@orange.com wrote: [Med] This can be part of regular code updates. Please note that this is not unusual in ipfix (see for example ipv4Options, natevent, etc. in https://www.iana.org/assignments/ipfix/ipfix.xhtml which depend on an IANA registry). Ok; do

Re: [OPSAWG] Tsvart early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-05

2024-01-16 Thread Wesley Eddy
On 1/16/2024 11:10 AM, mohamed.boucad...@orange.com wrote: Are you expecting the implementation to have an exhaustive list of all of the ExIDs in use to understand the difference between 2 and 4 byte usage? */[Med] Yes because otherwise an implem can’t unambiguously identify and extract

Re: [OPSAWG] Tsvart early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-05

2024-01-16 Thread Wesley Eddy
The changes look good to me; I just want to make sure you understand one of my questions that doesn't look like it was clear enough: On 1/15/2024 4:13 AM, mohamed.boucad...@orange.com wrote: - The way an implementation understands the TCP ExIDs may benefit from slightly more explanation: --

[OPSAWG] Tsvart early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-05

2024-01-02 Thread Wesley Eddy via Datatracker
Reviewer: Wesley Eddy Review result: Ready with Issues Comments: - The document is well-written and easy to read. - Section 6 is really nice and helpful! Issues: - The way an implementation understands the TCP ExIDs may benefit from slightly more explanation: -- In 4.2 and 4.3, is the idea

[OPSAWG] Tsvart last call review of draft-ietf-opsawg-vpn-common-09

2021-07-30 Thread Wesley Eddy via Datatracker
Reviewer: Wesley Eddy Review result: Ready with Issues This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG

Re: [OPSAWG] Tsvart last call review of draft-ietf-opsawg-vpn-common-06

2021-04-01 Thread Wesley Eddy
Your response all sounds good to me, thanks. On 4/1/2021 3:14 AM, mohamed.boucad...@orange.com wrote: Hi Wes, Thank you for the review. Please see inline. ... ___ OPSAWG mailing list OPSAWG@ietf.org https://www.ietf.org/mailman/listinfo/opsawg

[OPSAWG] Tsvart last call review of draft-ietf-opsawg-vpn-common-06

2021-03-30 Thread Wesley Eddy via Datatracker
Reviewer: Wesley Eddy Review result: Almost Ready This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG