Re: [ovs-dev] [PATCH ovn] tests: Ignore ovs-vswitchd received packet on unknown port.

2024-05-22 Thread Frode Nordahl
On Wed, May 22, 2024 at 9:48 AM Ales Musil wrote: > > > On Mon, May 20, 2024 at 8:56 PM Frode Nordahl wrote: > >> The ovs-vswitchd daemon may in some situations, typically during >> teardown, log a warning level message 'received packet on unknown >> port .

[ovs-dev] [PATCH ovn] tests: Ignore ovs-vswitchd received packet on unknown port.

2024-05-20 Thread Frode Nordahl
The ovs-vswitchd daemon may in some situations, typically during teardown, log a warning level message 'received packet on unknown port ...'. Ignore this message. Reported-at: https://launchpad.net/bugs/2066194 Signed-off-by: Frode Nordahl --- tests/ovn-macros.at | 1 + 1 file changed, 1

[ovs-dev] [PATCH v2] tests: Fix compatibility issue with Python 3.13 in vlog.at.

2024-04-08 Thread Frode Nordahl
-by: Frode Nordahl --- tests/vlog.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vlog.at b/tests/vlog.at index 785014956..efe91479a 100644 --- a/tests/vlog.at +++ b/tests/vlog.at @@ -8,6 +8,7 @@ AT_CHECK([$PYTHON3 $srcdir/test-vlog.py --log-file log_file \ AT_CHECK([sed -e 's

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

2024-04-08 Thread Frode Nordahl
On Mon, Apr 8, 2024 at 9:18 PM Frode Nordahl wrote: > > On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote: > > > > On 4/8/24 16:48, Frode Nordahl wrote: > > > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > > >> > > >> On 4/8/24 16:39, F

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

2024-04-08 Thread Frode Nordahl
On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote: > > On 4/8/24 16:48, Frode Nordahl wrote: > > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > >> > >> On 4/8/24 16:39, Frode Nordahl wrote: > >>> The vlog - Python3 test makes use of output fro

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

2024-04-08 Thread Frode Nordahl
On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > > On 4/8/24 16:39, Frode Nordahl wrote: > > The vlog - Python3 test makes use of output from Python > > Tracebacks in its assertion. > > > > In Python 3.12 a line with tophat (``^``) markers is added below &g

[ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

2024-04-08 Thread Frode Nordahl
of the ``^`` character from the output before performing the test assertions. Note that the extra pair of brackets (``[]``) is required to make m4 pass the expected string (``[[:space:]]``) to sed. Reported-at: https://launchpad.net/bugs/2060434 Signed-off-by: Frode Nordahl --- tests/vlog.at | 1 + 1 file

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

2024-03-28 Thread Frode Nordahl
On Thu, Mar 28, 2024 at 3:03 PM Dumitru Ceara wrote: > > On 3/18/24 22:21, Mark Michelson wrote: > > Thanks Frode, looks good to me. > > > > Acked-by: Mark Michelson > > > > On 3/18/24 07:43, Frode Nordahl wrote: > >> The current code puts the co

Re: [ovs-dev] [RFC ovn] controller: Always populate prefix-length for IPv6 PD.

2024-03-19 Thread Frode Nordahl
On Mon, Mar 18, 2024 at 10:12 PM Frode Nordahl wrote: > > The prefix we obtain is used to fill the ``ipv6_ra_prefixes`` > option for configuration of instances through SLAAC. > > As discussed in RFC 7421 the interface identifier is 64 bits long, > and client implementa

[ovs-dev] [RFC ovn] controller: Always populate prefix-length for IPv6 PD.

2024-03-18 Thread Frode Nordahl
tup, but thought I might as well ask. Is the prefix delegation code supposed to automatically handle internal routing? Signed-off-by: Frode Nordahl --- controller/pinctrl.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/control

[ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

2024-03-18 Thread Frode Nordahl
("northd: Add logical flows for dhcpv6 pfd parsing") Signed-off-by: Frode Nordahl --- northd/northd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 1839b7d8b..7fdd722b5 100644 --- a/northd/northd.c +++ b/northd/northd.c @@

[ovs-dev] [PATCH ovn] controller: Use multicast for IPv6 Prefix Delegation.

2024-03-18 Thread Frode Nordahl
-projects/dhcp/commit/b31fe1d552 2: https://github.com/imp/dnsmasq/blob/770bce967c/src/rfc3315.c#L347-L357 3: https://www.rfc-editor.org/rfc/rfc2375.html Fixes: e3a398e9146e ("controller: Add ipv6 prefix delegation state machine") Signed-off-by: Frode Nordahl --- controller/pinctrl.c

Re: [ovs-dev] [PATCH ovs v4] Documentation: Adding note about using the jemalloc library.

2024-02-07 Thread Frode Nordahl
witch/+bug/2015748 > Signed-off-by: Roberto Bartzen Acosta Thanks, Roberto! Reviewed-by: Frode Nordahl -- Frode Nordahl > --- > Documentation/intro/install/general.rst | 16 > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/intro/install/general.

Re: [ovs-dev] [PATCH ovs v2] Documentation: Adding note about using the jemalloc library.

2024-01-31 Thread Frode Nordahl
I had a couple of nits above, let's hear from one of the maintainers if they agree and if any update could be incorporated as part of a merge before deciding if any iterations are required. Reviewed-by: Frode Nordahl -- Frode Nordahl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovs] Documentation: Adding note about using the jemalloc library.

2024-01-27 Thread Frode Nordahl
On Fri, Jan 26, 2024 at 10:29 PM Roberto Bartzen Acosta wrote: > > > > Em sex., 26 de jan. de 2024 às 16:55, Frode Nordahl > escreveu: >> >> Thanks for raising the patch towards the documentation, Roberto! >> >> On Fri, Jan 26, 2024 at 5:57 PM R

Re: [ovs-dev] [PATCH ovs] Documentation: Adding note about using the jemalloc library.

2024-01-26 Thread Frode Nordahl
could of course spend weeks getting to the bottom of that, or we could tone that part of the commit message and in-line note down and provide a more generic observation based guidance, unless you are certain about the correlation? -- Frode Nordahl > > Updating the reference documentati

Re: [ovs-dev] [PATCH ovs v3] debian/rules: Fix incorrect use of link-time optimizer.

2024-01-26 Thread Frode Nordahl
fre. 26. jan. 2024, 13:03 skrev Roberto Bartzen Acosta < roberto.aco...@luizalabs.com>: > > > Em sex., 26 de jan. de 2024 às 04:37, Frode Nordahl < > frode.nord...@canonical.com> escreveu: > >> On Thu, Jan 25, 2024 at 10:44 PM Frode Nordahl >> wrote: >&g

Re: [ovs-dev] [PATCH ovs v3] debian/rules: Fix incorrect use of link-time optimizer.

2024-01-25 Thread Frode Nordahl
On Thu, Jan 25, 2024 at 10:44 PM Frode Nordahl wrote: > > > > tor. 25. jan. 2024, 22:32 skrev Roberto Bartzen Acosta > : >> >> >> >> Em qui., 25 de jan. de 2024 às 17:01, Frode Nordahl >> escreveu: >>> >>> Apologies for the

Re: [ovs-dev] [PATCH ovs v3] debian/rules: Fix incorrect use of link-time optimizer.

2024-01-25 Thread Frode Nordahl
tor. 25. jan. 2024, 22:32 skrev Roberto Bartzen Acosta < roberto.aco...@luizalabs.com>: > > > Em qui., 25 de jan. de 2024 às 17:01, Frode Nordahl < > frode.nord...@canonical.com> escreveu: > >> Apologies for the tardy response to this thread, freeze deadlines

Re: [ovs-dev] [PATCH ovs v3] debian/rules: Fix incorrect use of link-time optimizer.

2024-01-25 Thread Frode Nordahl
ther our automation was unable to apply this patch. > > > But I have done so locally in my own tree (it is not upstream) > > > and run the GitHub based tests with success: > > > > > > https://github.com/horms/ovs/actions/runs/7448358289 > > > >

[ovs-dev] [PATCH] tests ovsdb-server: Fix config-file same schema test.

2024-01-20 Thread Frode Nordahl
n database 'db': ovsdb error: ordinals: duplicate database name Normalize the logged database name so that the test can focus on the fact that duplication is detected rather than in which order. Fixes: 55140090e63a ("ovsdb-server: Allow user-provided config files.") Signed-off-by: Frode

Re: [ovs-dev] [PATCH v3 0/5] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-17 Thread Frode Nordahl
ons. 17. jan. 2024, 17:27 skrev Ilya Maximets : > On 1/16/24 23:52, Frode Nordahl wrote: > > Introduce cooperative multitasking module which allows us to > > interleave important processing with long running tasks while > > avoiding the additional resource c

[ovs-dev] [PATCH v3 2/5] lib: Introduce cooperative multitasking module.

2024-01-16 Thread Frode Nordahl
patches. Suggested-by: Ilya Maximets Signed-off-by: Frode Nordahl --- lib/automake.mk| 3 + lib/cooperative-multitasking-private.h | 33 +++ lib/cooperative-multitasking.c | 157 + lib/cooperative-multitasking.h | 115 + tests

[ovs-dev] [PATCH v3 5/5] ovsdb-server: Make use of cooperative multitasking.

2024-01-16 Thread Frode Nordahl
success of schema conversion, ensuring no involuntary leader change occurs with election timer configurations as low as 750 msec, on a 75MB database with ~ 100 connected clients as produced by the ovn-heater ocp-120-density-light test scenario. Signed-off-by: Frode Nordahl --- NEWS

[ovs-dev] [PATCH v3 0/5] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-16 Thread Frode Nordahl
review feedback. * Shift yield threshold for RAFT to avoid premature yields when idle (thanks to Ilya for the suggestion). * Reintroduce json_serialized_object_with_yield() with yield at the appropriate places (thanks, Ilya!). Frode Nordahl (5): timeval: Add internal timewarp interface.

[ovs-dev] [PATCH v3 4/5] json: Add yielding json create/destroy functions.

2024-01-16 Thread Frode Nordahl
version in our private lib/json.h. Signed-off-by: Frode Nordahl --- include/openvswitch/json.h | 10 +++ lib/automake.mk| 1 + lib/json.c | 58 -- lib/json.h | 32 + 4 files changed, 87

[ovs-dev] [PATCH v3 1/5] timeval: Add internal timewarp interface.

2024-01-16 Thread Frode Nordahl
that implements unit tests for the cooperative multitasking module. Signed-off-by: Frode Nordahl --- lib/timeval.c | 28 lib/timeval.h | 3 +++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/lib/timeval.c b/lib/timeval.c index 0abe7e555..10c1b9ca1 100644

[ovs-dev] [PATCH v3 3/5] ovsdb raft: Enable cooperative multitasking.

2024-01-16 Thread Frode Nordahl
stable maintenance of the cluster. Signed-off-by: Frode Nordahl --- ovsdb/raft.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index 8effd9ad1..f463afcb3 100644 --- a/ovsdb/raft.c +++ b/ovsdb/raft.c @@ -22,6 +22,7 @@ #include

Re: [ovs-dev] [PATCH v2 4/5] json: Add yielding json destroy function.

2024-01-16 Thread Frode Nordahl
On Tue, Jan 16, 2024 at 9:44 PM Ilya Maximets wrote: > > On 1/13/24 00:00, Frode Nordahl wrote: > > Destroying JSON objects may be time consuming. > > > > Add json_destroy_with_yield() function that make use of the > > cooperative multitasking module to yield during

Re: [ovs-dev] [PATCH v2 3/5] ovsdb raft: Enable cooperative multitasking.

2024-01-16 Thread Frode Nordahl
On Tue, Jan 16, 2024 at 9:33 PM Ilya Maximets wrote: > > On 1/13/24 00:00, Frode Nordahl wrote: > > The OVSDB server is mostly synchronous and single threaded. The > > OVSDB RAFT storage engine operate under strict deadlines with > > operational impact should

Re: [ovs-dev] [PATCH v2 0/6] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-16 Thread Frode Nordahl
On Tue, Jan 16, 2024 at 9:50 PM Ilya Maximets wrote: > > On 1/13/24 00:00, Frode Nordahl wrote: > > Introduce cooperative multitasking module which allows us to > > interleave important processing with long running tasks while > > avoiding the additional resourc

[ovs-dev] [PATCH v2 2/5] lib: Introduce cooperative multitasking module.

2024-01-12 Thread Frode Nordahl
patches. Suggested-by: Ilya Maximets Signed-off-by: Frode Nordahl --- lib/automake.mk| 3 + lib/cooperative-multitasking-private.h | 33 +++ lib/cooperative-multitasking.c | 159 + lib/cooperative-multitasking.h | 114 + tests

[ovs-dev] [PATCH v2 4/5] json: Add yielding json destroy function.

2024-01-12 Thread Frode Nordahl
to OVS by adding a new lib/json.h header file. The include guard in the public include/openvswitch/json.h is updated to contain the OPENVSWITCH prefix to be in line with the other public header files, allowing us to use the non-prefixed version in our private lib/json.h. Signed-off-by: Frode

[ovs-dev] [PATCH v2 5/5] ovsdb-server: Make use of cooperative multitasking.

2024-01-12 Thread Frode Nordahl
success of schema conversion, ensuring no involuntary leader change occurs with election timer configurations as low as 750 msec, on a 75MB database with ~ 100 connected clients as produced by the ovn-heater ocp-120-density-light test scenario. Signed-off-by: Frode Nordahl --- NEWS

[ovs-dev] [PATCH v2 3/5] ovsdb raft: Enable cooperative multitasking.

2024-01-12 Thread Frode Nordahl
stable maintenance of the cluster. Signed-off-by: Frode Nordahl --- ovsdb/raft.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index 8effd9ad1..10c2ef106 100644 --- a/ovsdb/raft.c +++ b/ovsdb/raft.c @@ -22,6 +22,7 @@ #include

[ovs-dev] [PATCH v2 0/6] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-12 Thread Frode Nordahl
ant to investigate poll wait timers but it's not urgent. (And to be fair, the testing environment has been using a ridiculously low value for election timer which we will not find in production environments.) Frode Nordahl (5): timeval: Add internal timewarp interface. lib: Introduce cooperat

[ovs-dev] [PATCH v2 1/5] timeval: Add internal timewarp interface.

2024-01-12 Thread Frode Nordahl
that implements unit tests for the cooperative multitasking module. Signed-off-by: Frode Nordahl --- lib/timeval.c | 28 lib/timeval.h | 3 +++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/lib/timeval.c b/lib/timeval.c index 193c7bab1..f9d442818 100644

Re: [ovs-dev] [PATCH 6/6] ovsdb-server: Make use of cooperative multitasking.

2024-01-12 Thread Frode Nordahl
On Fri, Jan 12, 2024 at 1:40 AM Ilya Maximets wrote: > > On 1/10/24 20:29, Frode Nordahl wrote: > > Initialize the cooperative multitasking module for the > > ovsdb-server. > > > > The server side schema conversion process used for storage > > engines such as

Re: [ovs-dev] [PATCH 5/6] ovsdb-server: Do storage run at top of main loop.

2024-01-12 Thread Frode Nordahl
On Fri, Jan 12, 2024 at 5:20 PM Ilya Maximets wrote: > > On 1/12/24 01:27, Ilya Maximets wrote: > > On 1/10/24 20:29, Frode Nordahl wrote: > >> During testing of the implementation of cooperative multitasking > >> in the ovsdb-server we noticed that the very

Re: [ovs-dev] [PATCH 4/6] json: Add yielding json object create/destroy functions.

2024-01-12 Thread Frode Nordahl
comments on this patch. On Fri, Jan 12, 2024 at 1:26 AM Ilya Maximets wrote: > > On 1/10/24 20:29, Frode Nordahl wrote: > > Creating and destroying JSON objects may be time consuming. > > > > Add yielding counterparts of json_serialized_object_create() and > > json_destr

Re: [ovs-dev] [PATCH 2/6] lib: Introduce cooperative multitasking module.

2024-01-12 Thread Frode Nordahl
On Fri, Jan 12, 2024 at 3:11 PM Ilya Maximets wrote: > > On 1/12/24 12:16, Frode Nordahl wrote: > > On Fri, Jan 12, 2024 at 12:26 AM Ilya Maximets wrote: > >> > >> On 1/10/24 20:29, Frode Nordahl wrote: > >>> One of the goals of Open vSwitch is to

Re: [ovs-dev] [PATCH 2/6] lib: Introduce cooperative multitasking module.

2024-01-12 Thread Frode Nordahl
On Fri, Jan 12, 2024 at 12:26 AM Ilya Maximets wrote: > > On 1/10/24 20:29, Frode Nordahl wrote: > > One of the goals of Open vSwitch is to be as resource efficient as > > possible. Core parts of the program has been implemented as > > asynchronous state machines, and w

Re: [ovs-dev] [PATCH 1/6] timeval: Make timewarp available for internal callers.

2024-01-11 Thread Frode Nordahl
On Thu, Jan 11, 2024 at 10:49 PM Ilya Maximets wrote: > > On 1/10/24 20:29, Frode Nordahl wrote: > > At present the timeval timewarp functionality is tightly coupled > > with the unixctl interface for external operation by test suite. > > > > It is however desirab

Re: [ovs-dev] [PATCH ovn v3] ovn-ctl: Add option to skip schema conversion

2024-01-11 Thread Frode Nordahl
tl script. > > Signed-off-by: Martin Kalcok LGTM, thanks! Reviewed-by: Frode Nordahl -- Frode Nordahl > --- > utilities/ovn-ctl | 7 ++- > utilities/ovn-ctl.8.xml | 21 + > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --g

[ovs-dev] [PATCH 5/6] ovsdb-server: Do storage run at top of main loop.

2024-01-10 Thread Frode Nordahl
run section to the top of the main loop lead to successful results using less yield calls as documented in the commit message of the next commit in this series. Signed-off-by: Frode Nordahl --- ovsdb/ovsdb-server.c | 56 +++- 1 file changed, 29 insertions

[ovs-dev] [PATCH 2/6] lib: Introduce cooperative multitasking module.

2024-01-10 Thread Frode Nordahl
patches. Suggested-by: Ilya Maximets Signed-off-by: Frode Nordahl --- lib/automake.mk| 3 + lib/cooperative-multitasking-private.h | 31 +++ lib/cooperative-multitasking.c | 195 +++ lib/cooperative-multitasking.h | 42 tests

[ovs-dev] [PATCH 6/6] ovsdb-server: Make use of cooperative multitasking.

2024-01-10 Thread Frode Nordahl
of schema conversion, ensuring no involuntary leader change occurs with election timer configurations as low as 750 msec, on a 75MB database with ~ 100 connected clients as produced by the ovn-heater ocp-120-density-light test scenario. Signed-off-by: Frode Nordahl --- NEWS | 8

[ovs-dev] [PATCH 4/6] json: Add yielding json object create/destroy functions.

2024-01-10 Thread Frode Nordahl
to be completed during processing. Signed-off-by: Frode Nordahl --- include/openvswitch/json.h | 16 -- lib/json.c | 63 ++ 2 files changed, 56 insertions(+), 23 deletions(-) diff --git a/include/openvswitch/json.h b/include/openvswitch

[ovs-dev] [PATCH 3/6] ovsdb/raft: Register for cooperative multitasking.

2024-01-10 Thread Frode Nordahl
stable maintenance of the cluster. Signed-off-by: Frode Nordahl --- ovsdb/raft.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index 8effd9ad1..6d2d9afda 100644 --- a/ovsdb/raft.c +++ b/ovsdb/raft.c @@ -22,6 +22,7 @@ #include

[ovs-dev] [PATCH 0/6] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-10 Thread Frode Nordahl
server does not interfere with stable maintenance of the RAFT cluster in subsequent patches. Relevant discussion: https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html https://mail.openvswitch.org/pipermail/ovs-dev/2023-December/410262.html Frode Nordahl (6): timeval: Make

[ovs-dev] [PATCH 1/6] timeval: Make timewarp available for internal callers.

2024-01-10 Thread Frode Nordahl
into separate functions. This will be used in a patch that implements unit tests for the cooperative multitasking module. Signed-off-by: Frode Nordahl --- lib/timeval.c | 56 --- lib/timeval.h | 4 2 files changed, 48 insertions(+), 12 deletions

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-10 Thread Frode Nordahl
ovsdb --db-sb-cluster-local-addr=x.x.x.x > --no-db-cluster-schema-upgrade > + > + > +Trigger clustered DB schema upgrade manually > + > + > +# ovsdb-client convert unix:/var/run/ovn/ovnnb_db.sock > /usr/local/share/ovn/ovn-nb.ovsschema > +# ovsdb-client convert unix:/var/

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-08 Thread Frode Nordahl
s/controll/control > + opt-out of automatic on-start upgrade attempts with > + --db-cluster-skip-upgrade. > + > +Start OVN NB (or SB) clustered database on host with IP x.x.x.x > without schema upgrade > +# ovn-ctl start_nb_ovsdb --db-nb-clu

Re: [ovs-dev] [RFC 0/5] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-08 Thread Frode Nordahl
On Mon, Jan 8, 2024 at 5:52 PM Frode Nordahl wrote: > > Posting this as RFC as I'm not fully content with my test results. > > With this series there are still situations where we overrun the > time threashold and subsequently get into the situation we are trying > to fi

Re: [ovs-dev] OVS "soft freeze" for 3.3 is in effect.

2024-01-08 Thread Frode Nordahl
man. 8. jan. 2024, 21:33 skrev Ilya Maximets : > On 1/8/24 17:59, Frode Nordahl wrote: > > Hello, Ilya and OVS developers, > > > > On Wed, Jan 3, 2024 at 12:59 AM Ilya Maximets > wrote: > >> > >> Hi. As described in Documentation/internals/release-

Re: [ovs-dev] OVS "soft freeze" for 3.3 is in effect.

2024-01-08 Thread Frode Nordahl
en post a formal patch series with documented testing. 0: https://mail.openvswitch.org/pipermail/ovs-dev/2023-December/410262.html 1: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410593.html -- Frode Nordahl > We should branch for version 3.3 in two weeks from now, on Wednesday, Jan 17.

[ovs-dev] [RFC 0/5] Introduce cooperative multitasking to improve OVSDB RAFT cluster operation.

2024-01-08 Thread Frode Nordahl
/2023-December/410262.html Frode Nordahl (5): timeval: Make timewarp available for internal callers. lib: Introduce cooperative multitasking module. ovsdb/raft: Register for cooperative multitasking. json: Add yielding serialized object create function. ovsdb-server: Make use

[ovs-dev] [RFC 2/5] lib: Introduce cooperative multitasking module.

2024-01-08 Thread Frode Nordahl
patches. Suggested-by: Ilya Maximets Signed-off-by: Frode Nordahl --- lib/automake.mk| 3 + lib/cooperative-multitasking-private.h | 30 +++ lib/cooperative-multitasking.c | 192 ++ lib/cooperative-multitasking.h | 42 tests

[ovs-dev] [RFC 4/5] json: Add yielding serialized object create function.

2024-01-08 Thread Frode Nordahl
. Signed-off-by: Frode Nordahl --- include/openvswitch/json.h | 4 +++- lib/json.c | 43 +++--- 2 files changed, 34 insertions(+), 13 deletions(-) diff --git a/include/openvswitch/json.h b/include/openvswitch/json.h index 35b403c29..252425393

[ovs-dev] [RFC 5/5] ovsdb-server: Make use of cooperative multitasking.

2024-01-08 Thread Frode Nordahl
during processing of jsonrpc server requests. The processing of OVSDB monitors for reconnecting clients after a schema conversion is time consuming and a primary offender for missing deadlines, yield during processing. TODO: Document testing done with size/timing results. Signed-off-by: Frode

[ovs-dev] [RFC 3/5] ovsdb/raft: Register for cooperative multitasking.

2024-01-08 Thread Frode Nordahl
maintainenance of the cluster. Signed-off-by: Frode Nordahl --- ovsdb/raft.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index 8effd9ad1..19f31b65c 100644 --- a/ovsdb/raft.c +++ b/ovsdb/raft.c @@ -22,6 +22,7 @@ #include #include

[ovs-dev] [RFC 1/5] timeval: Make timewarp available for internal callers.

2024-01-08 Thread Frode Nordahl
into separate functions. This will be used in a patch that implements unit tests for the cooperative multitasking module. Signed-off-by: Frode Nordahl --- lib/timeval.c | 56 --- lib/timeval.h | 4 2 files changed, 48 insertions(+), 12 deletions

[ovs-dev] [PATCH] lib/backtrace: Fix error in log_backtrace() documentation.

2024-01-05 Thread Frode Nordahl
The documentation for log_backtrace() states the backtrace is logged at DEBUG level, while in reality it is logged at ERROR level. Fixes: d0b99d38edab ("backtrace: Add log_backtrace()") Signed-off-by: Frode Nordahl --- lib/backtrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [ovs-dev] [PATCH 2/2] ovsdb: Abort schema conversion before election timer expires.

2023-12-16 Thread Frode Nordahl
On Fri, Dec 15, 2023 at 11:53 PM Ilya Maximets wrote: > > On 12/13/23 23:19, Frode Nordahl wrote: > > Since the topic of clustered database schema conversion issues was > > first brought up [0], there has been several performance > > improvements which has greatl

Re: [ovs-dev] [PATCH 1/2] ovsdb: Fix use after free on schema conversion error.

2023-12-16 Thread Frode Nordahl
On Fri, Dec 15, 2023 at 7:24 PM Ilya Maximets wrote: > > On 12/13/23 23:19, Frode Nordahl wrote: > > In the event a schema conversion aborts, the cleanup code in > > ovsdb_convert() prior to this patch will remove the in-memory > > copy of the new database prior

Re: [ovs-dev] [PATCH 08/22] ovsdb: Track jsonrpc options per remote.

2023-12-14 Thread Frode Nordahl
On Thu, Dec 14, 2023 at 11:41 AM Ilya Maximets wrote: > > On 12/14/23 08:15, Frode Nordahl wrote: > > On Thu, Dec 14, 2023 at 2:05 AM Ilya Maximets wrote: > >> > >> Store KSON-RPC options for each remote separately, so it will be > > > > s/KSO

Re: [ovs-dev] [PATCH 20/22] ovsdb-server: Allow user-provided config files.

2023-12-13 Thread Frode Nordahl
{}, > "sb.db": { > "service-model": "clustered" As noted earlier in the series, I think we should omit 'standalone' and 'clustered' in the vocabulary so it is clear to the user that this is determined from the on-disk database file a

Re: [ovs-dev] [PATCH 12/22] ovsdb-server: Database config isolation.

2023-12-13 Thread Frode Nordahl
On Thu, Dec 14, 2023 at 2:05 AM Ilya Maximets wrote: > > Add a new structure 'db_config' that holds the user-provided > configuration of the database. And attach this configuration > to each of the databases on the server. > > Each database has a service model: standalone, clustered, relay > or

Re: [ovs-dev] [PATCH 08/22] ovsdb: Track jsonrpc options per remote.

2023-12-13 Thread Frode Nordahl
db/ovsdb-server.c > @@ -101,7 +101,7 @@ static unixctl_cb_func ovsdb_server_get_sync_status; > static unixctl_cb_func ovsdb_server_get_db_storage_status; > > struct server_config { > -struct sset *remotes; > +struct shash *remotes; When reading this patch I was looking

Re: [ovs-dev] [PATCH 00/22] ovsdb-server: Configuration via config-file.

2023-12-13 Thread Frode Nordahl
authoritative source of truth for the service model, and the configured value can get out of sync with the on-disk reality. Throughout the lifetime of a database, the operator may need to momentarily change the service model. Would this not just add to the steps required to do this? 2) Having this in the con

[ovs-dev] [PATCH 1/2] ovsdb: Fix use after free on schema conversion error.

2023-12-13 Thread Frode Nordahl
("ovsdb: Introduce experimental support for clustered databases.") Signed-off-by: Frode Nordahl --- ovsdb/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/file.c b/ovsdb/file.c index 8bd1d4af3..778b4004b 100644 --- a/ovsdb/file.c +++ b/ovsdb/file.c @@ -388,

[ovs-dev] [PATCH 2/2] ovsdb: Abort schema conversion before election timer expires.

2023-12-13 Thread Frode Nordahl
necessary action, such as increasing the election timer, before attempting the schema conversion again. 0: https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html Signed-off-by: Frode Nordahl --- ovsdb/file.c | 78 +--- ovsdb

Re: [ovs-dev] Next OVN technical community meeting

2023-11-29 Thread Frode Nordahl
happen, and I'd understand if everyone else is off/busy. -- Frode Nordahl > Regards, > Dumitru > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 1/8] system-dpdk: Introduce helpers for testpmd.

2023-10-26 Thread Frode Nordahl
tor. 26. okt. 2023, 12:34 skrev David Marchand : > On Thu, Oct 26, 2023 at 10:10 AM Frode Nordahl > wrote: > > > > On Mon, Oct 23, 2023 at 10:19 AM David Marchand > > wrote: > > > > > > Rather than copy/paste everywhere, introduce helpers to control

Re: [ovs-dev] [PATCH v7 1/8] system-dpdk: Introduce helpers for testpmd.

2023-10-26 Thread Frode Nordahl
'" tail -f /dev/null | dpdk-testpmd --socket-mem="$(cat NUMA_NODE)" --no-pci\ --vdev="net_virtio_user,path=$OVS_RUNDIR/dpdkvhostclient0,server=1" \ --vdev="net_tap0,iface=tap0" --file-prefix page0 \ - --single-file-segments -- -

Re: [ovs-dev] [PATCH] tests: Use ping timeout instead of deadline.

2023-10-26 Thread Frode Nordahl
On Wed, Oct 25, 2023 at 11:33 PM Ilya Maximets wrote: > > On 10/25/23 11:45, Simon Horman wrote: > > On Sat, Oct 21, 2023 at 05:04:48PM +0200, Frode Nordahl wrote: > >> Many system tests currently use ping with the combination of a > >> low packet count (-c 3), sh

Re: [ovs-dev] [PATCH v2] tests/system-traffic: Allow warn log on revalidator purge.

2023-10-23 Thread Frode Nordahl
On Mon, Oct 23, 2023 at 9:41 AM Frode Nordahl wrote: > > On Mon, Oct 23, 2023 at 9:01 AM David Marchand > wrote: > > > > Hello Frode, > > > > On Sun, Oct 22, 2023 at 4:53 PM Frode Nordahl > > wrote: > > > > > > There are multiple

Re: [ovs-dev] [PATCH v2] tests/system-traffic: Allow warn log on revalidator purge.

2023-10-23 Thread Frode Nordahl
On Mon, Oct 23, 2023 at 9:01 AM David Marchand wrote: > > Hello Frode, > > On Sun, Oct 22, 2023 at 4:53 PM Frode Nordahl > wrote: > > > > There are multiple system tests that call > > ovs-appctl revalidator/purge. > > > > Whenever this is called th

[ovs-dev] [PATCH v2] tests/system-traffic: Allow warn log on revalidator purge.

2023-10-22 Thread Frode Nordahl
flow The OVS_TRAFFIC_VSWITCHD_STOP macro will fail the test on any warning level message unless it is explicitly allowed. Add the above mentioned messages to the allow list for the affected tests. Signed-off-by: Frode Nordahl --- tests/system-traffic.at | 48

[ovs-dev] [PATCH] tests/system-traffic: Allow warn log on revalidator purge.

2023-10-22 Thread Frode Nordahl
The OVS_TRAFFIC_VSWITCHD_STOP macro will fail the test on any warning level message unless it is explicitly allowed. Add the above mentioned messages to the allow list for the affected tests. Signed-off-by: Frode Nordahl --- tests/system-traffic.at | 48

[ovs-dev] [PATCH] tests: Use ping timeout instead of deadline.

2023-10-21 Thread Frode Nordahl
work. To avoid these kinds of failures in checks where a response is expected, we replace ping -w with ping -W. We keep ping -w for checks where it is expected to NOT get a response. Signed-off-by: Frode Nordahl --- tests/system-afxdp.at | 2 +- tests/

[ovs-dev] [PATCH] tests/system-traffic: Ensure no name resolution for tcpdump.

2023-10-20 Thread Frode Nordahl
with the "conntrack -IPv6 ICMP6 Related with SNAT" test. For consistency, this patch adds the -n parameter to all tcpdump calls in system-traffic.at. Signed-off-by: Frode Nordahl --- tests/system-traffic.at | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --g

Re: [ovs-dev] [PATCH v3 branch-2.17 1/2] conntrack: simplify cleanup path

2023-10-12 Thread Frode Nordahl
packaged version of OVS 2.17.7, and then switched to a packaged version of OVS 2.17.7 with these patches and confirmed that the issue is no longer occurring. The same package has been in production use for the past week, being exposed to real world traffic. No side effects or incidents to report. Teste

Re: [ovs-dev] OVN weekly community meeting

2023-10-06 Thread Frode Nordahl
On Thu, Oct 5, 2023 at 9:20 PM Ilya Maximets wrote: > > On 10/5/23 19:31, Dumitru Ceara wrote: > > Hi all, > > > > On 9/22/23 09:19, Frode Nordahl wrote: > >> Hello Dumitru and Team, > >> > >> On Thu, Sep 21, 2023 at 5:25 PM Dumitru Ceara wro

Re: [ovs-dev] OVN weekly community meeting

2023-09-22 Thread Frode Nordahl
wondering a bit about the cadence though, IIUC the examples of potential topics to discuss fall into the planning ahead category. Would it perhaps make sense to have these meetings before the start of each development cycle, i.e. a set of meetings every 6 months or so, perhaps with touch

Re: [ovs-dev] Build Issue with OVN 23.09 on Ubuntu 22.04

2023-09-21 Thread Frode Nordahl
b package source in the upstream ovn repository is unfortunately not quite up to date. We have an intention to address that and while waiting I'll recommend making use of the downstream Debian/Ubuntu package source [0]. 0: https://salsa.debian.org/openstack-team/third-party/ovn -- Frode Nordahl

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-09-14 Thread Frode Nordahl
On Thu, Sep 14, 2023 at 2:58 PM Dumitru Ceara wrote: > > Hi Frode, > > On 9/12/23 13:51, Frode Nordahl wrote: > > On Thu, Jul 27, 2023 at 1:38 PM Frode Nordahl > > wrote: > >> > >> On Wed, Jul 12, 2023 at 11:40 AM Frode Nordahl > >> wrote

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-09-12 Thread Frode Nordahl
On Thu, Jul 27, 2023 at 1:38 PM Frode Nordahl wrote: > > On Wed, Jul 12, 2023 at 11:40 AM Frode Nordahl > wrote: > > > > On Mon, Jul 10, 2023 at 9:42 AM Frode Nordahl > > wrote: > > > > > > Have now sent out an invite to everyone participatin

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2023-08-31 Thread Frode Nordahl
.e: Reported-by: Michael Plato Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2022-September/052065.html We have a reproducer for the issue and we no longer see it occurring with this patch. Tested-by: Frode Nordahl Is there a plan for a backport, we have users on OVS 2.17 that w

Re: [ovs-dev] [PATCH] tests: Fix time dependency in overlapping flows modification test.

2023-08-28 Thread Frode Nordahl
8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Debian also saw this failure in their riscv64 build [0] and the build passes with this patch [1]. Reviewed-By: Frode Nordahl 0: https://buildd.debian.org/status/fetch.php?pkg=openvswitch=riscv64=3.2.0-1=1693068090=0 1: https://bui

[ovs-dev] [PATCH v3] docs: Fix rendering of VLAN Comparison Chart

2023-08-24 Thread Frode Nordahl
by tree-wide changes, and match the style used by build-aux/extract-ofp-fields. Reported-by: Lucas Nussbaum Reported-at: https://bugs.debian.org/1042358 Signed-off-by: Colin Watson Signed-off-by: Frode Nordahl --- lib/meta-flow.xml | 30 +++--- 1 file changed, 15 insertions

[ovs-dev] [PATCH] lib/fatal-signal: Drop logging of failed dummy backtrace.

2023-08-22 Thread Frode Nordahl
e negative test results. Logging the fact that backtrace() does not work has limited value on a production system and I propose we drop it. Fixes: 759a29dc2d97 ("backtrace: Extend the backtrace functionality.") Reported-at: https://launchpad.net/bugs/2032623 Signed-off-by: Frode Nor

[ovs-dev] [PATCH v3 1/2] docs: Add `nowarn` region option to tables.

2023-08-21 Thread Frode Nordahl
Signed-off-by: Frode Nordahl --- build-aux/extract-ofp-fields | 6 +++--- lib/meta-flow.xml| 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields index efec59c25..6366bd446 100755 --- a/build-aux/extract-ofp

[ovs-dev] [PATCH v3 2/2] docs: Run tbl preprocessor in manpage-check rule.

2023-08-21 Thread Frode Nordahl
From: Colin Watson If we omit this, groff 1.23.0 warns: tbl preprocessor failed, or it or soelim was not run; table(s) likely not rendered (TE macro called with TW register undefined) Reported-by: Lucas Nussbaum Reported-at: https://bugs.debian.org/1042358 Signed-off-by: Colin Watson ---

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-07-27 Thread Frode Nordahl
On Wed, Jul 12, 2023 at 11:40 AM Frode Nordahl wrote: > > On Mon, Jul 10, 2023 at 9:42 AM Frode Nordahl > wrote: > > > > Have now sent out an invite to everyone participating in this thread. > > > > For the benefit of anyone else wanting to attend I'm also sha

[ovs-dev] Time for a 22.03.3 point release?

2023-07-20 Thread Frode Nordahl
s of other goodies on branch-22.03 WDYT? -- Frode Nordahl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 2/2] debian: Run system testsuites as autopkgtest.

2023-07-14 Thread Frode Nordahl
On Wed, Jul 12, 2023 at 11:32 PM Ilya Maximets wrote: > > On 6/27/23 12:11, Frode Nordahl wrote: > > The autopkgtests [0][1] are relevant in an upstream context > > because an Open vSwitch contributor may want to have a quick > > way of running the upstream system testsui

Re: [ovs-dev] [PATCH v4 1/2] debian: Build package with AF_XDP.

2023-07-14 Thread Frode Nordahl
On Wed, Jul 12, 2023 at 10:06 PM Ilya Maximets wrote: > > On 6/27/23 12:11, Frode Nordahl wrote: > > Build the upstream Open vSwitch deb package with AF_XDP datapath > > s/datapath/ports/ Ack. > > enabled when required dependencies are available. > > &g

Re: [ovs-dev] [RFC ovn-heater] OVN scale testing with OpenStack workloads - questionnaire

2023-07-12 Thread Frode Nordahl
On Wed, Jul 12, 2023 at 2:31 PM Felix Huettner wrote: > > On Wed, Jul 12, 2023 at 01:57:18PM +0200, Dumitru Ceara wrote: > > On 7/12/23 13:00, Felix Huettner wrote: > > > Hi everyone, > > > > > > On Wed, Jul 12, 2023 at 12:29:58PM +0200, Dumitru Ceara wrote:

Re: [ovs-dev] [RFC ovn-heater] OVN scale testing with OpenStack workloads - questionnaire

2023-07-12 Thread Frode Nordahl
T) Any suggestions for how to tie these into the questionnaire without causing a matrix explosion? -- Frode Nordahl > Best regards, > Dumitru > > [0] https://mail.openvswitch.org/pipermail/ovs-dev/2023-May/405089.html > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

  1   2   3   4   5   6   >